From: Namjae Jeon <linkinjeon@gmail.com>
To: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] f2fs: give a chance to merge IOs by IO scheduler
Date: Thu, 25 Apr 2013 14:08:03 +0900 [thread overview]
Message-ID: <CAKYAXd84n_4-pe_dN0EQLVsMSpHHQeQq593Uv0ffvij+3sf-ig@mail.gmail.com> (raw)
In-Reply-To: <1366857785-17117-1-git-send-email-jaegeuk.kim@samsung.com>
2013/4/25, Jaegeuk Kim <jaegeuk.kim@samsung.com>:
> Previously, background GC submits many 4KB read requests to load victim
> blocks
> and/or its (i)node blocks.
>
> ...
> f2fs_gc : f2fs_readpage: ino = 1, page_index = 0xb61, blkaddr = 0x3b964ed
> f2fs_gc : block_rq_complete: 8,16 R () 499854968 + 8 [0]
> f2fs_gc : f2fs_readpage: ino = 1, page_index = 0xb6f, blkaddr = 0x3b964ee
> f2fs_gc : block_rq_complete: 8,16 R () 499854976 + 8 [0]
> f2fs_gc : f2fs_readpage: ino = 1, page_index = 0xb79, blkaddr = 0x3b964ef
> f2fs_gc : block_rq_complete: 8,16 R () 499854984 + 8 [0]
> ...
>
> However, by the fact that many IOs are sequential, we can give a chance to
> merge
> the IOs by IO scheduler.
> In order to do that, let's use blk_plug.
>
> ...
> f2fs_gc : f2fs_iget: ino = 143
> f2fs_gc : f2fs_readpage: ino = 143, page_index = 0x1c6, blkaddr = 0x2e6ee
> f2fs_gc : f2fs_iget: ino = 143
> f2fs_gc : f2fs_readpage: ino = 143, page_index = 0x1c7, blkaddr = 0x2e6ef
> <idle> : block_rq_complete: 8,16 R () 1519616 + 8 [0]
> <idle> : block_rq_complete: 8,16 R () 1519848 + 8 [0]
> <idle> : block_rq_complete: 8,16 R () 1520432 + 96 [0]
> <idle> : block_rq_complete: 8,16 R () 1520536 + 104 [0]
> <idle> : block_rq_complete: 8,16 R () 1521008 + 112 [0]
> <idle> : block_rq_complete: 8,16 R () 1521440 + 152 [0]
> <idle> : block_rq_complete: 8,16 R () 1521688 + 144 [0]
> <idle> : block_rq_complete: 8,16 R () 1522128 + 192 [0]
> <idle> : block_rq_complete: 8,16 R () 1523256 + 328 [0]
> ...
>
> Note that this issue should be addressed in checkpoint, and some readahead
> flows too.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Looks reasonable to me :)
Reviewed-by: Namjae Jeon <namjae.jeon@samsung.com>
Thanks~
prev parent reply other threads:[~2013-04-25 5:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 2:43 [PATCH] f2fs: give a chance to merge IOs by IO scheduler Jaegeuk Kim
2013-04-25 5:08 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKYAXd84n_4-pe_dN0EQLVsMSpHHQeQq593Uv0ffvij+3sf-ig@mail.gmail.com \
--to=linkinjeon@gmail.com \
--cc=jaegeuk.kim@samsung.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).