* [PATCH] f2fs: fix a build failure due to missing the kobject header
@ 2013-08-08 7:05 Jaegeuk Kim
2013-08-08 7:15 ` Namjae Jeon
0 siblings, 1 reply; 2+ messages in thread
From: Jaegeuk Kim @ 2013-08-08 7:05 UTC (permalink / raw)
Cc: linux-fsdevel, Namjae Jeon, linux-kernel, linux-f2fs-devel
This patch should resolve the following error reported by kbuild test robot.
All error/warnings:
In file included from fs/f2fs/dir.c:13:0:
>> fs/f2fs/f2fs.h:435:17: error: field 's_kobj' has incomplete type
struct kobject s_kobj;
The failure was caused by missing the kobject header file in dir.c.
So, this patch move the header file to the right location, f2fs.h.
CC: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
---
fs/f2fs/f2fs.h | 1 +
fs/f2fs/super.c | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 13db10b..d8e386ce 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -17,6 +17,7 @@
#include <linux/slab.h>
#include <linux/crc32.h>
#include <linux/magic.h>
+#include <linux/kobject.h>
/*
* For mount options
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 94c0e20..66d1ec1 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -23,7 +23,6 @@
#include <linux/exportfs.h>
#include <linux/blkdev.h>
#include <linux/f2fs_fs.h>
-#include <linux/kobject.h>
#include <linux/sysfs.h>
#include "f2fs.h"
--
1.8.3.1.437.g0dbd812
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] f2fs: fix a build failure due to missing the kobject header
2013-08-08 7:05 [PATCH] f2fs: fix a build failure due to missing the kobject header Jaegeuk Kim
@ 2013-08-08 7:15 ` Namjae Jeon
0 siblings, 0 replies; 2+ messages in thread
From: Namjae Jeon @ 2013-08-08 7:15 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: linux-fsdevel, Namjae Jeon, linux-kernel, linux-f2fs-devel
2013/8/8, Jaegeuk Kim <jaegeuk.kim@samsung.com>:
> This patch should resolve the following error reported by kbuild test
> robot.
>
> All error/warnings:
>
> In file included from fs/f2fs/dir.c:13:0:
> >> fs/f2fs/f2fs.h:435:17: error: field 's_kobj' has incomplete type
> struct kobject s_kobj;
>
> The failure was caused by missing the kobject header file in dir.c.
> So, this patch move the header file to the right location, f2fs.h.
>
> CC: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Oops.. Looks good :)
Thanks Jaegeuk!
> ---
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-08 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-08 7:05 [PATCH] f2fs: fix a build failure due to missing the kobject header Jaegeuk Kim
2013-08-08 7:15 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).