From mboxrd@z Thu Jan 1 00:00:00 1970 From: Namjae Jeon Subject: Re: [PATCH 2/4] f2fs: do not skip writing file meta during fsync Date: Wed, 27 Mar 2013 09:57:46 +0900 Message-ID: References: <1364168414-12815-1-git-send-email-jaegeuk.kim@samsung.com> <1364168414-12815-2-git-send-email-jaegeuk.kim@samsung.com> <1364343513.29882.7.camel@kjgkr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net To: jaegeuk.kim@samsung.com Return-path: In-Reply-To: <1364343513.29882.7.camel@kjgkr> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org 2013/3/27, Jaegeuk Kim : > 2013-03-26 (=ED=99=94), 09:48 +0900, Namjae Jeon: >> 2013/3/25, Jaegeuk Kim : >> > This patch removes data_version check flow during the fsync call. >> > The original purpose for the use of data_version was to avoid writ= ng >> > inode >> > pages redundantly by the fsync calls repeatedly. >> Hi Jaegeuk. >> > However, when user can modify file meta and then call fsync, we sh= ould >> > not >> > skip fsync procedure. >> I have a question. >> Which case does user can directly modify meta ? Recovery tool ? > > The meta means the inode information like atime, mtime, size, and so = on, > which can be modified by setattr() or something other vfs apis. > Thanks, I understood. Thanks for your explanation :) One more,, When inode state is !(inode->i_state & I_DIRTY)), We don't need to ski= p ? Thanks. > >> >> Thanks. >> >> > So, let's remove this condition check and hope that user triggers = in >> > right >> > manner. >> > >> > Signed-off-by: Jaegeuk Kim >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kern= el" >> in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > > -- > Jaegeuk Kim > Samsung >