From: Namjae Jeon <linkinjeon@kernel.org>
To: "Yuezhang.Mo@sony.com" <Yuezhang.Mo@sony.com>
Cc: "sj1557.seo@samsung.com" <sj1557.seo@samsung.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"Andy.Wu@sony.com" <Andy.Wu@sony.com>,
"Wataru.Aoyama@sony.com" <Wataru.Aoyama@sony.com>
Subject: Re: [PATCH v4 1/2] exfat: change to get file size from DataLength
Date: Mon, 27 Nov 2023 09:11:36 +0900 [thread overview]
Message-ID: <CAKYAXd_CFaxxHnQTKYv1dL9n=Ank+tg9mMiUBH6_LVM2xkDV+A@mail.gmail.com> (raw)
In-Reply-To: <PUZPR04MB631680D4803CEE2B1A7F42F381A6A@PUZPR04MB6316.apcprd04.prod.outlook.com>
[snip]
> + map_bh(bh_result, sb, phys);
> + if (buffer_delay(bh_result))
> + clear_buffer_delay(bh_result);
> +
> if (create) {
> + sector_t valid_blks;
> +
> + valid_blks = EXFAT_B_TO_BLK_ROUND_UP(ei->valid_size, sb);
> + if (iblock < valid_blks && iblock + max_blocks >= valid_blks) {
> + max_blocks = valid_blks - iblock;
> + goto done;
> + }
I don't know why this check is needed. And Why do you call
exfat_map_new_buffer() about < valid blocks ?
> +
> err = exfat_map_new_buffer(ei, bh_result, pos);
> if (err) {
> exfat_fs_error(sb,
next prev parent reply other threads:[~2023-11-27 0:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231102095908epcas1p12f13d65d91f093b3541c7c568a7a256b@epcas1p1.samsung.com>
2023-11-02 9:58 ` [PATCH v4 1/2] exfat: change to get file size from DataLength Yuezhang.Mo
2023-11-27 0:11 ` Namjae Jeon [this message]
2023-11-28 6:55 ` Yuezhang.Mo
2023-11-28 9:21 ` Sungjong Seo
[not found] ` <PUZPR04MB6316FB0EDA2C6B92617CD4538183A@PUZPR04MB6316.apcprd04.prod.outlook.com>
2023-11-29 7:24 ` Yuezhang.Mo
2023-11-29 8:50 ` Sungjong Seo
2023-11-30 2:45 ` Yuezhang.Mo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKYAXd_CFaxxHnQTKYv1dL9n=Ank+tg9mMiUBH6_LVM2xkDV+A@mail.gmail.com' \
--to=linkinjeon@kernel.org \
--cc=Andy.Wu@sony.com \
--cc=Wataru.Aoyama@sony.com \
--cc=Yuezhang.Mo@sony.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).