From: Namjae Jeon <linkinjeon@gmail.com>
To: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 3/9] f2fs: remove redundant lock_page calls
Date: Wed, 3 Apr 2013 14:58:49 +0900 [thread overview]
Message-ID: <CAKYAXd_rkU5t=OOxjTu0CtKHfrTYkbJuJ2ZFNd=aaRsuToHU7A@mail.gmail.com> (raw)
In-Reply-To: <1364799360-23145-3-git-send-email-jaegeuk.kim@samsung.com>
2013/4/1, Jaegeuk Kim <jaegeuk.kim@samsung.com>:
> In get_node_page, we do not need to call lock_page all the time.
>
> If the node page is cached as uptodate,
>
> 1. grab_cache_page locks the page,
> 2. read_node_page unlocks the page, and
> 3. lock_page is called for further process.
>
> Let's avoid this.
Instead of removing the function "read_node_page" completely to avoid
the redundant locking, we can simply remove the "unlock" part from the
read_node_page and use the same code in ra_node_page, get_node_page,
get_node_page_ra..
With this patch change, the same code is getting repeated at several
places and IMHO It is not good for the puprose of the modularity.
Please share your opinion.
Thanks.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
> ---
next prev parent reply other threads:[~2013-04-03 5:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 6:55 [PATCH 1/9] f2fs: do not use duplicate names in a macro Jaegeuk Kim
2013-04-01 6:55 ` [PATCH 2/9] f2fs: introduce TOTAL_SECS macro Jaegeuk Kim
2013-04-03 1:17 ` Namjae Jeon
2013-04-01 6:55 ` [PATCH 3/9] f2fs: remove redundant lock_page calls Jaegeuk Kim
2013-04-03 5:58 ` Namjae Jeon [this message]
2013-04-03 8:12 ` [PATCH 3/9 v2] " Jaegeuk Kim
2013-04-03 8:27 ` Namjae Jeon
2013-04-01 6:55 ` [PATCH 4/9] f2fs: allocate new segment aligned with sections Jaegeuk Kim
2013-04-03 6:00 ` Namjae Jeon
2013-04-01 6:55 ` [PATCH 5/9] f2fs: change GC bitmaps to apply the section granularity Jaegeuk Kim
2013-04-03 5:46 ` Namjae Jeon
2013-04-03 8:06 ` [PATCH 5/9 v2] " Jaegeuk Kim
2013-04-03 8:21 ` Namjae Jeon
2013-04-01 6:55 ` [PATCH 6/9] f2fs: check completion of foreground GC Jaegeuk Kim
2013-04-03 5:54 ` Namjae Jeon
2013-04-01 6:55 ` [PATCH 7/9] f2fs: allocate remained free segments in the LFS mode Jaegeuk Kim
2013-04-03 5:59 ` Namjae Jeon
2013-04-01 6:55 ` [PATCH 8/9] f2fs: avoid race for summary information Jaegeuk Kim
2013-04-03 5:54 ` Namjae Jeon
2013-04-01 6:56 ` [PATCH 9/9] f2fs: fix the bitmap consistency of dirty segments Jaegeuk Kim
2013-04-03 1:14 ` Namjae Jeon
2013-04-03 1:15 ` [PATCH 1/9] f2fs: do not use duplicate names in a macro Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKYAXd_rkU5t=OOxjTu0CtKHfrTYkbJuJ2ZFNd=aaRsuToHU7A@mail.gmail.com' \
--to=linkinjeon@gmail.com \
--cc=jaegeuk.kim@samsung.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).