From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f53.google.com ([209.85.215.53]:33312 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966425AbeEJRLp (ORCPT ); Thu, 10 May 2018 13:11:45 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Pavel Shilovsky Date: Thu, 10 May 2018 10:11:43 -0700 Message-ID: Subject: Re: [PATCH] cifs/smb3: directory sync should not return an error To: Steve French Cc: CIFS , linux-fsdevel , samba-technical Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: 2018-05-10 9:04 GMT-07:00 Steve French via samba-technical : > As with NFS, which ignores sync on directory handles, > fsync on a directory handle is a noop for CIFS/SMB3. > Do not return an error on it. It breaks some database > apps otherwise. Reviewed-by: Pavel Shilovsky Best regards, Pavel Shilovsky