From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12B29EB64DD for ; Wed, 5 Jul 2023 09:14:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232033AbjGEJOv (ORCPT ); Wed, 5 Jul 2023 05:14:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229901AbjGEJOu (ORCPT ); Wed, 5 Jul 2023 05:14:50 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB9451716 for ; Wed, 5 Jul 2023 02:14:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688548447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I9KObcq/9SecuVmm4CKMewq3+txouKYR5j2YkQYcKiE=; b=UR2jKDxozHaJrKNvE9YcZBLbLXIuA8MXSy9lxsfBV+GeizoKdFYzSAVq/65zWLMGvRTNOH 5aDd7Q0gJZfpvpnZA87meWRZuapl5109VMh21kEdWz55/O1A4ZRSPHW1XQ8+AGV067hdiV zHR+fz+nV0BL3uOM2SfSB1JYLUYBdU0= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-UaWa-6bMM56zqLYchOS3tw-1; Wed, 05 Jul 2023 05:14:06 -0400 X-MC-Unique: UaWa-6bMM56zqLYchOS3tw-1 Received: by mail-il1-f198.google.com with SMTP id e9e14a558f8ab-3459772e100so26465645ab.3 for ; Wed, 05 Jul 2023 02:14:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688548446; x=1691140446; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I9KObcq/9SecuVmm4CKMewq3+txouKYR5j2YkQYcKiE=; b=I4epU4+6o4xeRI4pQGYyIkA+SqPHj9nzhL0hqGPhi2fyAu2UBdswY2cz0wdWlrJzrb zU1nV6eawOrwiG8bzGm3pp9suByGF4uO9u2epiITi+6RSnA7hiAKv8tzGevfqlz6Lnqm vTmAFhssiCHnH1FSDtUOwDp9e+Zioy/WMWC5THUnVridWgEFCmni5x16zxoaBifdkNne tnK80T1nh476jL25lTpo10JJxD5nmFdUHWjQGjFYbUvccpcw7S98+qWAx4kKgBRkVftv CpCdWZPUlAp4z7hLSEZq/CYBjDmFnHgWib0KwK/GpA8saSwkM1rcUzRXoqZ8RvQtu17P r7lg== X-Gm-Message-State: ABy/qLbEvH1X3U5a2wABL8AU+titfLjpFcuF9KXbvpS93GM+DY/lcd6A eZDcWJJswYn17uucMM53MW1qKMh0uOqgcY+vDENwq4CaMOdRM9DtPEfKhqRagpqwLiTIeudiPm3 fOkJk6BEHUTtxp0CBFEPfzS1JgFZ1MVgHabXUtKZz0w== X-Received: by 2002:a92:d809:0:b0:345:6ffa:63c7 with SMTP id y9-20020a92d809000000b003456ffa63c7mr13304524ilm.32.1688548446204; Wed, 05 Jul 2023 02:14:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlGKQ+5bkvgdDYPjsRcfDKzBh+CiwEjAZyS/bvVvWU80dbfQX28sQg9bP5Uj+kvZiRjbGJlXe8Ub1JjVpdx09U4= X-Received: by 2002:a92:d809:0:b0:345:6ffa:63c7 with SMTP id y9-20020a92d809000000b003456ffa63c7mr13304516ilm.32.1688548445956; Wed, 05 Jul 2023 02:14:05 -0700 (PDT) MIME-Version: 1.0 References: <20230626-fs-overlayfs-mount-api-param-v1-1-29afb997a19f@kernel.org> In-Reply-To: From: Alexander Larsson Date: Wed, 5 Jul 2023 11:13:54 +0200 Message-ID: Subject: Re: [PATCH] ovl: move all parameter handling into params.{c,h} To: Amir Goldstein Cc: Christian Brauner , Miklos Szeredi , linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jul 4, 2023 at 5:14=E2=80=AFPM Amir Goldstein = wrote: > > On Mon, Jul 3, 2023 at 12:16=E2=80=AFPM Alexander Larsson wrote: > > > > On Mon, Jun 26, 2023 at 4:40=E2=80=AFPM Amir Goldstein wrote: > > > > > > On Mon, Jun 26, 2023 at 1:23=E2=80=AFPM Christian Brauner wrote: > > > > > > > > While initially I thought that we couldn't move all new mount api > > > > handling into params.{c,h} it turns out it is possible. So this jus= t > > > > moves a good chunk of code out of super.c and into params.{c,h}. > > > > > > > > Signed-off-by: Christian Brauner > > > > --- > > > > > > > > > > Thank you for this cleanup! > > > > > > Alex, > > > > > > I took the liberty to resolve the conflicts with your branch, see: > > > > > > https://github.com/amir73il/linux/commits/overlay-verity > > > > Thanks, I took a look at this and it seems good. Updated my branch to t= his too. > > > > FYI, I pushed this cleanup commit to overlayfs-next, so > you can rebase overlay-verity v5 on top of that. I rebased it and added some changes based on reviews from erics. > I will send this cleanup to Linus, so we have a clean slate for > the 6.6 cycle. Thanks. -- =3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D= -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D Alexander Larsson Red Hat, Inc alexl@redhat.com alexander.larsson@gmail.com