From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f49.google.com ([209.85.213.49]:33960 "EHLO mail-vk0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932914AbdBWDGj (ORCPT ); Wed, 22 Feb 2017 22:06:39 -0500 Received: by mail-vk0-f49.google.com with SMTP id r136so13147180vke.1 for ; Wed, 22 Feb 2017 19:06:39 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <8737f54rue.fsf@xmission.com> References: <8760k29cku.fsf@xmission.com> <84361910-ba16-79ff-09cd-c76b3f66cc85@suse.de> <8737f54rue.fsf@xmission.com> From: Andy Lutomirski Date: Wed, 22 Feb 2017 19:06:17 -0800 Message-ID: Subject: Re: [GIT PULL] namespaces related fixes for v4.11-rc1 To: "Eric W. Biederman" Cc: Aleksa Sarai , Linus Torvalds , Linux FS Devel , Linux API , Linux Containers , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Feb 22, 2017 at 5:29 PM, Eric W. Biederman wrote: > Aleksa Sarai writes: > >>> The only known user of this prctl systemd >>> forks all children after the prctl. So no userspace regressions will >>> occur. >> >> Note that runC and containerd (and thus Docker) as well as cri-o use the prctl >> as well -- to be able to collect exit codes from a non-child process (namely to >> collect the exit code from PID 1 in the container). > > Are any of those affected by the change? I would not expect so. As it > would require having children or grand children whose exit codes you > don't want to collect. FWIW, I have private code that uses PR_SET_CHILD_SUBREAPER, too. I don't see why it would be affected by this change.