linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@amacapital.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jianyu Zhan <nasa4836@gmail.com>
Subject: Re: 3.15 regression: wrong cgroup magic
Date: Tue, 3 Jun 2014 10:48:11 -0700	[thread overview]
Message-ID: <CALCETrXKbDb-ww+52OWzXMzYDXdFxFZczsKCFOdcEyw2vSy1EQ@mail.gmail.com> (raw)
In-Reply-To: <CA+55aFxfEsOZreYBCrDTfgaSf0441zXf4uSmzsYU-JXHBRkzJg@mail.gmail.com>

On Tue, Jun 3, 2014 at 10:23 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Mon, Jun 2, 2014 at 6:30 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> Of course, Greg could just send it to me for my next branch (since the
>> merge window for 3.16 is already open) and tell me that it's also
>> stable material for 3.15. At _that_ point I'll happily cherry-pick it
>> into master...
>
> Ok, so that happened.
>
> Tejun, just to be anal, can you please test and verify current -git
> (preferably both 'master' and 'next') with your app that cared about
> the f_type information for statfs()..

Did you mean me?

My code seems to work now, and strace says:

fstatfs(6, {f_type=0x27e0eb, f_bsize=4096, f_blocks=0, f_bfree=0, f_bavail=0, f_
files=0, f_ffree=0, f_fsid={0, 0}, f_namelen=255, f_frsize=4096}) = 0

which is consistent with:

#define CGROUP_SUPER_MAGIC      0x27e0eb

This is on master.  I'll test next eventually.

Thanks everyone!

--Andy

  reply	other threads:[~2014-06-03 17:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03  0:56 3.15 regression: wrong cgroup magic Andy Lutomirski
2014-06-03  1:15 ` Linus Torvalds
2014-06-03  1:18 ` Li Zefan
2014-06-03  1:22   ` Tejun Heo
2014-06-03  1:30     ` Linus Torvalds
2014-06-03  4:26       ` Greg Kroah-Hartman
2014-06-03 17:23       ` Linus Torvalds
2014-06-03 17:48         ` Andy Lutomirski [this message]
2014-06-03 17:49           ` Linus Torvalds
2014-06-03 17:52         ` Tejun Heo
2014-06-03 17:53           ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALCETrXKbDb-ww+52OWzXMzYDXdFxFZczsKCFOdcEyw2vSy1EQ@mail.gmail.com \
    --to=luto@amacapital.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=nasa4836@gmail.com \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).