From: Andy Lutomirski <luto@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Solar Designer <solar@openwall.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
Andy Lutomirski <luto@kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs: Reorder inode_owner_or_capable() to avoid needless
Date: Wed, 21 Jun 2017 07:55:26 -0700 [thread overview]
Message-ID: <CALCETrXNPKtWVZFscnj-bZ6xx_x-K5fZ4XL1amwxAy_qGCQdQw@mail.gmail.com> (raw)
In-Reply-To: <20170620214024.GA121654@beast>
On Tue, Jun 20, 2017 at 2:40 PM, Kees Cook <keescook@chromium.org> wrote:
> Checking for capabilities should be the last operation when performing
> access control tests so that PF_SUPERPRIV is set only when it was required
> for success (implying that the capability was needed for the operation).
>
Reviewed-by: Andy Lutomirski <luto@kernel.org>
next prev parent reply other threads:[~2017-06-21 14:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 21:40 [PATCH] fs: Reorder inode_owner_or_capable() to avoid needless Kees Cook
2017-06-20 22:02 ` Serge E. Hallyn
2017-06-21 14:55 ` Andy Lutomirski [this message]
2017-06-30 0:06 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCETrXNPKtWVZFscnj-bZ6xx_x-K5fZ4XL1amwxAy_qGCQdQw@mail.gmail.com \
--to=luto@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=solar@openwall.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).