From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 805D5C001DF for ; Thu, 27 Jul 2023 00:02:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231224AbjG0AC0 (ORCPT ); Wed, 26 Jul 2023 20:02:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230043AbjG0ACZ (ORCPT ); Wed, 26 Jul 2023 20:02:25 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4354187 for ; Wed, 26 Jul 2023 17:02:23 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3fbd33a57b6so3446355e9.2 for ; Wed, 26 Jul 2023 17:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umich.edu; s=google-2016-06-03; t=1690416142; x=1691020942; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sY3QJeaMISaIKdDxKtJKohJ2GJoWkJJcs9mJ7frhIvA=; b=JMeYciZ6extbWy42C5yfWoIXWWCjILjf+vkioU3vFAhPr3DXf5HAt8QftPHoxB9O8e rM7uQXiGVx/Tl7WL29bpf3iyd1apIRCrbcfoXONu/DnbRkY9L8QYnxl6eK2oADbVEBmQ 071Ebtfv3y7ucNEMI8yKpXwMvapTrFBTWmmto1Atz0SWlrzFdueDMJyHzjCFUqu+gYzb s+ADi7TBqxb830QY+YhLKTIbTAwv0O3lsy9bG8h2IppqoeQ/2/23RuZO1rplTAfPCKdL 1kznMyoVGksodV9iTmWhsXZp/8SSXt+Vku0f7/KCkQO46qwONmSCLpav5StP6gxBYelG 9ONA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690416142; x=1691020942; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sY3QJeaMISaIKdDxKtJKohJ2GJoWkJJcs9mJ7frhIvA=; b=bAuT8pC7CTva+d37qCzYEn0wewfDf82C+Q1eKDAXSmayZbbVMn/okYLk2BNkcvMSF1 HcfLOjY0uY4dEsf9xdxynd7tcKjVXKoDwDa/rgPLBY54b8E0zElLU38zfjzKzTMprX06 nxV35pc/aEWpxabvlNxCfHp+Acc4AYhne3KVe4z4rat5OTaks0exj54KHudiPpwFZ5Ij qJc1MAf+XXNyO+P/1u/auZ7Imb8RBc9eXqFVoTEic16dFLNGCRLxiU0kngEmCL5q0LCB NKmy4faLUCC5dtWOIvQa9JfnMm3R5QTPn4sejx0MdUENymRKKhktZ5xPdxEz79WOTmPX bhGg== X-Gm-Message-State: ABy/qLYPiDO/IqIb/8cXUlAvcbbuuT90DqlST4KCZv94DTaukxwxSmQ4 45RreLRIt9b4M44kV0WZG5HwZV8zYi7oyikY4ixFHQ== X-Google-Smtp-Source: APBJJlHXG8MNDeIKShy9xDvHXtfx9gRvwJvCEX2mLcwSYS3qbHbn1nBhhAONPEPTijBgStQmhz/+PlyPRAUGpob8HfU= X-Received: by 2002:a05:6000:1146:b0:314:2d71:1f7a with SMTP id d6-20020a056000114600b003142d711f7amr408985wrx.32.1690416142177; Wed, 26 Jul 2023 17:02:22 -0700 (PDT) MIME-Version: 1.0 References: <20230726164535.230515-1-amiculas@cisco.com> <20230726164535.230515-11-amiculas@cisco.com> In-Reply-To: From: Trevor Gross Date: Wed, 26 Jul 2023 20:02:10 -0400 Message-ID: Subject: Re: [RFC PATCH v2 10/10] rust: puzzlefs: add oci_root_dir and image_manifest filesystem parameters To: Wedson Almeida Filho Cc: Ariel Miculas , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, tycho@tycho.pizza, brauner@kernel.org, viro@zeniv.linux.org.uk, ojeda@kernel.org, alex.gaynor@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jul 26, 2023 at 7:48=E2=80=AFPM Wedson Almeida Filho wrote: > > On Wed, 26 Jul 2023 at 18:08, Trevor Gross wrote: > > > [...] > > The guard syntax (available since 1.65) can make these kinds of match s= tatements > > cleaner: > > This is unstable though. > > We try to stay away from unstable features unless we really need them, > which I feel is not the case here. > Let/else has been stable since 1.65 and is in pretty heavy use, the kernel is on 1.68.2 correct? Could you be thinking of let chains (multiple matches joined with `&&`/`||`)? > let Some(oci_root_dir) =3D data.oci_root_dir else { > pr_err!("missing oci_root_dir parameter!\n"); > return Err(ENOTSUPP); > } > [...]