From: Anand Avati <avati@gluster.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <miklos@szeredi.hu>, <fuse-devel@lists.sourceforge.net>,
<linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] fuse: permit O_DIRECT flag in open()
Date: Thu, 28 Jul 2011 23:42:02 +0530 [thread overview]
Message-ID: <CALmMsH2GoojdyVpXFb0_Z+t8y77QSsatDRAYcDX-fPjUQ1BLCg@mail.gmail.com> (raw)
In-Reply-To: <20110728114943.GA16704@infradead.org>
On Thu, Jul 28, 2011 at 5:19 PM, Christoph Hellwig <hch@infradead.org> wrote:
>
> Your clearing of the O_DIRECT flag is. The current handling of O_DIRECT
> in the VFS is a bit nasty, but if you have an issue with that fix it up
> properly instead of piling more hacks on top of it.
>
Hmm, I thought that the fact VFS checked for O_DIRECT after ->open()
was intentionally giving an opportunity to the filesystem to clear it.
But looking backwards now, I think it was my misunderstanding of the
intention. I will look deeper into a cleaner implementation of
O_DIRECT support.
Avati
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-07-28 18:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 10:56 [PATCH v2 1/2] vfs: pass 'struct file *' as parameter to ->check_flags() methods Anand Avati
[not found] ` <1311764179-20326-1-git-send-email-avati-+FkPdpiNhgJBDgjK7y7TUQ@public.gmane.org>
2011-07-27 10:56 ` [PATCH v2 2/2] fuse: permit O_DIRECT flag in open() Anand Avati
2011-07-27 21:05 ` Christoph Hellwig
2011-07-28 8:14 ` Anand Avati
2011-07-28 11:49 ` Christoph Hellwig
2011-07-28 18:12 ` Anand Avati [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALmMsH2GoojdyVpXFb0_Z+t8y77QSsatDRAYcDX-fPjUQ1BLCg@mail.gmail.com \
--to=avati@gluster.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).