From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F5AC77B72 for ; Thu, 20 Apr 2023 18:56:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230510AbjDTS4G (ORCPT ); Thu, 20 Apr 2023 14:56:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231826AbjDTSzy (ORCPT ); Thu, 20 Apr 2023 14:55:54 -0400 Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9DCC273B for ; Thu, 20 Apr 2023 11:55:52 -0700 (PDT) Received: by mail-qt1-x82a.google.com with SMTP id d75a77b69052e-3ef34c49cb9so893751cf.1 for ; Thu, 20 Apr 2023 11:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682016952; x=1684608952; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hbCxu47aXqOZFjOgElAuAaCkhQzE3b3RJfWYjmehSCc=; b=oa5zJsQrq+PRcAacYKvPmJFEiT892k3KGbGwJQk5suWva6mPaVh1qqAA8IzY+Jj/hD VFBYO4okZJxeVSzysh4ToRnXR/6o5DYUVATkBJfNde9WKEOtWJJ8yy7sY1xXBfZGEY3q xOZ0jkjwyMWdnarfIh0L8R4nUzdGSyWIKSazjknGk1r11LI/2RO684ecfw7UrQTVXs/M GzaTUPkrFcjqNquKq6y2UAqISLWfsxVd028RdcSxBegIpsM6e0JAtRgxUzO7FY9aKxf+ Lt1hLlXFBFqgRdkJ2/8j3ivRECJ5MYEvxha3Z2O262UcpC3xjQwUKeyV2yCazEbahUJf 4cIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682016952; x=1684608952; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hbCxu47aXqOZFjOgElAuAaCkhQzE3b3RJfWYjmehSCc=; b=UbhkkaZm1RPiNvHaO1VULeuLJ9qm4+5tA9fGaU+/dvvWtWp2BKV1AkLt4RI2dwc+PG iMMccHcrd7/Y5i2rKC0p2v3D0Dj451eXtJEVA2VtiC6sjC9m3PXfpFbgm2e97+/hATJ/ O6164MfeobOa8ax2JF4dRJeU8v5BHYID7/4Ea5mJOhW1zgrJnpUgXxUOuteUUTCnIneR Fuxci5RzK2IOZg2QuHHdQSiQGZPgUnucmzKT3BNGYA0B7+qiBxZ93fQw+ZfUnUu3jbr0 FloEoMO4s69M4KuyznHhq6eGve48ZGqMADhLRFzty4TiIYU+f+jlAsxfZSG1Y4MQwklq Fdzg== X-Gm-Message-State: AAQBX9eHyR1exRblZ7NgkDdLW9w8ZicOgZm70J3wI4ui2PxrBvjJS3kc jQE8JR2cbv21oOTEG25u+4Nvqkg7C+N44Ckgm9/u08H2GJ6NA4jLs3o= X-Google-Smtp-Source: AKy350YQ85co+lRTcuWRO1Vltk6Lkvqveeyi1jPBPoTaqbL7736XRkZW9Hessn4M1C1JBov0tCRU8RrPiXoZoB3KNYs= X-Received: by 2002:ac8:5b10:0:b0:3ef:343b:fe7e with SMTP id m16-20020ac85b10000000b003ef343bfe7emr60397qtw.2.1682016952049; Thu, 20 Apr 2023 11:55:52 -0700 (PDT) MIME-Version: 1.0 References: <20230403220337.443510-1-yosryahmed@google.com> <20230403220337.443510-3-yosryahmed@google.com> In-Reply-To: <20230403220337.443510-3-yosryahmed@google.com> From: Shakeel Butt Date: Thu, 20 Apr 2023 11:55:40 -0700 Message-ID: Subject: Re: [PATCH mm-unstable RFC 2/5] memcg: flush stats non-atomically in mem_cgroup_wb_stats() To: Yosry Ahmed Cc: Alexander Viro , Christian Brauner , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Apr 3, 2023 at 3:03=E2=80=AFPM Yosry Ahmed = wrote: > > The previous patch moved the wb_over_bg_thresh()->mem_cgroup_wb_stats() > code path in wb_writeback() outside the lock section. We no longer need > to flush the stats atomically. Flush the stats non-atomically. > > Signed-off-by: Yosry Ahmed Acked-by: Shakeel Butt