From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CA67C10DCE for ; Thu, 12 Mar 2020 21:04:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 657E4206CD for ; Thu, 12 Mar 2020 21:04:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="MFTyMtEC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726571AbgCLVD6 (ORCPT ); Thu, 12 Mar 2020 17:03:58 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:34352 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726892AbgCLVD6 (ORCPT ); Thu, 12 Mar 2020 17:03:58 -0400 Received: by mail-oi1-f195.google.com with SMTP id g6so7060828oiy.1 for ; Thu, 12 Mar 2020 14:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XGC2JJk9vuAk10qDqdB2GLLddE8al5n+2YMC135z7/8=; b=MFTyMtEC8VknjT1M8lTiyfKxTFtMZJGkKIC0Q3oqOBDGa3g7UxELEJgqZr7dTBhnIG ixxjSyj0q8phoYnlMZJjGME2GUQgh5pAAf63BjeJByJJ4nZMO2g6msnLMwkVnTSld628 vXs1tw38JrliwAzoTQUwm3ZeVer/mVXmouFDIIUPlCeQb2Nnr2ECpnwVzd8Jffnq847L QiNrse6GGv2M8iuU1adL+6yqgUds3KlBE9zfU7rjhCZkAWZ684caGPSNeM+QM5CCAgI5 LkUHNmV2YZhICiXf1Xvd3CowoD/bfyFvW7OM0jlAFTbwuSoxJyiwC8MhcFET48g1KhFy su1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XGC2JJk9vuAk10qDqdB2GLLddE8al5n+2YMC135z7/8=; b=mrPPthyPC6XMt2Li5piyZBvKftO1G/luJhQkuoVK4JVXK2YkQTQ2RZt440CG3QxSY+ L1Hm2jXd55E20BZOkFxFNUM4H2xRe2O1cie10W3+oCAMJfL7BlVP0zKS0DCThcRWWJVz Pajz4pY9asLkb5gPiSQP20RVQoNj9eao1I5wNQzBYG+SFPBR8vbDBXGxGCBGhgllm6Kc 8oH2ensPIUpAHtw3gJ2bD4maTkCoTfFmDjyMk4fbBcKIXZfD25CWni6PIFf1+lcxV2st 9pBMlDym/LEOUSXBorCVINyw0HUERtIecDT0fzg/A5kfDKt0/BC+BskcawfHKVVKBYa4 nbQg== X-Gm-Message-State: ANhLgQ3iOiWT3Rx7ur6QGB0X9tILcWofLJ9hG8Ll4nct/WKOJEJ1DK1J j3uIAmJ99r3zs6jVo2knvPU1uO5HaPxylleHXYDplg== X-Google-Smtp-Source: ADFU+vsc3vO05FGfi/ND84Ilaqg41EiWNNRIsnEqcq/qsjLaZwPkhAcV8pix0fNnG+HiTSuwtbRWD5cE0PfcNmiU3Bg= X-Received: by 2002:aca:4b56:: with SMTP id y83mr4412506oia.142.1584047036932; Thu, 12 Mar 2020 14:03:56 -0700 (PDT) MIME-Version: 1.0 References: <20200312200317.31736-1-dxu@dxuuu.xyz> <20200312200317.31736-2-dxu@dxuuu.xyz> In-Reply-To: <20200312200317.31736-2-dxu@dxuuu.xyz> From: Shakeel Butt Date: Thu, 12 Mar 2020 14:03:46 -0700 Message-ID: Subject: Re: [PATCH v3 1/4] kernfs: kvmalloc xattr value instead of kmalloc To: Daniel Xu Cc: Cgroups , Tejun Heo , Li Zefan , Johannes Weiner , Alexander Viro , linux-fsdevel , LKML , Greg Kroah-Hartman , Kernel Team Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Mar 12, 2020 at 1:03 PM Daniel Xu wrote: > > xattr values have a 64k maximum size. This can result in an order 4 > kmalloc request which can be difficult to fulfill. Since xattrs do not > need physically contiguous memory, we can switch to kvmalloc and not > have to worry about higher order allocations failing. > > Signed-off-by: Daniel Xu Reviewed-by: Shakeel Butt