From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D362C433EF for ; Mon, 15 Nov 2021 18:53:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EB2F633C1 for ; Mon, 15 Nov 2021 18:53:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243271AbhKOSzs (ORCPT ); Mon, 15 Nov 2021 13:55:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242627AbhKOSxc (ORCPT ); Mon, 15 Nov 2021 13:53:32 -0500 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DC1CC0A3BDD for ; Mon, 15 Nov 2021 09:53:13 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id k2so29766304lji.4 for ; Mon, 15 Nov 2021 09:53:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6NsJwQViYjBx6x1vnKWwbVuDzGBfSCVWT/rbaDdS07o=; b=KO3K519hv/U7eBTcKvTNDP2eKFUA2AUXYqJpuH3H7HpyMWbd/okypmhcyl68qsgEMB Tk6M3OgdZeFJesvlAB5Bhgl6XW/O9P8mk3dMd4fFh80iqqMofW9VhwiDp62KQ0N/YUUx kuKS6PM57Mxitv2Gso7uX6bsb3i2CsyEFARebzexwMlXFoA74eOMXb002OmB9tn9+Y85 wR9hyRPYMFGUdQX09cuC8rvxOvFIKVUi7nFklVRic3dV6iooqaWcyuL5oVncWpD+oPvG mL1mSaV4SWgyrxi/iuT2d03XoYCARQJVASW7AGQBqLHs2tgGfUQfKdhwJr20mXiPSoOr 4lYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6NsJwQViYjBx6x1vnKWwbVuDzGBfSCVWT/rbaDdS07o=; b=MpXUMWLldXTqBbr1K3pOGRWCejPNquFMmXIELRlCbWlFVo5ySt/ZDrLbtG5ck2/Aa4 RU7sTD7OB8QRqz6q6I9o8a5M0Tr4K9bCcYJr+QfwYqd9NqRZl5pCcvsoaK/9EOjxaahk wTv3SON4ejYPtgiKD7xOH4L+BedoJHpWnEW6OMoTsJSiyYaXiVLb47DzX+4xh256IBdM 6NbdM3I/1LBTfG8JbQ7SGr2O0vBFRPqTuQXyUIE3EUj7fryviASjGMtjU04iPDbohM29 yOXV2BFCQJurdl1O0OyL6LvEuZNz04H1BclaDdV8P9RLYjd0Wn8+i5+1Bsc68LPpQHLi Evkg== X-Gm-Message-State: AOAM531e9cdADwGYlGhpJO0RwQAjR6u2mrUsKjMxYdftGN8S6gmvelsk FMF558CCjSQ2mcGnO5tebtQET7IERiiG5Ezwz4k+8g== X-Google-Smtp-Source: ABdhPJwhwO7vj3l7PglblWhEu/u5R0j6w6RyAXBfY3b1tMLAwK4ATaXsbDMVLHDtN2AxslDULON1DIcW72dsbChwW+w= X-Received: by 2002:a2e:9699:: with SMTP id q25mr448399lji.6.1636998791657; Mon, 15 Nov 2021 09:53:11 -0800 (PST) MIME-Version: 1.0 References: <20211108211959.1750915-1-almasrymina@google.com> <20211108211959.1750915-2-almasrymina@google.com> <20211108221047.GE418105@dread.disaster.area> <20211109011837.GF418105@dread.disaster.area> In-Reply-To: <20211109011837.GF418105@dread.disaster.area> From: Shakeel Butt Date: Mon, 15 Nov 2021 09:53:00 -0800 Message-ID: Subject: Re: [PATCH v1 1/5] mm/shmem: support deterministic charging of tmpfs To: Dave Chinner Cc: Matthew Wilcox , Mina Almasry , Michal Hocko , "Theodore Ts'o" , Greg Thelen , Andrew Morton , Hugh Dickins , Roman Gushchin , Johannes Weiner , Tejun Heo , Vladimir Davydov , riel@surriel.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Nov 8, 2021 at 5:18 PM Dave Chinner wrote: > [...] > > > If we are to have this for all filesystems, then let's do that properly > > and make it generic functionality from its introduction. > > Fully agree. > Mina, I think supporting all filesystems might be a much cleaner solution than adding fs specific code. We need to: 1) Add memcg option handling in vfs_parse_fs_param() before fs specific param handling. 2) Add a new page cache memcg charging interface (similar to swap). With (1), no need to change any fs specific code. With (2), fs codepaths will be free of memcg specific handling. This new interface will be used in __filemap_add_folio(), shmem_add_to_page_cache() and collapse_file(). thanks, Shakeel