[PATCH] mpage: remove ineffective __GFP_HIGH flag

[PATCH] mpage: remove ineffective __GFP_HIGH flag

[Shakeel Butt]

Since the commit 8a5c743e308dd ("mm, memcg: use consistent gfp flags
during readahead") mpage_alloc is clearing all the flag bits other than
bits in GFP_KERNEL internally. Simply remove __GFP_HIGH from the call to
mpage_alloc as it is cleared by it.

Signed-off-by: Shakeel Butt <shakeelb@google.com>
---
 fs/mpage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/mpage.c b/fs/mpage.c
index 87f5cfef6caa..477ccc3f3ac3 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -609,7 +609,7 @@ static int __mpage_writepage(struct page *page, struct writeback_control *wbc,
 				goto out;
 		}
 		bio = mpage_alloc(bdev, blocks[0] << (blkbits - 9),
-				BIO_MAX_VECS, GFP_NOFS|__GFP_HIGH);
+				  BIO_MAX_VECS, GFP_NOFS);
 		if (bio == NULL)
 			goto confused;
 
-- 
2.34.1.703.g22d0c6ccf7-goog

Re: [PATCH] mpage: remove ineffective __GFP_HIGH flag

[Christoph Hellwig]

FYI, I have a patch removing mpage_alloc entirely as part of a bio
allocation refactoring series about to be sent out.  So while your
analysis here is correct I'd prefer to hold this as the issue goes away
entirely.

Re: [PATCH] mpage: remove ineffective __GFP_HIGH flag

[Shakeel Butt]

On Sun, Jan 16, 2022 at 11:15 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> FYI, I have a patch removing mpage_alloc entirely as part of a bio
> allocation refactoring series about to be sent out.  So while your
> analysis here is correct I'd prefer to hold this as the issue goes away
> entirely.

SGTM