From: Richard Hipp <drh@sqlite.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Richard Hipp <drh@hwaci.com>, Jeff Layton <jlayton@redhat.com>,
samba-technical <samba-technical@lists.samba.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
nfs-ganesha-devel <nfs-ganesha-devel@lists.sourceforge.net>
Subject: Re: [PATCH v5 13/14] locks: skip deadlock detection on FL_FILE_PVT locks
Date: Tue, 14 Jan 2014 16:43:32 -0500 [thread overview]
Message-ID: <CALwJ=MzztHThgEKmLcesb01qUiEz2AhGZ7V2K4d_cBU7YWrtdg@mail.gmail.com> (raw)
In-Reply-To: <CALCETrU98m54jd8OHZwR9av2KRenDjHCukZztVD4GCncacjX5w@mail.gmail.com>
On Tue, Jan 14, 2014 at 4:24 PM, Andy Lutomirski <luto@amacapital.net>wrote:
> On Tue, Jan 14, 2014 at 1:21 PM, Richard Hipp <drh@sqlite.org> wrote:
> > I have no context here. I'm not sure what you are discussing or what
> > questions you have or what SQLite has to do with any of it.
> Nevertheless, I
> > have injected a few remarks inline....
> >
>
> The discussion is about a new set of fcntl locking commands that are
> are respect locks acquired with the old ones but suck less. This
> seems like the right time to discuss what would make them even better.
> The immediate change is to let them be owned by the fd instead of the
> process.
>
> This might end up in POSIX and could make sqlite (and lots of other
> things') lives easier.
>
>
Sounds great.
A common cause of SQLite database corruption is when another application
thread does close(open(zDatabaseFile)) and deletes all of SQLite's locks
out from under it. (Usually that happens in a misguided attempt to backup
the database.).
Any help we can get in that area will be appreciated!
--
D. Richard Hipp
drh@sqlite.org
next prev parent reply other threads:[~2014-01-14 21:43 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 14:19 [PATCH v5 00/14] locks: implement "file-private" (aka UNPOSIX) locks Jeff Layton
2014-01-09 14:19 ` [PATCH v5 01/14] locks: close potential race between setlease and open Jeff Layton
2014-01-09 14:19 ` [PATCH v5 02/14] locks: clean up comment typo Jeff Layton
2014-01-09 14:19 ` [PATCH v5 03/14] locks: remove "inline" qualifier from fl_link manipulation functions Jeff Layton
2014-01-09 14:19 ` [PATCH v5 04/14] locks: add __acquires and __releases annotations to locks_start and locks_stop Jeff Layton
2014-01-09 14:19 ` [PATCH v5 05/14] locks: eliminate BUG() call when there's an unexpected lock on file close Jeff Layton
2014-01-09 14:19 ` [PATCH v5 06/14] locks: fix posix lock range overflow handling Jeff Layton
2014-01-09 14:19 ` [PATCH v5 07/14] locks: consolidate checks for compatible filp->f_mode values in setlk handlers Jeff Layton
2014-01-09 14:19 ` [PATCH v5 08/14] MAINTAINERS: add Bruce and myself to list of maintainers for file locking code Jeff Layton
2014-01-09 14:19 ` [PATCH v5 09/14] locks: rename locks_remove_flock to locks_remove_file Jeff Layton
2014-01-09 14:19 ` [PATCH v5 10/14] locks: make /proc/locks show IS_FILE_PVT locks with a P suffix Jeff Layton
2014-01-09 14:19 ` [PATCH v5 11/14] locks: report l_pid as -1 for FL_FILE_PVT locks Jeff Layton
2014-01-09 14:19 ` [PATCH v5 12/14] locks: pass the cmd value to fcntl_getlk/getlk64 Jeff Layton
2014-01-09 14:19 ` [PATCH v5 13/14] locks: skip deadlock detection on FL_FILE_PVT locks Jeff Layton
2014-01-09 20:25 ` Andy Lutomirski
2014-01-10 0:49 ` Jeff Layton
2014-01-10 0:58 ` Andy Lutomirski
2014-01-14 19:27 ` J. Bruce Fields
2014-01-14 20:29 ` Andy Lutomirski
2014-01-14 21:10 ` J. Bruce Fields
2014-01-14 21:17 ` Andy Lutomirski
2014-01-14 21:25 ` J. Bruce Fields
2014-01-14 21:18 ` Jeff Layton
2014-01-14 21:19 ` Frank Filz
2014-01-14 21:24 ` Andy Lutomirski
2014-01-14 21:26 ` Andy Lutomirski
2014-01-14 21:34 ` Frank Filz
2014-01-14 21:51 ` J. Bruce Fields
2014-01-14 22:26 ` Andy Lutomirski
2014-01-14 21:26 ` J. Bruce Fields
2014-01-14 21:21 ` Richard Hipp
2014-01-14 21:24 ` Andy Lutomirski
2014-01-14 21:43 ` Richard Hipp [this message]
2014-01-15 4:10 ` [Nfs-ganesha-devel] " Frank Filz
2014-01-14 21:30 ` J. Bruce Fields
2014-01-09 14:19 ` [PATCH v5 14/14] locks: add new fcntl cmd values for handling file private locks Jeff Layton
2014-01-09 20:29 ` Andy Lutomirski
2014-01-10 0:55 ` Jeff Layton
2014-01-10 1:01 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwJ=MzztHThgEKmLcesb01qUiEz2AhGZ7V2K4d_cBU7YWrtdg@mail.gmail.com' \
--to=drh@sqlite.org \
--cc=drh@hwaci.com \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=nfs-ganesha-devel@lists.sourceforge.net \
--cc=samba-technical@lists.samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).