From: Muchun Song <songmuchun@bytedance.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Alistair Popple <apopple@nvidia.com>,
Yang Shi <shy828301@gmail.com>,
Ralph Campbell <rcampbell@nvidia.com>,
Hugh Dickins <hughd@google.com>,
Xiyu Yang <xiyuyang19@fudan.edu.cn>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Ross Zwisler <zwisler@kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux NVDIMM <nvdimm@lists.linux.dev>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Xiongchun duan <duanxiongchun@bytedance.com>,
Muchun Song <smuchun@gmail.com>
Subject: Re: [PATCH v5 5/6] dax: fix missing writeprotect the pte entry
Date: Tue, 22 Mar 2022 16:46:59 +0800 [thread overview]
Message-ID: <CAMZfGtVBqVwHpoaotp+HF8+Sh-U3onKBBbQY69UT9SrGGOKVtQ@mail.gmail.com> (raw)
In-Reply-To: <YjmK0aaCu/FI/t7T@infradead.org>
On Tue, Mar 22, 2022 at 4:37 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> > +static void dax_entry_mkclean(struct address_space *mapping, unsigned long pfn,
> > + unsigned long npfn, pgoff_t start)
> > {
> > struct vm_area_struct *vma;
> > + pgoff_t end = start + npfn - 1;
> >
> > i_mmap_lock_read(mapping);
> > + vma_interval_tree_foreach(vma, &mapping->i_mmap, start, end) {
> > + pfn_mkclean_range(pfn, npfn, start, vma);
> > cond_resched();
> > }
> > i_mmap_unlock_read(mapping);
>
>
> Is there any point in even keeping this helper vs just open coding it
> in the only caller below?
Good point. I'll fold dax_entry_mkclean() into the caller.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks.
next prev parent reply other threads:[~2022-03-22 8:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 7:45 [PATCH v5 0/6] Fix some bugs related to ramp and dax Muchun Song
2022-03-18 7:45 ` [PATCH v5 1/6] mm: rmap: fix cache flush on THP pages Muchun Song
2022-03-22 8:34 ` Christoph Hellwig
2022-03-18 7:45 ` [PATCH v5 2/6] dax: fix cache flush on PMD-mapped pages Muchun Song
2022-03-22 8:34 ` Christoph Hellwig
2022-03-18 7:45 ` [PATCH v5 3/6] mm: rmap: introduce pfn_mkclean_range() to cleans PTEs Muchun Song
2022-03-18 7:45 ` [PATCH v5 4/6] mm: pvmw: add support for walking devmap pages Muchun Song
2022-03-18 7:45 ` [PATCH v5 5/6] dax: fix missing writeprotect the pte entry Muchun Song
2022-03-22 8:37 ` Christoph Hellwig
2022-03-22 8:46 ` Muchun Song [this message]
2022-03-18 7:45 ` [PATCH v5 6/6] mm: simplify follow_invalidate_pte() Muchun Song
2022-03-22 8:35 ` Christoph Hellwig
2022-03-31 15:55 ` [PATCH v5 0/6] Fix some bugs related to ramp and dax Qian Cai
2022-03-31 22:36 ` Andrew Morton
2022-03-31 22:48 ` Stephen Rothwell
2022-04-01 3:44 ` Muchun Song
2022-04-01 8:50 ` Muchun Song
2022-04-01 11:07 ` Qian Cai
2022-04-02 15:22 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZfGtVBqVwHpoaotp+HF8+Sh-U3onKBBbQY69UT9SrGGOKVtQ@mail.gmail.com \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=duanxiongchun@bytedance.com \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nvdimm@lists.linux.dev \
--cc=rcampbell@nvidia.com \
--cc=shy828301@gmail.com \
--cc=smuchun@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=xiyuyang19@fudan.edu.cn \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).