From: Muchun Song <songmuchun@bytedance.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
apopple@nvidia.com, Yang Shi <shy828301@gmail.com>,
rcampbell@nvidia.com, Hugh Dickins <hughd@google.com>,
Xiyu Yang <xiyuyang19@fudan.edu.cn>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
zwisler@kernel.org, linux-fsdevel <linux-fsdevel@vger.kernel.org>,
nvdimm@lists.linux.dev, LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH 3/5] mm: page_vma_mapped: support checking if a pfn is mapped into a vma
Date: Mon, 24 Jan 2022 17:01:03 +0800 [thread overview]
Message-ID: <CAMZfGtWForYqmrZJFfOVw5pQPq8idQxwT9aFcUuCJMjdE6Tf3Q@mail.gmail.com> (raw)
In-Reply-To: <Ye5XEeMYt8c7/iMV@infradead.org>
On Mon, Jan 24, 2022 at 3:36 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Fri, Jan 21, 2022 at 03:55:13PM +0800, Muchun Song wrote:
> > + if (pvmw->pte && ((pvmw->flags & PVMW_PFN_WALK) || !PageHuge(pvmw->page)))
>
> Please avoid the overly long line here and in a few other places.
OK.
>
> > +/*
> > + * Then at what user virtual address will none of the page be found in vma?
>
> Doesn't parse, what is this trying to say?
Well, I am also confused.
BTW, this is not introduced by me, it is introduced by:
commit 37ffe9f4d7ff ("mm/thp: fix vma_address() if virtual address
below file offset")
If it is really confusing, I can replace this line with:
"Return the end user virtual address of a page within a vma"
Thanks.
next prev parent reply other threads:[~2022-01-24 9:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 7:55 [PATCH 1/5] mm: rmap: fix cache flush on THP pages Muchun Song
2022-01-21 7:55 ` [PATCH 2/5] dax: fix cache flush on PMD-mapped pages Muchun Song
2022-01-24 7:34 ` Christoph Hellwig
2022-01-21 7:55 ` [PATCH 3/5] mm: page_vma_mapped: support checking if a pfn is mapped into a vma Muchun Song
2022-01-24 7:36 ` Christoph Hellwig
2022-01-24 9:01 ` Muchun Song [this message]
2022-01-21 7:55 ` [PATCH 4/5] dax: fix missing writeprotect the pte entry Muchun Song
2022-01-24 7:41 ` Christoph Hellwig
2022-01-24 9:07 ` Muchun Song
2022-01-21 7:55 ` [PATCH 5/5] mm: remove range parameter from follow_invalidate_pte() Muchun Song
2022-01-21 18:05 ` [PATCH 1/5] mm: rmap: fix cache flush on THP pages Yang Shi
2022-01-24 7:34 ` Christoph Hellwig
2022-01-24 8:51 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZfGtWForYqmrZJFfOVw5pQPq8idQxwT9aFcUuCJMjdE6Tf3Q@mail.gmail.com \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nvdimm@lists.linux.dev \
--cc=rcampbell@nvidia.com \
--cc=shy828301@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=xiyuyang19@fudan.edu.cn \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).