From: Milosz Tanski <milosz@adfin.com>
To: David Howells <dhowells@redhat.com>
Cc: "linux-cachefs@redhat.com" <linux-cachefs@redhat.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, NeilBrown <neilb@suse.de>,
Shantanu Goel <sgoel01@yahoo.com>
Subject: Re: [PATCH 1/3] FS-Cache: Timeout for releasepage()
Date: Tue, 29 Jul 2014 11:35:24 -0400 [thread overview]
Message-ID: <CANP1eJFZyZ6X-EaGb6ap911YoF4A63T0o9XUoFAMaEn1OFVX3Q@mail.gmail.com> (raw)
In-Reply-To: <28563.1406647922@warthog.procyon.org.uk>
Originally I was planning doing something with that (a debug message)
but I decided against it and forgot to remove it.
Neil Brown came up with a very similar solution that he posted as I
was developing my own. His patch might be a better candidate.
- M
On Tue, Jul 29, 2014 at 11:32 AM, David Howells <dhowells@redhat.com> wrote:
> Milosz Tanski <milosz@adfin.com> wrote:
>
>> +bool relase_page_wait_timeout(struct fscache_cookie *cookie, struct page *page
>
> I presume you mean "release_page_wait_timeout".
>
> Also, the new function returns a value which you then ignore. Should you do
> something with it?
>
> David
--
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016
p: 646-253-9055
e: milosz@adfin.com
next prev parent reply other threads:[~2014-07-29 15:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1406043029.git.milosz@adfin.com>
2014-07-22 15:50 ` [PATCH 1/3] FS-Cache: Timeout for releasepage() Milosz Tanski
2014-07-22 15:50 ` [PATCH 2/3] FS-Cache: Reduce cookie ref count if submit fails Milosz Tanski
2014-07-22 15:51 ` [PATCH 3/3] FS-Cache: refcount becomes corrupt under vma preasure Milosz Tanski
2014-07-29 15:32 ` [PATCH 1/3] FS-Cache: Timeout for releasepage() David Howells
2014-07-29 15:35 ` Milosz Tanski [this message]
2014-07-29 15:37 ` [PATCH 2/3] FS-Cache: Reduce cookie ref count if submit fails David Howells
2014-08-06 15:21 ` Milosz Tanski
2014-08-11 18:37 ` Milosz Tanski
2014-08-12 12:47 ` David Howells
2014-07-29 16:03 ` [PATCH 3/3] FS-Cache: refcount becomes corrupt under vma preasure David Howells
[not found] <cover.1407948737.git.milosz@adfin.com>
2014-08-13 16:58 ` [PATCH 1/3] FS-Cache: Timeout for releasepage() Milosz Tanski
2014-08-27 14:29 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANP1eJFZyZ6X-EaGb6ap911YoF4A63T0o9XUoFAMaEn1OFVX3Q@mail.gmail.com \
--to=milosz@adfin.com \
--cc=dhowells@redhat.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=sgoel01@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).