From: Stef Bon <stefbon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Miklos Szeredi <miklos-sUDqSbJrdHQHWmgEVkV9KA@public.gmane.org>
Cc: Anand Avati <avati-+FkPdpiNhgJBDgjK7y7TUQ@public.gmane.org>,
fuse-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] fuse: permit O_DIRECT flag in open()
Date: Fri, 22 Jul 2011 17:02:02 +0200 [thread overview]
Message-ID: <CANXojcxyjBBPRYTxkiBGNzTFnirWnfH5_ZGMiahgMzNKkaL8gg@mail.gmail.com> (raw)
In-Reply-To: <87livqfnin.fsf-d8RdFUjzFsbxNFs70CDYszOMxtEWgIxa@public.gmane.org>
I do not like it. Setting O_DIRECT to the flags is an option which
should be set in the filesystem, not in the general library.
I'm working on a overlay fs with various backends, like a normal (part
of) partition on a ATA harddisk, a USB stick, a Cdrom, a mounted SMB
share.... and it is able to set the O_DIRECT flag, but always per
backend.
Stef
2011/7/22 Miklos Szeredi <miklos-sUDqSbJrdHQHWmgEVkV9KA@public.gmane.org>:
> Anand Avati <avati-+FkPdpiNhgJBDgjK7y7TUQ@public.gmane.org> writes:
>
>> but do not permit setting of O_DIRECT flag via fcntl() (or unsetting)
>
> Again, some more verbose description would be good, as well as a
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-07-22 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 8:33 [PATCH 1/2] vfs: pass 'struct file *' as parameter to ->check_flags() methods Anand Avati
[not found] ` <1311323606-15040-1-git-send-email-avati-+FkPdpiNhgJBDgjK7y7TUQ@public.gmane.org>
2011-07-22 8:33 ` [PATCH 2/2] fuse: permit O_DIRECT flag in open() Anand Avati
2011-07-22 13:33 ` Miklos Szeredi
[not found] ` <87livqfnin.fsf-d8RdFUjzFsbxNFs70CDYszOMxtEWgIxa@public.gmane.org>
2011-07-22 15:02 ` Stef Bon [this message]
2011-07-22 13:26 ` [PATCH 1/2] vfs: pass 'struct file *' as parameter to ->check_flags() methods Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANXojcxyjBBPRYTxkiBGNzTFnirWnfH5_ZGMiahgMzNKkaL8gg@mail.gmail.com \
--to=stefbon-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=avati-+FkPdpiNhgJBDgjK7y7TUQ@public.gmane.org \
--cc=fuse-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=miklos-sUDqSbJrdHQHWmgEVkV9KA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).