From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stef Bon Subject: Re: [PATCH 2/2] fuse: permit O_DIRECT flag in open() Date: Fri, 22 Jul 2011 17:02:02 +0200 Message-ID: References: <1311323606-15040-1-git-send-email-avati@gluster.com> <1311323606-15040-2-git-send-email-avati@gluster.com> <87livqfnin.fsf@tucsk.pomaz.szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Anand Avati , fuse-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Miklos Szeredi Return-path: In-Reply-To: <87livqfnin.fsf-d8RdFUjzFsbxNFs70CDYszOMxtEWgIxa@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org I do not like it. Setting O_DIRECT to the flags is an option which should be set in the filesystem, not in the general library. I'm working on a overlay fs with various backends, like a normal (part of) partition on a ATA harddisk, a USB stick, a Cdrom, a mounted SMB share.... and it is able to set the O_DIRECT flag, but always per backend. Stef 2011/7/22 Miklos Szeredi : > Anand Avati writes: > >> but do not permit setting of O_DIRECT flag via fcntl() (or unsetting) > > Again, some more verbose description would be good, as well as a -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html