From: Eiichi Tsukata <devel@etsukata.com>
To: andi@firstfloor.org
Cc: "Theodore Ts'o" <tytso@mit.edu>,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH 0/1] fs: fix race between llseek SEEK_END and write
Date: Sat, 17 Nov 2018 16:29:12 +0900 [thread overview]
Message-ID: <CANhTXPT81K5xbGeXbcMZ8YL1Td7JDqD+CQbnowK_-67acikyqQ@mail.gmail.com> (raw)
In-Reply-To: <20181116154424.da6uz56vatmvz7bo@two.firstfloor.org>
> >
> > Q2. If it is a bug, how should we fix it?
> >
> > Currently I'm planning to re-introduce generic_file_llseek_unlocked()
> > and inode lock in generic_file_llseek() for SEEK_END. Then replace
> > generic_file_llseek() with generic_file_llseek_unlocked() if it called
> > with inode lock in individual file systems. Please let me know if the
> > way is not appropreate or any other better way to fix it.
>
> Sounds reasonable.
>
> -Andi
Thanks for comments. I'll make a patch.
Eiichi
prev parent reply other threads:[~2018-11-17 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 8:37 [RFC PATCH 0/1] fs: fix race between llseek SEEK_END and write Eiichi Tsukata
2018-11-16 8:37 ` [RFC PATCH 1/1] ext4: " Eiichi Tsukata
2018-11-16 15:44 ` [RFC PATCH 0/1] fs: " Andi Kleen
2018-11-17 7:29 ` Eiichi Tsukata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANhTXPT81K5xbGeXbcMZ8YL1Td7JDqD+CQbnowK_-67acikyqQ@mail.gmail.com \
--to=devel@etsukata.com \
--cc=adilger.kernel@dilger.ca \
--cc=andi@firstfloor.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).