From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 195D73191D3 for ; Mon, 1 Dec 2025 17:09:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764608965; cv=none; b=PWdwrSYjEe+1tHW8jW1tugFDTHe18PBXWxvke89CnkFYjXzpDnWx7ChpRCJomUFp/JvMoNzRJyoFMBRB53Bv5+fDW7o14aNtuTx6AKn4a9ErxAw/H3NzHBJ4Fx1ZmpJKIt4GlWIzV54w0y6SJeS+oQX6i1YeOBBL4pQx27tb0/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764608965; c=relaxed/simple; bh=iBbiUzvYi/ln13SU4XKUqRn4bX9H63vGL1eyD6pfsfo=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=O2MxSN+bT0TvQtDIo5MPyLC4+YEiUkTIH9LV+PrJpt132l/Qq9Pak5Uw5ENkSIPKq9RxoLixUG0Qg6YYppjLzA/H4a2vS8jbVGeC7W8SajKla+A1cL/BiGqfDpfF6x3nMF2Qvb0wJTPk4Xgzu0/8Pxl3x8FHsnMUf2QBauq9T54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HC15yTDF; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HC15yTDF" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-be64c3a2849so51071a12.0 for ; Mon, 01 Dec 2025 09:09:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764608963; x=1765213763; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=10oqy7XG0ziR1jN7iIJoYu4N7Sm/NTHUpb4SiggOXnk=; b=HC15yTDFMPAT0Lb1MqdcRSii4KackGdOk4+mnSLFKvQu0v3nYYM0yymTsluA866K0g 4wPZylYTIdvo1CrxrAEL4ajRaxaaWzButBecL9BjilU3/dhFAtW+rojUu8vCC6Yl5zsX BLsenFBgxhaHLFtQuVHpJO+eFAvHVAHZKnAM6STfeELlh3+kopFlC9AJHQmfN9YvaXOK EYX5i08LaZ1RO10SUaY6TrqF+SiwDI4iUDzElt/WUX6WEqCTYSCqHWt2H58UcW3HLowI DTiRX73GhsiFHjfZHTHaRofvWJxqezdVthpcMV7iFihXwXRktd+rLkQb82BU8QLr12Jk /EMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764608963; x=1765213763; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=10oqy7XG0ziR1jN7iIJoYu4N7Sm/NTHUpb4SiggOXnk=; b=svQxgIolNLt9fDj6RdDPX7sNhHGBwEC0P64alnaye7NTfqwGZ8sfNnxTbjcV3n1QFT kGJUdambz5DVlY7IDa6lLoG8s0I1nYRgL+zj5pyfJl/E3k0D7FP+5Sjfc9hMO4tKz+eW hq7XX19ijoNwk1jsSjk+IoQrjxRF6YawGRC9jl4I/8qmQMJ/kS1ukvC7HuziMmfwf03B zkWi1xROan2JiXVcO0TIQXkwPHWUZNLS/9nXUQMMCQ5xb3U9PAorVCpairevucmRxg7M Duk8t5LImRncBaTkTEtuoiSO4gFht4jfSRrD4dQf/oRmaAO9dOsWTeTo3OR4bOkWcfl3 t12w== X-Forwarded-Encrypted: i=1; AJvYcCVuEGLKy28dDybu9MuPn3gONZ5gBd6r3RD3sL6kikD42ohBLhD7ruLGFTrLWChwmJfe05C9ngVNKFzs58/A@vger.kernel.org X-Gm-Message-State: AOJu0YxmztwwneYBpDKiShdLdq5JpyiduZlGDIOBXA3z3fD2f2IbGMt6 MFdcJQrHQ5BPGbkXtkrc7HQKr3XzklUOo64ny4/1pcs4uxrU8kmfRm4HowZRugcI1aKZGylu/M/ CNbuy36dr0ruM9VfTShnL/AZJBGe/NHk= X-Gm-Gg: ASbGncuehjDITnqHFtB3V/yfymZ/magNMhq3l5imyQFTSDo8fn/2Wjm1HGJOs0akV9M IATkg7nw6LgP1tUFR5/zAkiwZPTxlKWE7bItm34L22RHOO5+EZkh0oT8YPVYUNUOl85EU0mzkxW KcRMOoyCf7hCwn/qdZIgtgHfUmosRSO9gENck9Q++PmQhYvtgEA2Hf7KQ/YBtcOxPoWMfw+MPN1 g4gMf3ZGsON19+T5Xc7vSFyQnEf5tM1ci84iGxjmuXIE36h4OWK55D/6936jFI9vmsm15YcKQHV Jg/xxGhZpRLdW2lmHnRJK8SqZ/S4DJQ/aiLSYA2GSf2ow1r5Bowu9UA7DpXDJQSrBiem/1oYk2E hDSQiFeXRm6dSow== X-Google-Smtp-Source: AGHT+IF1YPYGD/E+eDHxFkwlvTUf8jqG51M5LA+tdLWxMqHx4a8yCVti7p4nga92l9CsKYM8VN2f66dz5zEFbxtTTgc= X-Received: by 2002:a05:7301:e24:b0:2a4:3593:2c07 with SMTP id 5a478bee46e88-2a7243ec7b9mr21959223eec.0.1764608963077; Mon, 01 Dec 2025 09:09:23 -0800 (PST) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251117-unique-ref-v13-0-b5b243df1250@pm.me> <20251117-unique-ref-v13-4-b5b243df1250@pm.me> In-Reply-To: From: Miguel Ojeda Date: Mon, 1 Dec 2025 18:09:10 +0100 X-Gm-Features: AWmQ_bnmy3Os7dUuxEXbA4TScnRqySjzLSX-NOnwmbpPdF9z2OcK2znpi-34sDw Message-ID: Subject: Re: [PATCH v13 4/4] rust: Add `OwnableRefCounted` To: Oliver Mangold Cc: Daniel Almeida , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Benno Lossin , Danilo Krummrich , Greg Kroah-Hartman , Dave Ertman , Ira Weiny , Leon Romanovsky , "Rafael J. Wysocki" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Alexander Viro , Christian Brauner , Jan Kara , Lorenzo Stoakes , "Liam R. Howlett" , Viresh Kumar , Nishanth Menon , Stephen Boyd , Bjorn Helgaas , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Paul Moore , Serge Hallyn , Asahi Lina , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, linux-security-module@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Dec 1, 2025 at 11:23=E2=80=AFAM Oliver Mangold wrote: > > Ah, yes, rustfmt must I done that, and I missed it. Will fix. Strange -- if you noticed a case where `rustfmt` wasn't idempotent, please let us (and upstream) know about it. > Not sure what you mean by fictional function. Do you mean a non-existent > function? We want to compile this code as a unit test. Typically that means either using a (hidden on rendering) function that wraps the code and returns a `Result` or directly a doctest that returns one (better, when applicable). Please check other tests for lines like /// # Ok::<(), Error>(()) I hope that helps! Cheers, Miguel