Re: [PATCH 1/4] fs: use splice_copy_file_range() inline helper

[Amir Goldstein <amir73il@gmail.com>]

On Fri, Dec 8, 2023 at 7:33 PM Christian Brauner <brauner@kernel.org> wrote:
>
> > +static inline long splice_copy_file_range(struct file *in, loff_t pos_in,
> > +                                       struct file *out, loff_t pos_out,
> > +                                       size_t len)
> > +{
> > +     return splice_file_range(in, &pos_in, out, &pos_out,
> > +                                   min_t(size_t, len, MAX_RW_COUNT));
> > +}
>
> We should really cleanup the return values of the all the splice
> helpers. Most callers of splice_file_range() use ssize_t already. So
> does splice_direct_to_actor() and splice_to_socket(). IMO, all of the
> splice helpers should just be changed to return ssize_t instead of long.
> Doesn't have to be in this series though.

I agree. This is very annoying. I will add this cleanup patch to v2.

Thanks,
Amir.