From: Amir Goldstein <amir73il@gmail.com>
To: NeilBrown <neilb@suse.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Miklos Szeredi <mszeredi@redhat.com>,
Xavier Roche <xavier.roche@algolia.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH RFC] VFS: lock source directory for link to avoid rename race.
Date: Fri, 16 Sep 2022 17:32:45 +0300 [thread overview]
Message-ID: <CAOQ4uxgS5T=C6E=MeVXg0-kK7cdkXqbVCwnhmStb13yr4y0gxA@mail.gmail.com> (raw)
In-Reply-To: <166330881189.15759.13499931397891560275@noble.neil.brown.name>
On Fri, Sep 16, 2022 at 9:26 AM NeilBrown <neilb@suse.de> wrote:
>
>
> rename(2) is documented as
>
> If newpath already exists, it will be atomically replaced, so
> that there is no point at which another process attempting to
> access newpath will find it missing.
>
> However link(2) from a given path can race with rename renaming to that
> path so that link gets -ENOENT because the path has already been unlinked
> by rename, and creating a link to an unlinked file is not permitted.
>
I have to ask. Is this a real problem or just a matter of respecting
the laws of this man page?
If we manage to return EBUSY in that case to link(2)
will everyone be happy and we can avoid trying to make link(2)
atomic w.r.t. rename(2)?
Thanks,
Amir.
next prev parent reply other threads:[~2022-09-16 14:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 8:20 [PATCH v2] vfs: fix link vs. rename race Miklos Szeredi
2022-02-21 8:56 ` Xavier Roche
2022-09-13 2:04 ` Al Viro
2022-09-13 4:29 ` Al Viro
2022-09-13 8:02 ` Amir Goldstein
2022-09-13 10:03 ` Miklos Szeredi
2022-09-13 4:41 ` NeilBrown
2022-09-13 5:20 ` Al Viro
2022-09-13 5:40 ` Al Viro
2022-09-14 0:14 ` NeilBrown
2022-09-14 1:30 ` Al Viro
2022-09-13 23:52 ` NeilBrown
2022-09-14 0:13 ` Al Viro
2022-09-16 6:13 ` [PATCH RFC] VFS: lock source directory for link to avoid " NeilBrown
2022-09-16 6:28 ` Miklos Szeredi
2022-09-16 6:45 ` NeilBrown
2022-09-16 6:49 ` Al Viro
2022-09-16 14:32 ` Amir Goldstein [this message]
2022-09-19 8:28 ` Christian Brauner
2022-09-19 22:56 ` NeilBrown
2022-09-23 3:02 ` [VFS] 3fb4ec6faa: ltp.linkat02.fail kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQ4uxgS5T=C6E=MeVXg0-kK7cdkXqbVCwnhmStb13yr4y0gxA@mail.gmail.com' \
--to=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=neilb@suse.de \
--cc=viro@zeniv.linux.org.uk \
--cc=xavier.roche@algolia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).