From: Amir Goldstein <amir73il@gmail.com>
To: quentin.bouget@cea.fr
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
MARTINET Dominique 606316 <dominique.martinet@cea.fr>,
Andreas Dilger <adilger@whamcloud.com>,
NeilBrown <neilb@suse.com>, Al Viro <viro@zeniv.linux.org.uk>,
Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: open_by_handle_at: mount_fd opened with O_PATH
Date: Mon, 16 Dec 2019 14:28:29 +0200 [thread overview]
Message-ID: <CAOQ4uxh6pMeNGXDCU2c1v9yRnCjbyr50mFF4y1FphjFM8+yYKQ@mail.gmail.com> (raw)
In-Reply-To: <2759fc54-9576-aaa0-926a-cad9d09d388c@cea.fr>
On Mon, Dec 16, 2019 at 11:39 AM <quentin.bouget@cea.fr> wrote:
>
> Hello,
>
> I recently noticed that the syscall open_by_handle_at() automatically
> fails if
> its first argument is a file descriptor opened with O_PATH. I looked at
> the code
> and saw no reason this could not be allowed. Attached to this mail are a
> a reproducer and the patch I came up with.
>
> I am not quite familiar with the kernel's way of processing patches. Any
> pointer
> or advice on this matter is very welcome.
>
See similar patch by Miklos to do the same for f*xattr() syscalls that
looks simpler:
https://lore.kernel.org/linux-fsdevel/20191128155940.17530-8-mszeredi@redhat.com/
Al, any objections to making this change?
Thanks,
Amir.
next prev parent reply other threads:[~2019-12-16 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 8:53 open_by_handle_at: mount_fd opened with O_PATH quentin.bouget
2019-12-16 12:28 ` Amir Goldstein [this message]
2019-12-16 13:11 ` BOUGET Quentin
2019-12-16 22:34 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxh6pMeNGXDCU2c1v9yRnCjbyr50mFF4y1FphjFM8+yYKQ@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=adilger@whamcloud.com \
--cc=dominique.martinet@cea.fr \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neilb@suse.com \
--cc=quentin.bouget@cea.fr \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).