From: Amir Goldstein <amir73il@gmail.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: syzbot <syzbot+2a73a6ea9507b7112141@syzkaller.appspotmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Miklos Szeredi <mszeredi@redhat.com>,
Oleg Nesterov <oleg@redhat.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
Thomas Gleixner <tglx@linutronix.de>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: possible deadlock in acct_pin_kill
Date: Fri, 19 Apr 2019 10:52:55 +0300 [thread overview]
Message-ID: <CAOQ4uxhm_gShPC_gbRePGoq5xTU3m_cvJ5fosxpyX=aXA5AmCw@mail.gmail.com> (raw)
In-Reply-To: <CACT4Y+bXB06ZAdvwsdgsNvscOUBemH7C_G-ojKirGVeGefCWpQ@mail.gmail.com>
On Thu, Mar 28, 2019 at 10:23 AM Dmitry Vyukov <dvyukov@google.com> wrote:
>
> On Wed, Mar 27, 2019 at 8:16 AM Amir Goldstein <amir73il@gmail.com> wrote:
> >
> > On Wed, Mar 27, 2019 at 5:53 AM syzbot
> > <syzbot+2a73a6ea9507b7112141@syzkaller.appspotmail.com> wrote:
> > >
> > > syzbot has bisected this bug to:
> > >
> > > commit e950564b97fd0f541b02eb207685d0746f5ecf29
> > > Author: Miklos Szeredi <mszeredi@redhat.com>
> > > Date: Tue Jul 24 13:01:55 2018 +0000
> > >
> > > vfs: don't evict uninitialized inode
> > >
> > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12123143200000
> > > start commit: da5322e6 Merge tag 'selinux-pr-20181115' of git://git.kern..
> > > git tree: upstream
> > > final crash: https://syzkaller.appspot.com/x/report.txt?x=11123143200000
> > > console output: https://syzkaller.appspot.com/x/log.txt?x=16123143200000
> > > kernel config: https://syzkaller.appspot.com/x/.config?x=d86f24333880b605
> > > dashboard link: https://syzkaller.appspot.com/bug?extid=2a73a6ea9507b7112141
> > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12298533400000
> > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17ff545d400000
> > >
> > > Reported-by: syzbot+2a73a6ea9507b7112141@syzkaller.appspotmail.com
> > > Fixes: e950564b97fd ("vfs: don't evict uninitialized inode")
> > >
> > > For information about bisection process see: https://goo.gl/tpsmEJ#bisection
> >
> > The repro seems fine for catching the subject bug, but I can't get it
> > to reproduce on my system. I have written a simpler reliable repro.
> > Its in the commit message of the patch to test below:
> >
> > #syz test: https://github.com/amir73il/linux.git acct_pin_kill_deadlock
> >
> > I have been pinging Al about the fix above for a while, but no response:
> >
> > https://marc.info/?l=linux-fsdevel&m=155119096826039&w=2
>
> I would ping it as well, but I can't find it in my inbox. Is it on LKML?
>
No. it's scope is linux-fsdevel.
Anyway, this fix by Al is in linux-next now:
#syz fix: acct_on(): don't mess with freeze protection
Thanks,
Amir.
prev parent reply other threads:[~2019-04-19 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0000000000007dedf00576dd53eb@google.com>
2019-03-27 3:53 ` possible deadlock in acct_pin_kill syzbot
2019-03-27 7:16 ` Amir Goldstein
2019-03-27 15:18 ` syzbot
2019-03-28 8:23 ` Dmitry Vyukov
2019-04-19 7:52 ` Amir Goldstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQ4uxhm_gShPC_gbRePGoq5xTU3m_cvJ5fosxpyX=aXA5AmCw@mail.gmail.com' \
--to=amir73il@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mszeredi@redhat.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=syzbot+2a73a6ea9507b7112141@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).