From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:38689 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752106AbcJZJhU (ORCPT ); Wed, 26 Oct 2016 05:37:20 -0400 MIME-Version: 1.0 In-Reply-To: References: <1477380887-21333-1-git-send-email-mszeredi@redhat.com> From: Amir Goldstein Date: Wed, 26 Oct 2016 12:37:18 +0300 Message-ID: Subject: Re: [PATCH 0/3] overlayfs: allow moving directory trees To: Miklos Szeredi Cc: linux-unionfs@vger.kernel.org, Guillem Jover , Raphael Hertzog , linux-fsdevel Content-Type: text/plain; charset=UTF-8 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Oct 25, 2016 at 11:25 PM, Amir Goldstein wrote: > On Tue, Oct 25, 2016 at 10:34 AM, Miklos Szeredi wrote: >> This allows overlayfs to move directory trees (residing on lower layer) >> without having to recursively copy up the whole tree first. >> >> This series is available in git at: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git#redirect >> > > Gave this a run through xfstests -g quick, pjdfstest and unionmount-testsuite. > After cleaning out all the xerr= failure expectations from unionmount tests, > all tests pass except for rename-pop-dir, which appears to be successful in > removal of non empty dir. > I sent out a patch to ovl_remove_upper() that fixes the problem. > Changes to unionmount-testsuite are available on my github: > https://github.com/amir73il/unionmount-testsuite/tree/ovl_rename_dir > >> And is on top of the overlayfs-next branch. >> >> --- >> Miklos Szeredi (3): >> ovl: check fs features >> vfs: export vfs_path_lookup() >> ovl: redirect on rename-dir >> >> Documentation/filesystems/overlayfs.txt | 33 ++++++++++- >> fs/internal.h | 2 - >> fs/overlayfs/copy_up.c | 20 ++----- >> fs/overlayfs/dir.c | 86 +++++++++++++++++++--------- >> fs/overlayfs/namei.c | 99 ++++++++++++++++++++++++++++++--- >> fs/overlayfs/overlayfs.h | 5 ++ >> fs/overlayfs/ovl_entry.h | 4 ++ >> fs/overlayfs/super.c | 56 +++++++++++++++++-- >> fs/overlayfs/util.c | 19 +++++++ >> include/linux/namei.h | 2 + >> 10 files changed, 268 insertions(+), 58 deletions(-) >> >> -- >> 2.5.5 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html