linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: bschubert@ddn.com, John@groves.net, joannelkoong@gmail.com,
	 linux-fsdevel@vger.kernel.org, bernd@bsbernd.com,
	neal@gompa.dev,  miklos@szeredi.hu
Subject: Re: [PATCH 08/14] libfuse: connect high level fuse library to fuse_reply_attr_iflags
Date: Fri, 18 Jul 2025 16:27:50 +0200	[thread overview]
Message-ID: <CAOQ4uxjRjssQr4M0JQShQHkDh_kh7Risj4BhkfTdfQuBVKY8LQ@mail.gmail.com> (raw)
In-Reply-To: <175279459875.714161.9108157061004962886.stgit@frogsfrogsfrogs>

On Fri, Jul 18, 2025 at 1:36 AM Darrick J. Wong <djwong@kernel.org> wrote:
>
> From: Darrick J. Wong <djwong@kernel.org>
>
> Create a new ->getattr_iflags function so that iomap filesystems can set
> the appropriate in-kernel inode flags on instantiation.
>
> Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> ---
>  include/fuse.h |    7 ++
>  lib/fuse.c     |  219 ++++++++++++++++++++++++++++++++++++++++++++------------
>  2 files changed, 180 insertions(+), 46 deletions(-)
>
>
> diff --git a/include/fuse.h b/include/fuse.h
> index e2e7c950bf144d..f894dd5da0d106 100644
> --- a/include/fuse.h
> +++ b/include/fuse.h
> @@ -876,6 +876,13 @@ struct fuse_operations {
>                             uint64_t attr_ino, off_t pos_in, size_t written_in,
>                             uint32_t ioendflags_in, int error_in,
>                             uint64_t new_addr_in);
> +
> +       /**
> +        * Get file attributes and FUSE_IFLAG_* flags.  Otherwise the same as
> +        * getattr.
> +        */
> +       int (*getattr_iflags) (const char *path, struct stat *buf,
> +                              unsigned int *iflags, struct fuse_file_info *fi);
>  #endif /* FUSE_USE_VERSION >= 318 */
>  };
>
> diff --git a/lib/fuse.c b/lib/fuse.c
> index 8dbf88877dd37c..685d0181e569d0 100644
> --- a/lib/fuse.c
> +++ b/lib/fuse.c
> @@ -123,6 +123,7 @@ struct fuse {
>         struct list_head partial_slabs;
>         struct list_head full_slabs;
>         pthread_t prune_thread;
> +       bool want_iflags;
>  };
>
>  struct lock {
> @@ -144,6 +145,7 @@ struct node {
>         char *name;
>         uint64_t nlookup;
>         int open_count;
> +       unsigned int iflags;
>         struct timespec stat_updated;
>         struct timespec mtime;
>         off_t size;
> @@ -1605,6 +1607,24 @@ int fuse_fs_getattr(struct fuse_fs *fs, const char *path, struct stat *buf,
>         return fs->op.getattr(path, buf, fi);
>  }
>
> +static int fuse_fs_getattr_iflags(struct fuse_fs *fs, const char *path,
> +                                 struct stat *buf, unsigned int *iflags,
> +                                 struct fuse_file_info *fi)
> +{
> +       fuse_get_context()->private_data = fs->user_data;
> +       if (!fs->op.getattr_iflags)
> +               return -ENOSYS;
> +
> +       if (fs->debug) {
> +               char buf[10];
> +
> +               fuse_log(FUSE_LOG_DEBUG, "getattr_iflags[%s] %s\n",
> +                       file_info_string(fi, buf, sizeof(buf)),
> +                       path);
> +       }
> +       return fs->op.getattr_iflags(path, buf, iflags, fi);
> +}
> +
>  int fuse_fs_rename(struct fuse_fs *fs, const char *oldpath,
>                    const char *newpath, unsigned int flags)
>  {
> @@ -2417,7 +2437,7 @@ static void update_stat(struct node *node, const struct stat *stbuf)
>  }
>
>  static int do_lookup(struct fuse *f, fuse_ino_t nodeid, const char *name,
> -                    struct fuse_entry_param *e)
> +                    struct fuse_entry_param *e, unsigned int *iflags)
>  {
>         struct node *node;
>
> @@ -2435,25 +2455,59 @@ static int do_lookup(struct fuse *f, fuse_ino_t nodeid, const char *name,
>                 pthread_mutex_unlock(&f->lock);
>         }
>         set_stat(f, e->ino, &e->attr);
> +       *iflags = node->iflags;
> +       return 0;
> +}
> +
> +static int lookup_and_update(struct fuse *f, fuse_ino_t nodeid,
> +                            const char *name, struct fuse_entry_param *e,
> +                            unsigned int iflags)
> +{
> +       struct node *node;
> +
> +       node = find_node(f, nodeid, name);
> +       if (node == NULL)
> +               return -ENOMEM;
> +
> +       e->ino = node->nodeid;
> +       e->generation = node->generation;
> +       e->entry_timeout = f->conf.entry_timeout;
> +       e->attr_timeout = f->conf.attr_timeout;
> +       if (f->conf.auto_cache) {
> +               pthread_mutex_lock(&f->lock);
> +               update_stat(node, &e->attr);
> +               pthread_mutex_unlock(&f->lock);
> +       }
> +       set_stat(f, e->ino, &e->attr);
> +       node->iflags = iflags;
>         return 0;
>  }
>
>  static int lookup_path(struct fuse *f, fuse_ino_t nodeid,
>                        const char *name, const char *path,
> -                      struct fuse_entry_param *e, struct fuse_file_info *fi)
> +                      struct fuse_entry_param *e, unsigned int *iflags,
> +                      struct fuse_file_info *fi)
>  {
>         int res;
>
>         memset(e, 0, sizeof(struct fuse_entry_param));
> -       res = fuse_fs_getattr(f->fs, path, &e->attr, fi);
> -       if (res == 0) {
> -               res = do_lookup(f, nodeid, name, e);
> -               if (res == 0 && f->conf.debug) {
> -                       fuse_log(FUSE_LOG_DEBUG, "   NODEID: %llu\n",
> -                               (unsigned long long) e->ino);
> -               }
> -       }
> -       return res;
> +       *iflags = 0;
> +       if (f->want_iflags)
> +               res = fuse_fs_getattr_iflags(f->fs, path, &e->attr, iflags, fi);
> +       else
> +               res = fuse_fs_getattr(f->fs, path, &e->attr, fi);
> +       if (res)
> +               return res;
> +
> +       res = lookup_and_update(f, nodeid, name, e, *iflags);
> +       if (res)
> +               return res;
> +
> +       if (f->conf.debug)
> +               fuse_log(FUSE_LOG_DEBUG, "   NODEID: %llu iflags 0x%x\n",
> +                       (unsigned long long) e->ino, *iflags);
> +
> +       return 0;
>  }
>
>  static struct fuse_context_i *fuse_get_context_internal(void)
> @@ -2537,11 +2591,17 @@ static inline void reply_err(fuse_req_t req, int err)
>  }
>
>  static void reply_entry(fuse_req_t req, const struct fuse_entry_param *e,
> -                       int err)
> +                       unsigned int iflags, int err)
>  {
>         if (!err) {
>                 struct fuse *f = req_fuse(req);
> -               if (fuse_reply_entry(req, e) == -ENOENT) {
> +               int entry_res;
> +
> +               if (f->want_iflags)
> +                       entry_res = fuse_reply_entry_iflags(req, e, iflags);
> +               else
> +                       entry_res = fuse_reply_entry(req, e);
> +               if (entry_res == -ENOENT) {
>                         /* Skip forget for negative result */
>                         if  (e->ino != 0)
>                                 forget_node(f, e->ino, 1);
> @@ -2582,6 +2642,9 @@ static void fuse_lib_init(void *data, struct fuse_conn_info *conn)
>                 /* Disable the receiving and processing of FUSE_INTERRUPT requests */
>                 conn->no_interrupt = 1;
>         }
> +
> +       if (fuse_get_feature_flag(conn, FUSE_CAP_IOMAP))
> +               f->want_iflags = true;
>  }
>
>  void fuse_fs_destroy(struct fuse_fs *fs)
> @@ -2605,6 +2668,7 @@ static void fuse_lib_lookup(fuse_req_t req, fuse_ino_t parent,
>         struct fuse *f = req_fuse_prepare(req);
>         struct fuse_entry_param e;
>         char *path;
> +       unsigned int iflags = 0;
>         int err;
>         struct node *dot = NULL;
>
> @@ -2619,7 +2683,7 @@ static void fuse_lib_lookup(fuse_req_t req, fuse_ino_t parent,
>                                 dot = get_node_nocheck(f, parent);
>                                 if (dot == NULL) {
>                                         pthread_mutex_unlock(&f->lock);
> -                                       reply_entry(req, &e, -ESTALE);
> +                                       reply_entry(req, &e, -ESTALE, 0);
>                                         return;
>                                 }
>                                 dot->refctr++;
> @@ -2639,7 +2703,7 @@ static void fuse_lib_lookup(fuse_req_t req, fuse_ino_t parent,
>                 if (f->conf.debug)
>                         fuse_log(FUSE_LOG_DEBUG, "LOOKUP %s\n", path);
>                 fuse_prepare_interrupt(f, req, &d);
> -               err = lookup_path(f, parent, name, path, &e, NULL);
> +               err = lookup_path(f, parent, name, path, &e, &iflags, NULL);
>                 if (err == -ENOENT && f->conf.negative_timeout != 0.0) {
>                         e.ino = 0;
>                         e.entry_timeout = f->conf.negative_timeout;
> @@ -2653,7 +2717,7 @@ static void fuse_lib_lookup(fuse_req_t req, fuse_ino_t parent,
>                 unref_node(f, dot);
>                 pthread_mutex_unlock(&f->lock);
>         }
> -       reply_entry(req, &e, err);
> +       reply_entry(req, &e, iflags, err);
>  }
>
>  static void do_forget(struct fuse *f, fuse_ino_t ino, uint64_t nlookup)
> @@ -2689,6 +2753,7 @@ static void fuse_lib_getattr(fuse_req_t req, fuse_ino_t ino,
>         struct fuse *f = req_fuse_prepare(req);
>         struct stat buf;
>         char *path;
> +       unsigned int iflags = 0;
>         int err;
>
>         memset(&buf, 0, sizeof(buf));
> @@ -2700,7 +2765,11 @@ static void fuse_lib_getattr(fuse_req_t req, fuse_ino_t ino,
>         if (!err) {
>                 struct fuse_intr_data d;
>                 fuse_prepare_interrupt(f, req, &d);
> -               err = fuse_fs_getattr(f->fs, path, &buf, fi);
> +               if (f->want_iflags)
> +                       err = fuse_fs_getattr_iflags(f->fs, path, &buf,
> +                                                    &iflags, fi);
> +               else
> +                       err = fuse_fs_getattr(f->fs, path, &buf, fi);
>                 fuse_finish_interrupt(f, req, &d);
>                 free_path(f, ino, path);
>         }
> @@ -2713,9 +2782,14 @@ static void fuse_lib_getattr(fuse_req_t req, fuse_ino_t ino,
>                         buf.st_nlink--;
>                 if (f->conf.auto_cache)
>                         update_stat(node, &buf);
> +               node->iflags = iflags;
>                 pthread_mutex_unlock(&f->lock);
>                 set_stat(f, ino, &buf);
> -               fuse_reply_attr(req, &buf, f->conf.attr_timeout);
> +               if (f->want_iflags)
> +                       fuse_reply_attr_iflags(req, &buf, iflags,
> +                                              f->conf.attr_timeout);
> +               else
> +                       fuse_reply_attr(req, &buf, f->conf.attr_timeout);
>         } else
>                 reply_err(req, err);
>  }
> @@ -2802,6 +2876,7 @@ static void fuse_lib_setattr(fuse_req_t req, fuse_ino_t ino, struct stat *attr,
>         struct fuse *f = req_fuse_prepare(req);
>         struct stat buf;
>         char *path;
> +       unsigned int iflags = 0;
>         int err;
>
>         memset(&buf, 0, sizeof(buf));
> @@ -2860,19 +2935,30 @@ static void fuse_lib_setattr(fuse_req_t req, fuse_ino_t ino, struct stat *attr,
>                         err = fuse_fs_utimens(f->fs, path, tv, fi);
>                 }
>                 if (!err) {
> -                       err = fuse_fs_getattr(f->fs, path, &buf, fi);
> +                       if (f->want_iflags)
> +                               err = fuse_fs_getattr_iflags(f->fs, path, &buf,
> +                                                            &iflags, fi);
> +                       else
> +                               err = fuse_fs_getattr(f->fs, path, &buf, fi);
>                 }
>                 fuse_finish_interrupt(f, req, &d);
>                 free_path(f, ino, path);
>         }
>         if (!err) {
> -               if (f->conf.auto_cache) {
> -                       pthread_mutex_lock(&f->lock);
> -                       update_stat(get_node(f, ino), &buf);
> -                       pthread_mutex_unlock(&f->lock);
> -               }
> +               struct node *node;
> +
> +               pthread_mutex_lock(&f->lock);
> +               node = get_node(f, ino);
> +               if (f->conf.auto_cache)
> +                       update_stat(node, &buf);
> +               node->iflags = iflags;
> +               pthread_mutex_unlock(&f->lock);
>                 set_stat(f, ino, &buf);
> -               fuse_reply_attr(req, &buf, f->conf.attr_timeout);
> +               if (f->want_iflags)
> +                       fuse_reply_attr_iflags(req, &buf, iflags,
> +                                              f->conf.attr_timeout);
> +               else
> +                       fuse_reply_attr(req, &buf, f->conf.attr_timeout);
>         } else
>                 reply_err(req, err);
>  }
> @@ -2923,6 +3009,7 @@ static void fuse_lib_mknod(fuse_req_t req, fuse_ino_t parent, const char *name,
>         struct fuse *f = req_fuse_prepare(req);
>         struct fuse_entry_param e;
>         char *path;
> +       unsigned int iflags = 0;
>         int err;
>
>         err = get_path_name(f, parent, name, &path);
> @@ -2939,7 +3026,7 @@ static void fuse_lib_mknod(fuse_req_t req, fuse_ino_t parent, const char *name,
>                         err = fuse_fs_create(f->fs, path, mode, &fi);
>                         if (!err) {
>                                 err = lookup_path(f, parent, name, path, &e,
> -                                                 &fi);
> +                                                 &iflags, &fi);
>                                 fuse_fs_release(f->fs, path, &fi);
>                         }
>                 }
> @@ -2947,12 +3034,12 @@ static void fuse_lib_mknod(fuse_req_t req, fuse_ino_t parent, const char *name,
>                         err = fuse_fs_mknod(f->fs, path, mode, rdev);
>                         if (!err)
>                                 err = lookup_path(f, parent, name, path, &e,
> -                                                 NULL);
> +                                                 &iflags, NULL);
>                 }
>                 fuse_finish_interrupt(f, req, &d);
>                 free_path(f, parent, path);
>         }
> -       reply_entry(req, &e, err);
> +       reply_entry(req, &e, iflags, err);
>  }
>
>  static void fuse_lib_mkdir(fuse_req_t req, fuse_ino_t parent, const char *name,
> @@ -2961,6 +3048,7 @@ static void fuse_lib_mkdir(fuse_req_t req, fuse_ino_t parent, const char *name,
>         struct fuse *f = req_fuse_prepare(req);
>         struct fuse_entry_param e;
>         char *path;
> +       unsigned int iflags = 0;
>         int err;
>
>         err = get_path_name(f, parent, name, &path);
> @@ -2970,11 +3058,12 @@ static void fuse_lib_mkdir(fuse_req_t req, fuse_ino_t parent, const char *name,
>                 fuse_prepare_interrupt(f, req, &d);
>                 err = fuse_fs_mkdir(f->fs, path, mode);
>                 if (!err)
> -                       err = lookup_path(f, parent, name, path, &e, NULL);
> +                       err = lookup_path(f, parent, name, path, &e, &iflags,
> +                                         NULL);
>                 fuse_finish_interrupt(f, req, &d);
>                 free_path(f, parent, path);
>         }
> -       reply_entry(req, &e, err);
> +       reply_entry(req, &e, iflags, err);
>  }
>
>  static void fuse_lib_unlink(fuse_req_t req, fuse_ino_t parent,
> @@ -3044,6 +3133,7 @@ static void fuse_lib_symlink(fuse_req_t req, const char *linkname,
>         struct fuse *f = req_fuse_prepare(req);
>         struct fuse_entry_param e;
>         char *path;
> +       unsigned int iflags = 0;
>         int err;
>
>         err = get_path_name(f, parent, name, &path);
> @@ -3053,11 +3143,12 @@ static void fuse_lib_symlink(fuse_req_t req, const char *linkname,
>                 fuse_prepare_interrupt(f, req, &d);
>                 err = fuse_fs_symlink(f->fs, linkname, path);
>                 if (!err)
> -                       err = lookup_path(f, parent, name, path, &e, NULL);
> +                       err = lookup_path(f, parent, name, path, &e, &iflags,
> +                                         NULL);
>                 fuse_finish_interrupt(f, req, &d);
>                 free_path(f, parent, path);
>         }
> -       reply_entry(req, &e, err);
> +       reply_entry(req, &e, iflags, err);
>  }
>
>  static void fuse_lib_rename(fuse_req_t req, fuse_ino_t olddir,
> @@ -3105,6 +3196,7 @@ static void fuse_lib_link(fuse_req_t req, fuse_ino_t ino, fuse_ino_t newparent,
>         struct fuse_entry_param e;
>         char *oldpath;
>         char *newpath;
> +       unsigned int iflags = 0;
>         int err;
>
>         err = get_path2(f, ino, NULL, newparent, newname,
> @@ -3116,11 +3208,11 @@ static void fuse_lib_link(fuse_req_t req, fuse_ino_t ino, fuse_ino_t newparent,
>                 err = fuse_fs_link(f->fs, oldpath, newpath);
>                 if (!err)
>                         err = lookup_path(f, newparent, newname, newpath,
> -                                         &e, NULL);
> +                                         &e, &iflags, NULL);
>                 fuse_finish_interrupt(f, req, &d);
>                 free_path2(f, ino, newparent, NULL, NULL, oldpath, newpath);
>         }
> -       reply_entry(req, &e, err);
> +       reply_entry(req, &e, iflags, err);
>  }
>
>  static void fuse_do_release(struct fuse *f, fuse_ino_t ino, const char *path,
> @@ -3163,6 +3255,7 @@ static void fuse_lib_create(fuse_req_t req, fuse_ino_t parent,
>         struct fuse_intr_data d;
>         struct fuse_entry_param e;
>         char *path;
> +       unsigned int iflags;
>         int err;
>
>         err = get_path_name(f, parent, name, &path);
> @@ -3170,7 +3263,8 @@ static void fuse_lib_create(fuse_req_t req, fuse_ino_t parent,
>                 fuse_prepare_interrupt(f, req, &d);
>                 err = fuse_fs_create(f->fs, path, mode, fi);
>                 if (!err) {
> -                       err = lookup_path(f, parent, name, path, &e, fi);
> +                       err = lookup_path(f, parent, name, path, &e,
> +                                         &iflags, fi);
>                         if (err)
>                                 fuse_fs_release(f->fs, path, fi);
>                         else if (!S_ISREG(e.attr.st_mode)) {
> @@ -3190,10 +3284,18 @@ static void fuse_lib_create(fuse_req_t req, fuse_ino_t parent,
>                 fuse_finish_interrupt(f, req, &d);
>         }
>         if (!err) {
> +               int create_res;
> +
>                 pthread_mutex_lock(&f->lock);
>                 get_node(f, e.ino)->open_count++;
>                 pthread_mutex_unlock(&f->lock);
> -               if (fuse_reply_create(req, &e, fi) == -ENOENT) {
> +
> +               if (f->want_iflags)
> +                       create_res = fuse_reply_create_iflags(req, &e, iflags,
> +                                                             fi);
> +               else
> +                       create_res = fuse_reply_create(req, &e, fi);
> +               if (create_res == -ENOENT) {
>                         /* The open syscall was interrupted, so it
>                            must be cancelled */
>                         fuse_do_release(f, e.ino, path, fi);
> @@ -3227,13 +3329,21 @@ static void open_auto_cache(struct fuse *f, fuse_ino_t ino, const char *path,
>                 if (diff_timespec(&now, &node->stat_updated) >
>                     f->conf.ac_attr_timeout) {
>                         struct stat stbuf;
> +                       unsigned int iflags = 0;
>                         int err;
> +
>                         pthread_mutex_unlock(&f->lock);
> -                       err = fuse_fs_getattr(f->fs, path, &stbuf, fi);
> +                       if (f->want_iflags)
> +                               err = fuse_fs_getattr_iflags(f->fs, path,
> +                                                            &stbuf, &iflags,
> +                                                            fi);
> +                       else
> +                               err = fuse_fs_getattr(f->fs, path, &stbuf, fi);
>                         pthread_mutex_lock(&f->lock);
> -                       if (!err)
> +                       if (!err) {
>                                 update_stat(node, &stbuf);
> -                       else
> +                               node->iflags = iflags;
> +                       } else
>                                 node->cache_valid = 0;
>                 }
>         }
> @@ -3562,6 +3672,7 @@ static int fill_dir_plus(void *dh_, const char *name, const struct stat *statp,
>                 .ino = 0,
>         };
>         struct fuse *f = dh->fuse;
> +       unsigned int iflags = 0;
>         int res;
>
>         if ((flags & ~FUSE_FILL_DIR_PLUS) != 0) {
> @@ -3586,6 +3697,7 @@ static int fill_dir_plus(void *dh_, const char *name, const struct stat *statp,
>
>         if (off) {
>                 size_t newlen;
> +               size_t thislen;
>
>                 if (dh->filled) {
>                         dh->error = -EIO;
> @@ -3601,7 +3713,8 @@ static int fill_dir_plus(void *dh_, const char *name, const struct stat *statp,
>
>                 if (statp && (flags & FUSE_FILL_DIR_PLUS)) {
>                         if (!is_dot_or_dotdot(name)) {
> -                               res = do_lookup(f, dh->nodeid, name, &e);
> +                               res = do_lookup(f, dh->nodeid, name, &e,
> +                                               &iflags);
>                                 if (res) {
>                                         dh->error = res;
>                                         return 1;
> @@ -3609,10 +3722,17 @@ static int fill_dir_plus(void *dh_, const char *name, const struct stat *statp,
>                         }
>                 }
>
> -               newlen = dh->len +
> -                       fuse_add_direntry_plus(dh->req, dh->contents + dh->len,
> -                                              dh->needlen - dh->len, name,
> -                                              &e, off);
> +               if (f->want_iflags)
> +                       thislen = fuse_add_direntry_plus_iflags(dh->req,
> +                                       dh->contents + dh->len,
> +                                       dh->needlen - dh->len, name, iflags,
> +                                       &e, off);
> +               else
> +                       thislen = fuse_add_direntry_plus(dh->req,
> +                                       dh->contents + dh->len,
> +                                       dh->needlen - dh->len, name, &e, off);
> +               newlen = dh->len + thislen;
> +
>                 if (newlen > dh->needlen)
>                         return 1;
>                 dh->len = newlen;
> @@ -3679,6 +3799,7 @@ static int readdir_fill(struct fuse *f, fuse_req_t req, fuse_ino_t ino,
>  static int readdir_fill_from_list(fuse_req_t req, struct fuse_dh *dh,
>                                   off_t off, enum fuse_readdir_flags flags)
>  {
> +       struct fuse *f = req_fuse_prepare(req);
>         off_t pos;
>         struct fuse_direntry *de = dh->first;
>         int res;
> @@ -3699,6 +3820,7 @@ static int readdir_fill_from_list(fuse_req_t req, struct fuse_dh *dh,
>                 unsigned rem = dh->needlen - dh->len;
>                 unsigned thislen;
>                 unsigned newlen;
> +               unsigned int iflags = 0;
>                 pos++;
>
>                 if (flags & FUSE_READDIR_PLUS) {
> @@ -3710,14 +3832,19 @@ static int readdir_fill_from_list(fuse_req_t req, struct fuse_dh *dh,
>                         if (de->flags & FUSE_FILL_DIR_PLUS &&
>                             !is_dot_or_dotdot(de->name)) {
>                                 res = do_lookup(dh->fuse, dh->nodeid,
> -                                               de->name, &e);
> +                                               de->name, &e, &iflags);
>                                 if (res) {
>                                         dh->error = res;
>                                         return 1;
>                                 }
>                         }
>
> -                       thislen = fuse_add_direntry_plus(req, p, rem,
> +                       if (f->want_iflags)
> +                               thislen = fuse_add_direntry_plus_iflags(req, p,
> +                                                        rem, de->name, iflags,
> +                                                        &e, pos);
> +                       else
> +                               thislen = fuse_add_direntry_plus(req, p, rem,
>                                                          de->name, &e, pos);


All those conditional statements look pretty moot.
Can't we just force iflags to 0 if (!f->want_iflags)
and always call the *_iflags functions?

Thanks,
Amir.

  reply	other threads:[~2025-07-18 14:28 UTC|newest]

Thread overview: 174+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-17 23:10 [RFC v3] fuse: use fs-iomap for better performance so we can containerize ext4 Darrick J. Wong
2025-07-17 23:23 ` [PATCHSET RFC v3 1/4] fuse: fixes and cleanups ahead of iomap support Darrick J. Wong
2025-07-17 23:26   ` [PATCH 1/7] fuse: fix livelock in synchronous file put from fuseblk workers Darrick J. Wong
2025-07-17 23:26   ` [PATCH 2/7] fuse: flush pending fuse events before aborting the connection Darrick J. Wong
2025-07-18 16:37     ` Bernd Schubert
2025-07-18 17:50       ` Joanne Koong
2025-07-18 17:57         ` Bernd Schubert
2025-07-18 18:38           ` Darrick J. Wong
2025-07-18 18:07       ` Bernd Schubert
2025-07-18 18:13         ` Bernd Schubert
2025-07-18 19:34         ` Darrick J. Wong
2025-07-18 21:03           ` Bernd Schubert
2025-07-18 22:23     ` Joanne Koong
2025-07-19  0:32       ` Darrick J. Wong
2025-07-21 20:32         ` Joanne Koong
2025-07-23 17:34           ` Darrick J. Wong
2025-07-23 21:02             ` Joanne Koong
2025-07-23 21:11               ` Joanne Koong
2025-07-24 22:28               ` Darrick J. Wong
2025-07-22 12:30         ` Jeff Layton
2025-07-22 12:38           ` Jeff Layton
2025-07-23 15:37             ` Darrick J. Wong
2025-07-23 16:24               ` Jeff Layton
2025-07-31  9:45                 ` Christian Brauner
2025-07-31 17:52                   ` Darrick J. Wong
2025-07-19  7:18       ` Amir Goldstein
2025-07-21 20:05         ` Joanne Koong
2025-07-23 17:06           ` Darrick J. Wong
2025-07-23 20:27             ` Joanne Koong
2025-07-24 22:34               ` Darrick J. Wong
2025-07-17 23:27   ` [PATCH 3/7] fuse: capture the unique id of fuse commands being sent Darrick J. Wong
2025-07-18 17:10     ` Bernd Schubert
2025-07-18 18:13       ` Darrick J. Wong
2025-07-22 22:20         ` Bernd Schubert
2025-07-17 23:27   ` [PATCH 4/7] fuse: implement file attributes mask for statx Darrick J. Wong
2025-08-18 15:11     ` Miklos Szeredi
2025-08-18 20:01       ` Darrick J. Wong
2025-08-18 20:04         ` Darrick J. Wong
2025-08-19 15:01         ` Miklos Szeredi
2025-08-19 22:51           ` Darrick J. Wong
2025-08-20  9:16             ` Miklos Szeredi
2025-08-20  9:40               ` Miklos Szeredi
2025-08-20 15:16                 ` Darrick J. Wong
2025-08-20 15:31                   ` Miklos Szeredi
2025-08-20 15:09               ` Darrick J. Wong
2025-08-20 15:23                 ` Miklos Szeredi
2025-08-20 15:29                   ` Darrick J. Wong
2025-07-17 23:27   ` [PATCH 5/7] iomap: exit early when iomap_iter is called with zero length Darrick J. Wong
2025-07-17 23:27   ` [PATCH 6/7] iomap: trace iomap_zero_iter zeroing activities Darrick J. Wong
2025-07-17 23:28   ` [PATCH 7/7] iomap: error out on file IO when there is no inline_data buffer Darrick J. Wong
2025-07-17 23:24 ` [PATCHSET RFC v3 2/4] fuse: allow servers to use iomap for better file IO performance Darrick J. Wong
2025-07-17 23:28   ` [PATCH 01/13] fuse: implement the basic iomap mechanisms Darrick J. Wong
2025-07-17 23:28   ` [PATCH 02/13] fuse: add an ioctl to add new iomap devices Darrick J. Wong
2025-07-17 23:28   ` [PATCH 03/13] fuse: flush events and send FUSE_SYNCFS and FUSE_DESTROY on unmount Darrick J. Wong
2025-07-17 23:29   ` [PATCH 04/13] fuse: implement basic iomap reporting such as FIEMAP and SEEK_{DATA,HOLE} Darrick J. Wong
2025-07-17 23:29   ` [PATCH 05/13] fuse: implement direct IO with iomap Darrick J. Wong
2025-07-17 23:29   ` [PATCH 06/13] fuse: implement buffered " Darrick J. Wong
2025-07-18 15:10     ` Amir Goldstein
2025-07-18 18:01       ` Darrick J. Wong
2025-07-18 18:39         ` Bernd Schubert
2025-07-18 18:46           ` Darrick J. Wong
2025-07-18 19:45         ` Amir Goldstein
2025-07-18 20:20           ` Darrick J. Wong
2025-07-17 23:29   ` [PATCH 07/13] fuse: enable caching of timestamps Darrick J. Wong
2025-07-17 23:30   ` [PATCH 08/13] fuse: implement large folios for iomap pagecache files Darrick J. Wong
2025-07-17 23:30   ` [PATCH 09/13] fuse: use an unrestricted backing device with iomap pagecache io Darrick J. Wong
2025-07-17 23:30   ` [PATCH 10/13] fuse: advertise support for iomap Darrick J. Wong
2025-07-17 23:31   ` [PATCH 11/13] fuse: query filesystem geometry when using iomap Darrick J. Wong
2025-07-17 23:31   ` [PATCH 12/13] fuse: implement fadvise for iomap files Darrick J. Wong
2025-07-17 23:31   ` [PATCH 13/13] fuse: implement inline data file IO via iomap Darrick J. Wong
2025-07-17 23:24 ` [PATCHSET RFC v3 3/4] fuse: cache iomap mappings for even better file IO performance Darrick J. Wong
2025-07-17 23:31   ` [PATCH 1/4] fuse: cache iomaps Darrick J. Wong
2025-07-17 23:32   ` [PATCH 2/4] fuse: use the iomap cache for iomap_begin Darrick J. Wong
2025-07-17 23:32   ` [PATCH 3/4] fuse: invalidate iomap cache after file updates Darrick J. Wong
2025-07-17 23:32   ` [PATCH 4/4] fuse: enable iomap cache management Darrick J. Wong
2025-07-17 23:24 ` [PATCHSET RFC v3 4/4] fuse: handle timestamps and ACLs correctly when iomap is enabled Darrick J. Wong
2025-07-17 23:32   ` [PATCH 1/7] fuse: force a ctime update after a fileattr_set call when in iomap mode Darrick J. Wong
2025-07-17 23:33   ` [PATCH 2/7] fuse: synchronize inode->i_flags after fileattr_[gs]et Darrick J. Wong
2025-07-17 23:33   ` [PATCH 3/7] fuse: cache atime when in iomap mode Darrick J. Wong
2025-07-17 23:33   ` [PATCH 4/7] fuse: update file mode when updating acls Darrick J. Wong
2025-07-17 23:33   ` [PATCH 5/7] fuse: propagate default and file acls on creation Darrick J. Wong
2025-07-17 23:34   ` [PATCH 6/7] fuse: let the kernel handle KILL_SUID/KILL_SGID for iomap filesystems Darrick J. Wong
2025-07-17 23:34   ` [PATCH 7/7] fuse: update ctime when updating acls on an iomap inode Darrick J. Wong
2025-07-17 23:25 ` [PATCHSET RFC v3 1/3] libfuse: allow servers to use iomap for better file IO performance Darrick J. Wong
2025-07-17 23:34   ` [PATCH 01/14] libfuse: add kernel gates for FUSE_IOMAP and bump libfuse api version Darrick J. Wong
2025-07-17 23:34   ` [PATCH 02/14] libfuse: add fuse commands for iomap_begin and end Darrick J. Wong
2025-07-17 23:35   ` [PATCH 03/14] libfuse: add upper level iomap commands Darrick J. Wong
2025-07-17 23:35   ` [PATCH 04/14] libfuse: add a notification to add a new device to iomap Darrick J. Wong
2025-07-17 23:35   ` [PATCH 05/14] libfuse: add iomap ioend low level handler Darrick J. Wong
2025-07-17 23:35   ` [PATCH 06/14] libfuse: add upper level iomap ioend commands Darrick J. Wong
2025-07-17 23:36   ` [PATCH 07/14] libfuse: add a reply function to send FUSE_ATTR_* to the kernel Darrick J. Wong
2025-07-18 14:10     ` Amir Goldstein
2025-07-18 15:48       ` Darrick J. Wong
2025-07-19  7:34         ` Amir Goldstein
2025-07-17 23:36   ` [PATCH 08/14] libfuse: connect high level fuse library to fuse_reply_attr_iflags Darrick J. Wong
2025-07-18 14:27     ` Amir Goldstein [this message]
2025-07-18 15:55       ` Darrick J. Wong
2025-07-21 18:51         ` Bernd Schubert
2025-07-23 17:50           ` Darrick J. Wong
2025-07-24 19:56             ` Amir Goldstein
2025-07-29  5:35               ` Darrick J. Wong
2025-07-29  7:50                 ` Amir Goldstein
2025-07-29 14:22                   ` Darrick J. Wong
2025-07-17 23:36   ` [PATCH 09/14] libfuse: add FUSE_IOMAP_DIRECTIO Darrick J. Wong
2025-07-17 23:37   ` [PATCH 10/14] libfuse: add FUSE_IOMAP_FILEIO Darrick J. Wong
2025-07-17 23:37   ` [PATCH 11/14] libfuse: allow discovery of the kernel's iomap capabilities Darrick J. Wong
2025-07-17 23:37   ` [PATCH 12/14] libfuse: add lower level iomap_config implementation Darrick J. Wong
2025-07-17 23:37   ` [PATCH 13/14] libfuse: add upper " Darrick J. Wong
2025-07-17 23:38   ` [PATCH 14/14] libfuse: add strictatime/lazytime mount options Darrick J. Wong
2025-07-17 23:25 ` [PATCHSET RFC v3 2/3] libfuse: cache iomap mappings for even better file IO performance Darrick J. Wong
2025-07-17 23:38   ` [PATCH 1/1] libfuse: enable iomap cache management Darrick J. Wong
2025-07-18 16:16     ` Bernd Schubert
2025-07-18 18:22       ` Darrick J. Wong
2025-07-18 18:35         ` Bernd Schubert
2025-07-18 18:40           ` Darrick J. Wong
2025-07-18 18:51             ` Bernd Schubert
2025-07-17 23:25 ` [PATCHSET RFC v3 3/3] libfuse: implement statx and syncfs Darrick J. Wong
2025-07-17 23:38   ` [PATCH 1/4] libfuse: wire up FUSE_SYNCFS to the low level library Darrick J. Wong
2025-07-17 23:38   ` [PATCH 2/4] libfuse: add syncfs support to the upper library Darrick J. Wong
2025-07-17 23:39   ` [PATCH 3/4] libfuse: add statx support to the lower level library Darrick J. Wong
2025-07-18 13:28     ` Amir Goldstein
2025-07-18 15:58       ` Darrick J. Wong
2025-07-18 16:27       ` Darrick J. Wong
2025-07-18 16:54         ` Bernd Schubert
2025-07-18 18:42           ` Darrick J. Wong
2025-07-17 23:39   ` [PATCH 4/4] libfuse: add upper level statx hooks Darrick J. Wong
2025-07-17 23:25 ` [PATCHSET RFC v3 1/3] fuse2fs: use fuse iomap data paths for better file I/O performance Darrick J. Wong
2025-07-17 23:39   ` [PATCH 01/22] fuse2fs: implement bare minimum iomap for file mapping reporting Darrick J. Wong
2025-07-17 23:39   ` [PATCH 02/22] fuse2fs: add iomap= mount option Darrick J. Wong
2025-07-17 23:40   ` [PATCH 03/22] fuse2fs: implement iomap configuration Darrick J. Wong
2025-07-17 23:40   ` [PATCH 04/22] fuse2fs: register block devices for use with iomap Darrick J. Wong
2025-07-17 23:40   ` [PATCH 05/22] fuse2fs: always use directio disk reads with fuse2fs Darrick J. Wong
2025-07-17 23:40   ` [PATCH 06/22] fuse2fs: implement directio file reads Darrick J. Wong
2025-07-17 23:41   ` [PATCH 07/22] fuse2fs: use tagged block IO for zeroing sub-block regions Darrick J. Wong
2025-07-17 23:41   ` [PATCH 08/22] fuse2fs: only flush the cache for the file under directio read Darrick J. Wong
2025-07-17 23:41   ` [PATCH 09/22] fuse2fs: add extent dump function for debugging Darrick J. Wong
2025-07-17 23:41   ` [PATCH 10/22] fuse2fs: implement direct write support Darrick J. Wong
2025-07-17 23:42   ` [PATCH 11/22] fuse2fs: turn on iomap for pagecache IO Darrick J. Wong
2025-07-17 23:42   ` [PATCH 12/22] fuse2fs: improve tracing for fallocate Darrick J. Wong
2025-07-17 23:42   ` [PATCH 13/22] fuse2fs: don't zero bytes in punch hole Darrick J. Wong
2025-07-17 23:43   ` [PATCH 14/22] fuse2fs: don't do file data block IO when iomap is enabled Darrick J. Wong
2025-07-17 23:43   ` [PATCH 15/22] fuse2fs: disable most io channel flush/invalidate in iomap pagecache mode Darrick J. Wong
2025-07-17 23:43   ` [PATCH 16/22] fuse2fs: re-enable the block device pagecache for metadata IO Darrick J. Wong
2025-07-17 23:43   ` [PATCH 17/22] fuse2fs: avoid fuseblk mode if fuse-iomap support is likely Darrick J. Wong
2025-07-17 23:44   ` [PATCH 18/22] fuse2fs: don't allow hardlinks for now Darrick J. Wong
2025-07-17 23:44   ` [PATCH 19/22] fuse2fs: enable file IO to inline data files Darrick J. Wong
2025-07-17 23:44   ` [PATCH 20/22] fuse2fs: set iomap-related inode flags Darrick J. Wong
2025-07-17 23:44   ` [PATCH 21/22] fuse2fs: add strictatime/lazytime mount options Darrick J. Wong
2025-07-17 23:45   ` [PATCH 22/22] fuse2fs: configure block device block size Darrick J. Wong
2025-07-17 23:26 ` [PATCHSET RFC v3 2/3] fuse2fs: use fuse iomap data paths for better file I/O performance Darrick J. Wong
2025-07-17 23:45   ` [PATCH 1/1] fuse2fs: enable caching of iomaps Darrick J. Wong
2025-07-17 23:26 ` [PATCHSET RFC v3 3/3] fuse2fs: handle timestamps and ACLs correctly when iomap is enabled Darrick J. Wong
2025-07-17 23:45   ` [PATCH 01/10] fuse2fs: allow O_APPEND and O_TRUNC opens Darrick J. Wong
2025-07-17 23:45   ` [PATCH 02/10] fuse2fs: skip permission checking on utimens when iomap is enabled Darrick J. Wong
2025-07-17 23:46   ` [PATCH 03/10] fuse2fs: let the kernel tell us about acl/mode updates Darrick J. Wong
2025-07-17 23:46   ` [PATCH 04/10] fuse2fs: better debugging for file mode updates Darrick J. Wong
2025-07-17 23:46   ` [PATCH 05/10] fuse2fs: debug timestamp updates Darrick J. Wong
2025-07-17 23:46   ` [PATCH 06/10] fuse2fs: use coarse timestamps for iomap mode Darrick J. Wong
2025-07-17 23:47   ` [PATCH 07/10] fuse2fs: add tracing for retrieving timestamps Darrick J. Wong
2025-07-17 23:47   ` [PATCH 08/10] fuse2fs: enable syncfs Darrick J. Wong
2025-07-17 23:47   ` [PATCH 09/10] fuse2fs: skip the gdt write in op_destroy if syncfs is working Darrick J. Wong
2025-07-17 23:47   ` [PATCH 10/10] fuse2fs: implement statx Darrick J. Wong
2025-07-18  8:54 ` [RFC v3] fuse: use fs-iomap for better performance so we can containerize ext4 Christian Brauner
2025-07-18 11:55   ` Amir Goldstein
2025-07-18 19:31     ` Darrick J. Wong
2025-07-18 19:56       ` Amir Goldstein
2025-07-18 20:21         ` Darrick J. Wong
2025-07-23 13:05       ` Christian Brauner
2025-07-23 18:04         ` Darrick J. Wong
2025-07-31 10:13           ` Christian Brauner
2025-07-31 17:22             ` Darrick J. Wong
2025-08-04 10:12               ` Christian Brauner
2025-08-12 20:20                 ` Darrick J. Wong
2025-08-15 14:20                   ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxjRjssQr4M0JQShQHkDh_kh7Risj4BhkfTdfQuBVKY8LQ@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=John@groves.net \
    --cc=bernd@bsbernd.com \
    --cc=bschubert@ddn.com \
    --cc=djwong@kernel.org \
    --cc=joannelkoong@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=neal@gompa.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).