From: Amir Goldstein <amir73il@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Richard Guy Briggs <rgb@redhat.com>,
Paul Moore <paul@paul-moore.com>,
Linux-Audit Mailing List <linux-audit@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Eric Paris <eparis@parisplace.org>,
Steve Grubb <sgrubb@redhat.com>
Subject: Re: [PATCH v2 2/3] fanotify: define struct members to hold response decision context
Date: Thu, 5 May 2022 20:34:06 +0300 [thread overview]
Message-ID: <CAOQ4uxjkJ37Nzke4YN_se4ztr-yZgm6SK_LhmBQ-ckWutOwWrQ@mail.gmail.com> (raw)
In-Reply-To: <20220505144456.nw6slyqw4pjizl5p@quack3.lan>
> One open question I have is what should the kernel do with 'info_type' in
> response it does not understand (in the future when there are possibly more
> different info types). It could just skip it because this should be just
> additional info for introspection (the only mandatory part is in
> fanotify_response, however it could surprise userspace that passed info is
> just getting ignored. To solve this we would have to somewhere report
> supported info types (maybe in fanotify fdinfo in proc). I guess we'll
> cross that bridge when we get to it.
>
> Amir, what do you think?
Regardless if and how we provide a way to enumerate supported info types,
I would prefer to reject (EINVAL) unknown info types.
We can provide a command FAN_RESPONSE_TEST to write a test response with
FAN_NOFD and some extra info so the program can test if certain info
types are supported.
Thanks,
Amir.
next prev parent reply other threads:[~2022-05-05 17:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 0:44 [PATCH v2 0/3] fanotify: Allow user space to pass back additional audit info Richard Guy Briggs
2022-04-29 0:44 ` [PATCH v2 1/3] fanotify: Ensure consistent variable type for response Richard Guy Briggs
2022-05-03 0:16 ` Paul Moore
2022-05-03 21:07 ` Richard Guy Briggs
2022-04-29 0:44 ` [PATCH v2 2/3] fanotify: define struct members to hold response decision context Richard Guy Briggs
2022-05-03 0:16 ` Paul Moore
2022-05-04 1:33 ` Richard Guy Briggs
2022-05-05 3:32 ` Paul Moore
2022-05-05 14:44 ` Jan Kara
2022-05-05 17:34 ` Amir Goldstein [this message]
2022-05-06 8:35 ` Jan Kara
2022-05-05 22:43 ` Steve Grubb
2022-05-06 18:46 ` Richard Guy Briggs
2022-05-09 8:54 ` Jan Kara
2022-05-16 20:53 ` Richard Guy Briggs
2022-04-29 0:44 ` [PATCH v2 3/3] fanotify: Allow audit to use the full permission event response Richard Guy Briggs
2022-05-03 0:16 ` Paul Moore
2022-04-29 0:55 ` [PATCH v2 0/3] fanotify: Allow user space to pass back additional audit info Richard Guy Briggs
2022-05-03 0:16 ` Paul Moore
2022-05-03 21:00 ` Richard Guy Briggs
2022-05-03 20:57 ` Steve Grubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxjkJ37Nzke4YN_se4ztr-yZgm6SK_LhmBQ-ckWutOwWrQ@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=eparis@parisplace.org \
--cc=jack@suse.cz \
--cc=linux-audit@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).