From: Amir Goldstein <amir73il@gmail.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>
Subject: Re: Question about loop device DIO/AIO and FLUSH
Date: Sun, 3 Jul 2016 11:26:03 +0300 [thread overview]
Message-ID: <CAOQ4uxjsWJkgr1sJ3_PaZiCswzuwSDPfcHA6z3yWk6EdcO9quQ@mail.gmail.com> (raw)
In-Reply-To: <CACVXFVOFpJqPLjw2z8jKEg_2XD2AEc8_wyQTEv2M9rz2xTqt2g@mail.gmail.com>
On Fri, Jul 1, 2016 at 9:57 AM, Ming Lei <ming.lei@canonical.com> wrote:
> On Fri, Jul 1, 2016 at 4:54 AM, Amir Goldstein <amir73il@gmail.com> wrote:
>> Hi Ming,
>>
>> I was reading through the code of loop DIO/AIO
>> and I was wondering whether lo_req_flush() really
>> honors REQ_FLUSH by calling vfs_fsync() on a backing file
>> that is open with O_DIRECT?
>
> From view of device, REQ_FLUSH just flushs the cache inside
> drive to medium.
>
>>
>> Shouldn't lo_req_flush() actually wait for completion of
>> all the in-flight loop AIO requests to complete?
>
> I think it isn't needed, just like the flush handling in blk-flush.c, and
> it just works for completed I/O.
Thanks Ming and Christoph.
I see what I was missing.
>
>> Am I missing something?
>>
>> Thanks,
>> Amir.
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-block" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-07-03 8:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 20:54 Question about loop device DIO/AIO and FLUSH Amir Goldstein
2016-07-01 4:25 ` Christoph Hellwig
2016-07-01 5:00 ` Damien Le Moal
2016-07-01 5:04 ` Christoph Hellwig
2016-07-01 5:17 ` Damien Le Moal
2016-07-01 5:32 ` Christoph Hellwig
2016-07-01 5:35 ` Damien Le Moal
2016-07-01 6:57 ` Ming Lei
2016-07-03 8:26 ` Amir Goldstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxjsWJkgr1sJ3_PaZiCswzuwSDPfcHA6z3yWk6EdcO9quQ@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).