linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Marshall <hubcap@omnibond.com>
To: Ritesh Harjani <riteshh@linux.ibm.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Mike Marshall <hubcap@omnibond.com>
Subject: Re: [RESEND PATCH 0/1] Use inode_lock/unlock class of provided APIs in filesystems
Date: Thu, 2 Jan 2020 16:01:14 -0500	[thread overview]
Message-ID: <CAOg9mSR17qRJ4VM5=1jndRwHw2Gcz8txgU9+-9GPFOfR34q7OA@mail.gmail.com> (raw)
In-Reply-To: <20200101105248.25304-1-riteshh@linux.ibm.com>

Ritesh -

I just loaded your patch on top of 5.5-rc4 and it looks fine to me
and xfstests :-) ... I pointed ftrace at the orangefs function you
modified while xfstests was running, and it got called about a
jillion times...

-Mike

On Wed, Jan 1, 2020 at 5:53 AM Ritesh Harjani <riteshh@linux.ibm.com> wrote:
>
> Al, any comments?
> Resending this after adding Reviewed-by/Acked-by tags.
>
>
> From previous version:-
> Matthew Wilcox in [1] suggested that it will be a good idea
> to define some missing API instead of directly using i_rwsem in
> filesystems drivers for lock/unlock/downgrade purposes.
>
> This patch does that work. No functionality change in this patch.
>
> After this there are only lockdep class of APIs at certain places
> in filesystems which are directly using i_rwsem and second is XFS,
> but it seems to be anyway defining it's own xfs_ilock/iunlock set
> of APIs and 'iolock' naming convention for this lock.
>
> [1]: https://www.spinics.net/lists/linux-ext4/msg68689.html
>
> Ritesh Harjani (1):
>   fs: Use inode_lock/unlock class of provided APIs in filesystems
>
>  fs/btrfs/delayed-inode.c |  2 +-
>  fs/btrfs/ioctl.c         |  4 ++--
>  fs/ceph/io.c             | 24 ++++++++++++------------
>  fs/nfs/io.c              | 24 ++++++++++++------------
>  fs/orangefs/file.c       |  4 ++--
>  fs/overlayfs/readdir.c   |  2 +-
>  fs/readdir.c             |  4 ++--
>  include/linux/fs.h       | 21 +++++++++++++++++++++
>  8 files changed, 53 insertions(+), 32 deletions(-)
>
> --
> 2.21.0
>

  parent reply	other threads:[~2020-01-02 21:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-01 10:52 [RESEND PATCH 0/1] Use inode_lock/unlock class of provided APIs in filesystems Ritesh Harjani
2020-01-01 10:52 ` [RESEND PATCH 1/1] fs: " Ritesh Harjani
2020-01-02 21:01 ` Mike Marshall [this message]
2020-01-08  8:38   ` [RESEND PATCH 0/1] " Ritesh Harjani
2020-01-08 13:01     ` Mike Marshall
2020-05-01  4:37 ` Al Viro
2020-05-01  6:37   ` Ritesh Harjani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOg9mSR17qRJ4VM5=1jndRwHw2Gcz8txgU9+-9GPFOfR34q7OA@mail.gmail.com' \
    --to=hubcap@omnibond.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=riteshh@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).