linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Marshall <hubcap@omnibond.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Boaz Harrosh <ooo@electrozaur.com>,
	Greg Kroah-Hartman <greg@kroah.com>
Subject: Re: [GIT PULL] Orangefs (text only resend)
Date: Wed, 9 Sep 2015 11:05:31 -0400	[thread overview]
Message-ID: <CAOg9mSTSSjQribxxnxDMtMuM6WW22+cMuWJ9AY=VfK_p5KDCmQ@mail.gmail.com> (raw)
In-Reply-To: <CAOg9mSTuhA4OWyqrFGn4-mKrBLrvw70Dn-y-W9PgJH9vDOY3Fg@mail.gmail.com>

Christoph's right about the writeback.

I'm pretty sure I added the lockdep stuff back to my .config
correctly:

[    0.000000] Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo
 Molnar
[    0.000000] ... MAX_LOCKDEP_SUBCLASSES:  8
[    0.000000] ... MAX_LOCK_DEPTH:          48
[    0.000000] ... MAX_LOCKDEP_KEYS:        8191
[    0.000000] ... CLASSHASH_SIZE:          4096
[    0.000000] ... MAX_LOCKDEP_ENTRIES:     32768
[    0.000000] ... MAX_LOCKDEP_CHAINS:      65536
[    0.000000] ... CHAINHASH_SIZE:          32768
[    0.000000]  memory used by lock dependency info: 8159 kB
[    0.000000]  per task-struct memory footprint: 1920 bytes


After that I ran the dbench setup that our tester guy uses, and then
before I left for home I fired off xfstests (Christoph made a xfstest patch
for us that at least allows us to run some of it in a meaningful way)...

No lockdep backtraces in my syslog this morning...

I'll keep looking, and also return to fixing the iov_iter code
that Linus pointed out... I hope he looks back in here in the
next few day, I guess the merge window ends at the end of
this week? Whatever else happens, Al Viro gave me plenty
to do <g>...

-Mike

On Tue, Sep 8, 2015 at 2:21 PM, Mike Marshall <hubcap@omnibond.com> wrote:
> Thanks for all the lockdep feedback everyone...
>
> I used to have some cool things turned on in my .config when
> Christoph was working with us...
>
> CONFIG_DEBUG_SPINLOCK=y
> CONFIG_DEBUG_MUTEXES=y
> CONFIG_DEBUG_LOCK_ALLOC=y
> CONFIG_PROVE_LOCKING=y
>
> ... and there used to be at thing like this:
> CONFIG_LOCKDEP
>
> ... I guess it is this now?
> CONFIG_LOCKDEP_SUPPORT
>
> Anyhow... I (blush) didn't turn these things on in my VMs when I
> got a new desktop recently, I've got them turned back on now...
>
> -Mike
>
> On Tue, Sep 8, 2015 at 10:48 AM, Christoph Hellwig <hch@lst.de> wrote:
>> On Tue, Sep 08, 2015 at 12:22:06AM +0100, Al Viro wrote:
>>> You don't want e.g. to have allocation request triggering an attempt to write
>>> a dirty page on a shared mapping of a file from your fs while you are holding
>>> a mutex that would block that attempt *and* waiting for a allocation to
>>> succeed.
>>
>> Unless something changed very recently there is no writeback in orangefs.
>> It's all non-cached I/O straight on to the server, with readpage only
>> there for read-only mmaps (for executable I suspect).

  reply	other threads:[~2015-09-09 15:05 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 15:42 [GIT PULL] Orangefs (text only resend) Mike Marshall
2015-09-02 23:34 ` Linus Torvalds
2015-09-03  1:13   ` Mike Marshall
2015-09-03  1:28     ` Linus Torvalds
2015-09-03 20:22       ` Linus Torvalds
2015-09-03 22:18         ` Mike Marshall
2015-09-03 22:44         ` Greg Kroah-Hartman
2015-09-06  6:35   ` Christoph Hellwig
2015-09-06  9:08     ` Al Viro
2015-09-06 14:52       ` Mike Marshall
2015-09-06 15:00         ` Mike Marshall
2015-09-06 20:20         ` Al Viro
2015-09-07  6:37           ` Al Viro
2015-09-07 21:10             ` Mike Marshall
2015-09-07 23:22               ` Al Viro
2015-09-08  0:47                 ` Theodore Ts'o
2015-09-08  2:49                   ` Dave Chinner
2015-09-08 14:48                 ` Christoph Hellwig
2015-09-08 18:21                   ` Mike Marshall
2015-09-09 15:05                     ` Mike Marshall [this message]
2015-09-11 21:12                       ` Mike Marshall
2015-09-11 22:24                         ` Al Viro
2015-09-13 11:56                           ` Mike Marshall
2015-09-11 23:20                         ` Linus Torvalds
2015-09-13 11:59                           ` Mike Marshall
2015-09-06 14:35     ` Mike Marshall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOg9mSTSSjQribxxnxDMtMuM6WW22+cMuWJ9AY=VfK_p5KDCmQ@mail.gmail.com' \
    --to=hubcap@omnibond.com \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=ooo@electrozaur.com \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).