From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 10/15] libnvdimm: fix up max_hw_sectors
Date: Sun, 21 Jun 2015 06:28:43 -0700
Message-ID: <CAPcyv4gtFeFt-Mpa=s9bs+W+4LpHP4cTCFu6To5FG0Z1_uOEkA@mail.gmail.com>
References: <20150617235209.12943.24419.stgit@dwillia2-desk3.amr.corp.intel.com>
	<20150617235541.12943.86562.stgit@dwillia2-desk3.amr.corp.intel.com>
	<20150621100801.GC5915@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: Jens Axboe <axboe@kernel.dk>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	Boaz Harrosh <boaz@plexistor.com>,
	"Kani, Toshimitsu" <toshi.kani@hp.com>,
	Vishal Verma <vishal.l.verma@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-wi0-f180.google.com ([209.85.212.180]:37133 "EHLO
	mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752498AbbFUN2p (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sun, 21 Jun 2015 09:28:45 -0400
Received: by wicgi11 with SMTP id gi11so53421828wic.0
        for <linux-fsdevel@vger.kernel.org>; Sun, 21 Jun 2015 06:28:44 -0700 (PDT)
In-Reply-To: <20150621100801.GC5915@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sun, Jun 21, 2015 at 3:08 AM, Christoph Hellwig <hch@lst.de> wrote:
>> +void nd_blk_queue_init(struct request_queue *q)
>> +{
>> +     blk_queue_max_hw_sectors(q, UINT_MAX);
>> +     blk_queue_bounce_limit(q, BLK_BOUNCE_ANY);
>> +}
>
> Please just add the calls to the drivers instead of this helper which
> hides the intent.

I thought it made it clearer what properties are shared between block
devices on an nvdimm bus, but if you're initial reaction is that it
hides intent I'll kill the helper.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in