From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F260C282DA for ; Wed, 17 Apr 2019 23:32:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 461552183F for ; Wed, 17 Apr 2019 23:32:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="cdeV5Co7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387628AbfDQXcc (ORCPT ); Wed, 17 Apr 2019 19:32:32 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:35775 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729331AbfDQXcc (ORCPT ); Wed, 17 Apr 2019 19:32:32 -0400 Received: by mail-oi1-f193.google.com with SMTP id j132so187608oib.2 for ; Wed, 17 Apr 2019 16:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WUa9a+RBmWkNHf5y3SQh7mLUba+umXWQDwj4aTSk0ls=; b=cdeV5Co7FAIJCJ2uthEYHgkj7jQNxGzx7ep9TxpYX5XjNACqdOXejoY266/1dBGT5M HnOS3LX5PyUx96RYsO78EGPeUYXbdW74e5bDa8sZ5vVxuHLUqmrt7d1lOuoWCBHWGzy8 xuY1jwqv3CaVJICAqpnL8lY6WUDfMYs2rB06UznxAPbAxe/HLtMac3hWxZ5Lnpu+DD2P FfSD0YdX/bwEj7E0mFYdVg825B6LZR777NjVV7BkfTHFkmP0P5WxTahHPOMEXjKUg6Ni BwMDTzHGtAb9IyFMr4Qaq9rMED9Qtj8WcU2oFxPFFxXV9Yd6HzUyKqvSRbYw9OGlGYjD zNcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WUa9a+RBmWkNHf5y3SQh7mLUba+umXWQDwj4aTSk0ls=; b=nvnfpbSwbkM9oC/nd6hFDWBGvInJ4ecNlW/KO0Sj4VrNIQs4jdUkbZ6vqx6RNSyfyf xoJfDsbj1M1XSJxSdisaNEPj2JjOkHTfX2iuQ9Y2gLkjWxkcr2oi3vwXacevED+Yn5jK QpvqQApse+nEJTnf10PZT/yvzyOTnprMqQ4oJwqQxPpXFFBceYbLsLAps8G7fnl8Vjsi TAgAwvV2TgQxYF+1p/sZlDRXWGMCjzcLzF5Y1x0dKGTsftHgincNVGf9wa3Bz1kZ8Lqi 7lBavQgrfmC9qbP6IT67Joa11IOwS2R8P2zHQeZVtbEFXucOdnMaH9rS5z2cK8YXnRVs iCqw== X-Gm-Message-State: APjAAAXqBZ8m5X6UdMyDWMINidjfNfdxxHPFDssMTcnd6/jPrX0979bY zh/iF8Xhp107Q6JmpD1di2eT1C836zGCr03xGgUJtQ== X-Google-Smtp-Source: APXvYqxbYEcI7nDGR81hG8KpBIqWV+qkrRq7k1+Hbw9zZA5mDoWe6Sbms3neiEWQu/uX94yQ5kYig9QFQfhwENdENQ8= X-Received: by 2002:aca:ed88:: with SMTP id l130mr99825oih.70.1555543951170; Wed, 17 Apr 2019 16:32:31 -0700 (PDT) MIME-Version: 1.0 References: <20190411210834.4105-1-jglisse@redhat.com> <2c124cc4-b97e-ee28-2926-305bc6bc74bd@plexistor.com> <20190416185922.GA12818@kmo-pixel> <20190416194936.GD21526@redhat.com> <20190417222858.GA4146@redhat.com> In-Reply-To: <20190417222858.GA4146@redhat.com> From: Dan Williams Date: Wed, 17 Apr 2019 16:32:19 -0700 Message-ID: Subject: Re: [PATCH v1 00/15] Keep track of GUPed pages in fs and block To: Jerome Glisse Cc: Kent Overstreet , Boaz Harrosh , Linux Kernel Mailing List , linux-fsdevel , linux-block@vger.kernel.org, Linux MM , John Hubbard , Jan Kara , Alexander Viro , Johannes Thumshirn , Christoph Hellwig , Jens Axboe , Ming Lei , Jason Gunthorpe , Matthew Wilcox , Steve French , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, Yan Zheng , Sage Weil , Ilya Dryomov , Alex Elder , ceph-devel@vger.kernel.org, Eric Van Hensbergen , Latchesar Ionkov , Mike Marshall , Martin Brandenburg , devel@lists.orangefs.org, Dominique Martinet , v9fs-developer@lists.sourceforge.net, Coly Li , linux-bcache@vger.kernel.org, =?UTF-8?Q?Ernesto_A=2E_Fern=C3=A1ndez?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Apr 17, 2019 at 3:29 PM Jerome Glisse wrote: > > On Wed, Apr 17, 2019 at 02:53:28PM -0700, Dan Williams wrote: > > On Tue, Apr 16, 2019 at 12:50 PM Jerome Glisse wro= te: > > > > > > On Tue, Apr 16, 2019 at 12:12:27PM -0700, Dan Williams wrote: > > > > On Tue, Apr 16, 2019 at 11:59 AM Kent Overstreet > > > > wrote: > > > > > > > > > > On Tue, Apr 16, 2019 at 09:35:04PM +0300, Boaz Harrosh wrote: > > > > > > On Thu, Apr 11, 2019 at 05:08:19PM -0400, jglisse@redhat.com wr= ote: > > > > > > > From: J=C3=A9r=C3=B4me Glisse > > > > > > > > > > > > > > This patchset depends on various small fixes [1] and also on = patchset > > > > > > > which introduce put_user_page*() [2] and thus is 5.3 material= as those > > > > > > > pre-requisite will get in 5.2 at best. Nonetheless i am posti= ng it now > > > > > > > so that it can get review and comments on how and what should= be done > > > > > > > to test things. > > > > > > > > > > > > > > For various reasons [2] [3] we want to track page reference t= hrough GUP > > > > > > > differently than "regular" page reference. Thus we need to ke= ep track > > > > > > > of how we got a page within the block and fs layer. To do so = this patch- > > > > > > > set change the bio_bvec struct to store a pfn and flags inste= ad of a > > > > > > > direct pointer to a page. This way we can flag page that are = coming from > > > > > > > GUP. > > > > > > > > > > > > > > This patchset is divided as follow: > > > > > > > - First part of the patchset is just small cleanup i beli= eve they > > > > > > > can go in as his assuming people are ok with them. > > > > > > > > > > > > > > > > > > > - Second part convert bio_vec->bv_page to bio_vec->bv_pfn= this is > > > > > > > done in multi-step, first we replace all direct derefer= ence of > > > > > > > the field by call to inline helper, then we introduce m= acro for > > > > > > > bio_bvec that are initialized on the stack. Finaly we c= hange the > > > > > > > bv_page field to bv_pfn. > > > > > > > > > > > > Why do we need a bv_pfn. Why not just use the lowest bit of the= page-ptr > > > > > > as a flag (pointer always aligned to 64 bytes in our case). > > > > > > > > > > > > So yes we need an inline helper for reference of the page but i= s it not clearer > > > > > > that we assume a page* and not any kind of pfn ? > > > > > > It will not be the first place using low bits of a pointer for = flags. > > > > > > > > > > > > That said. Why we need it at all? I mean why not have it as a b= io flag. If it exist > > > > > > at all that a user has a GUP and none-GUP pages to IO at the sa= me request he/she > > > > > > can just submit them as two separate BIOs (chained at the block= layer). > > > > > > > > > > > > Many users just submit one page bios and let elevator merge the= m any way. > > > > > > > > > > Let's please not add additional flags and weirdness to struct bio= - "if this > > > > > flag is set interpret one way, if not interpret another" - or eve= ntually bios > > > > > will be as bad as skbuffs. I would much prefer just changing bv_p= age to bv_pfn. > > > > > > > > This all reminds of the failed attempt to teach the block layer to > > > > operate without pages: > > > > > > > > https://lore.kernel.org/lkml/20150316201640.33102.33761.stgit@dwill= ia2-desk3.amr.corp.intel.com/ > > > > > > > > > > > > > > Question though - why do we need a flag for whether a page is a G= UP page or not? > > > > > Couldn't the needed information just be determined by what range = the pfn is not > > > > > (i.e. whether or not it has a struct page associated with it)? > > > > > > > > That amounts to a pfn_valid() check which is a bit heavier than if = we > > > > can store a flag in the bv_pfn entry directly. > > > > > > > > I'd say create a new PFN_* flag, and make bv_pfn a 'pfn_t' rather t= han > > > > an 'unsigned long'. > > > > > > > > That said, I'm still in favor of Jan's proposal to just make the > > > > bv_page semantics uniform. Otherwise we're complicating this core > > > > infrastructure for some yet to be implemented GPU memory management > > > > capabilities with yet to be determined value. Circle back when that > > > > value is clear, but in the meantime fix the GUP bug. > > > > > > This has nothing to do with GPU, what make you think so ? Here i am > > > trying to solve GUP and to keep the value of knowing wether a page > > > has been GUP or not. I argue that if we bias every page in every bio > > > then we loose that information and thus the value. > > > > > > I gave the page protection mechanisms as an example that would be > > > impacted but it is not the only one. Knowing if a page has been GUP > > > can be useful for memory reclaimation, compaction, NUMA balancing, > > > > Right, this is what I was reacting to in your pushback to Jan's > > proposal. You're claiming value for not doing the simple thing for > > some future "may be useful in these contexts". To my knowledge those > > things are not broken today. You're asking for the complexity to be > > carried today for some future benefit, and I'm asking for the > > simplicity to be maintained as much as possible today and let the > > value of future changes stand on their own to push for more complexity > > later. > > > > Effectively don't use this bug fix to push complexity for a future > > agenda where the value has yet to be quantified. > > Except that this solution (biasing everyone in bio) would _more complex_ > it is only conceptualy appealing. The changes are on the other hand much > deeper and much riskier but you decided to ignore that and focus on some- > thing i was just giving as an example. Not ignoring, asking for more clarification on the complexity it introduces independent of potential future uses.