From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E0B1C004C9 for ; Tue, 7 May 2019 15:40:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FDD320825 for ; Tue, 7 May 2019 15:40:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="P0NmBCU8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726852AbfEGPks (ORCPT ); Tue, 7 May 2019 11:40:48 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:45561 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726523AbfEGPkl (ORCPT ); Tue, 7 May 2019 11:40:41 -0400 Received: by mail-ot1-f67.google.com with SMTP id a10so15336589otl.12 for ; Tue, 07 May 2019 08:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eDjq30ddseBaIw6socWxfPv6NTtk+5QW4X1Ug5iEyJk=; b=P0NmBCU8zUOfaF8xaYZsuZ8crvxFB33fl7wDNB9MZv5fgE9bufZ9uXOFacVBRIyhyk 7jy7cEut0ZZu1RaoDtrr50BVaB/CX/skGeBOtXxoGAGKW89ZemgDpFwl6g0BCyZNTY71 c96Bv/+lzcoe4YYcd5EMePUR4gTK7GrAqK6itLr2obeqWzYKb3Dql3mDDHzIv1x+/JnT zIvYGvdBDonXfV8sEZV0PvMIvA63l1OoRV+8kWQPCfuhVRSXMOb+jYMxWFhFzCGAXSHH RES21PeWYeTfPIbRNgVP3JVS3PVW0F6JNq0X1vpUrTbfXgSQ4Ev5ZlVumch1kGRMghci mHRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eDjq30ddseBaIw6socWxfPv6NTtk+5QW4X1Ug5iEyJk=; b=Idpdcjgpyl6iglF4tdp+TvkKt5mW19X+rFZizfNs7x9Au5thNuIBobtRX8ShgtqeOU FRQRU+tjOV+Et8GmRUN7JEvKAHIxUyx7eD88Q/ew7vCbrGKwVu2b2BgqTdiz8RH9aup0 3U3ZqOMf8QeZYA1PXlin8O2edGm6OAcZ73S7Fc4ZxteZKWy50WADRt7Plxr4X7B38Vx0 JahXuaTcaKgzP9aF/Z+pL2oVpSyP7B+MbWzvTh1npIhN0bONsMRKj6DsXDOTMEJzA29o NkvstzZF9AYY6iFrNB351AHFBl4L+UYCTMV6TMqaH8laUs5iS5Hq78sGsdgNCGvwOAMa F4dw== X-Gm-Message-State: APjAAAUn9E/3tvpamcq9wBIFJM4756c4EyHIOpb8rw1KnjDgCVYA+gcW DdgqbA+zy5AZsU4F1bROYuJQH9f36zhqReW4uQ5vkg== X-Google-Smtp-Source: APXvYqxgIWANkc/KHq9kAogc8tqlkqRrOccsWEIKbqAeeZcNH5LiQg3MPoGwMh9hdCCYG0LuKCXgqpIi0akzNLzuZFI= X-Received: by 2002:a9d:222c:: with SMTP id o41mr22033787ota.353.1557243640877; Tue, 07 May 2019 08:40:40 -0700 (PDT) MIME-Version: 1.0 References: <20190426050039.17460-1-pagupta@redhat.com> <20190426050039.17460-4-pagupta@redhat.com> In-Reply-To: <20190426050039.17460-4-pagupta@redhat.com> From: Dan Williams Date: Tue, 7 May 2019 08:40:30 -0700 Message-ID: Subject: Re: [PATCH v7 3/6] libnvdimm: add dax_dev sync flag To: Pankaj Gupta Cc: linux-nvdimm , Linux Kernel Mailing List , virtualization@lists.linux-foundation.org, KVM list , linux-fsdevel , Linux ACPI , Qemu Developers , linux-ext4 , linux-xfs , Ross Zwisler , Vishal L Verma , Dave Jiang , "Michael S. Tsirkin" , Jason Wang , Matthew Wilcox , "Rafael J. Wysocki" , Christoph Hellwig , Len Brown , Jan Kara , "Theodore Ts'o" , Andreas Dilger , "Darrick J. Wong" , lcapitulino@redhat.com, Kevin Wolf , Igor Mammedov , jmoyer , Nitesh Narayan Lal , Rik van Riel , Stefan Hajnoczi , Andrea Arcangeli , David Hildenbrand , david , cohuck@redhat.com, Xiao Guangrong , Paolo Bonzini , kilobyte@angband.pl, yuval shaia Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Apr 25, 2019 at 10:02 PM Pankaj Gupta wrote: > > This patch adds 'DAXDEV_SYNC' flag which is set > for nd_region doing synchronous flush. This later > is used to disable MAP_SYNC functionality for > ext4 & xfs filesystem for devices don't support > synchronous flush. > > Signed-off-by: Pankaj Gupta [..] > diff --git a/include/linux/dax.h b/include/linux/dax.h > index 0dd316a74a29..c97fc0cc7167 100644 > --- a/include/linux/dax.h > +++ b/include/linux/dax.h > @@ -7,6 +7,9 @@ > #include > #include > > +/* Flag for synchronous flush */ > +#define DAXDEV_F_SYNC true I'd feel better, i.e. it reads more canonically, if this was defined as (1UL << 0) and the argument to alloc_dax() was changed to 'unsigned long flags' rather than a bool.