From: "Dilger, Andreas" <andreas.dilger@intel.com>
To: "greg@kroah.com" <greg@kroah.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"Drokin, Oleg" <oleg.drokin@intel.com>,
Peng Tao <bergwolf@gmail.com>, Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: RFC: [PATCH] staging/lustre/llite: fix O_TMPFILE/O_LOV_DELAY_CREATE conflict
Date: Tue, 11 Feb 2014 00:37:09 +0000 [thread overview]
Message-ID: <CF1EBD89.913E6%andreas.dilger@intel.com> (raw)
In-Reply-To: <20140210212929.GF18016@ZenIV.linux.org.uk>
On 2014/02/10, 2:29 PM, "Al Viro" <viro@ZenIV.linux.org.uk> wrote:
>On Mon, Feb 10, 2014 at 08:16:52PM +0000, Dilger, Andreas wrote:
>> >>Instead of trying to find a non-conflicting O_LOV_DELAY_CREATE flag
>> >>or define a Lustre-specific flag that isn't of use to most/any other
>> >>filesystems, use (O_NOCTTY|FASYNC) as the new value. These flag
>> >>are not meaningful for newly-created regular files and should be
>> >>OK since O_LOV_DELAY_CREATE is only meaningful for new files.
>
>*shrug*
>
>I can live with that; it's a kludge, but it's less broken than that
>explicit constant - that one is a non-starter, since O_... flag
>values are arch-dependent.
Greg,
could you please merge the original patch. We'd like to get this into
our pending release of the Lustre user tools and into the releases for
older kernels (which will support both the old and new flags until the
support for older kernels is removed).
Cheers, Andreas
--
Andreas Dilger
Lustre Software Architect
Intel High Performance Data Division
next prev parent reply other threads:[~2014-02-11 0:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 20:16 RFC: [PATCH] staging/lustre/llite: fix O_TMPFILE/O_LOV_DELAY_CREATE conflict Dilger, Andreas
2014-02-10 21:29 ` Al Viro
2014-02-10 22:10 ` Al Viro
2014-02-10 22:51 ` Al Viro
2014-02-11 0:31 ` Dilger, Andreas
2014-02-11 2:40 ` Al Viro
2014-02-11 2:54 ` Drokin, Oleg
2014-02-11 6:55 ` Xiong, Jinshan
2014-02-11 14:25 ` Al Viro
2014-02-11 18:26 ` Xiong, Jinshan
2014-02-11 0:18 ` Xiong, Jinshan
2014-02-11 0:37 ` Dilger, Andreas [this message]
2014-02-11 0:51 ` greg
2014-02-11 9:13 ` Christoph Hellwig
2014-02-11 11:01 ` Dilger, Andreas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CF1EBD89.913E6%andreas.dilger@intel.com \
--to=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).