From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794862438; b=Kufq2tzFuHps/wq19iOjjUrFHXxCoAfoE8fAQVSZnU5DRaZSBnZrl1saD3P8KTfpcHxE 8FbdwF23QJcl6uayZOxRXlfz9hHLkD4dvWZo8+5cLhSAALj9bmCXj6uUD1l4kAjZrGORN RnW34NMTXzoM6cStzXHZq9Rqx6Yh5bygyI89A/ZYaMZyT75xjKSb/dZboVOlFyPkc298c rrGSQvDsznLmv6qM4vonq9J++pwZkrDEYuLHFIPwBx8AA2XbRGNoZF5UfJ4xUV52DuYk8 qcTtRtwXDEg+we0AhEoap8+vlcHWgHsTq49YDnZUVAc/OWkhkSwcy+52EVYnPp6UVwA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794862438; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To:X-Mailer: References:In-Reply-To; bh=tzdH03fxvdHG/WP+ISnD29s1t0jRH5uKJ+YnULP8Tr0=; b=BD8ILwZjDA8diV/6O/M1tmo7bg9wI9HwJ5Jq4EnsN+qoIV95Te8QuC59dKSrR/rnsulm RQyYIz2xBK6KgKz0k/k6VxEJKC4bYB8g0Mb4JtB8TmBJCWk6ksge4WjS6sqNCxbQvVFyS iW6Ape+zRappfYhlMU2/CKWeiUYVTeKcTwtUT55wFy96WzSlLwICXK+xdR7rV0lXrHZwR KFJ8L7SfeSeNWM6QmdpRct+lVs34k3Ax7GaMYFOtNQKQ7+bX+73K70lAUey0XUQiQpToZ uMSjBlEF5CjSH4OMrV8BPIMxBEDhiOjUVez0e7q+W821hvqXjQ9H4GQty11/GAyPJQQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=L5sm9T50; arc=none smtp.remote-ip=209.85.128.41 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2992606A329 for ; Mon, 16 Nov 2026 20:53:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D2992606A329 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=L5sm9T50 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4bb72b44a97so9679125e9.0 for ; Mon, 16 Nov 2026 12:53:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794862436; x=1795467236; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:mime-version:from:to:cc:subject:date:message-id :reply-to:content-type; bh=tzdH03fxvdHG/WP+ISnD29s1t0jRH5uKJ+YnULP8Tr0=; b=L5sm9T50a7sqt8w6n5QqMCx2guZ/ceCCaSawY3J0jxqzahZ/LN4bt26KoGHp/uxFmk WolNlyKBnyZ1ec/7ZBJ64TpLAMa5GpOCqE5CcwXsF6xR2eT/T77xWEVoGtvYUuScpPgN oz4iIqpqxQDYdqVGkZ6S56sYlTHUsvde9FjQULBdQwu+w/8a71UaoF3qQ3EF1S6gzVuf dgE0P/WOfZoYnPuKsQQ5Jt//NJN4mC5iRbQCozXEE4yB0v0DbLjq7YCnC1TvPdkKeY89 THDwEB3iExsY9Ok3aiSiUawJk00aXtPKjGcx+g+wp9cCLgujF5NkMGxtzDgjbUuRcBOa A6iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794862436; x=1795467236; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=tzdH03fxvdHG/WP+ISnD29s1t0jRH5uKJ+YnULP8Tr0=; b=wpO2K1iV/p/wkaEl3QZXwHqbx3+32uXKaoRX/PdfjO0Vhsm6s3ss38ppNQBaIcSubI FWjvzbNWsxGYo4nLp6NvMcytnfH+wJpZrFWaNiaeNYEB9RpSSriHaoDxjgwS76N1V1XM 9kBKUI9T/to1fwS3PLc4A+sNWYx1Czhh4A8CkrezvkH9G6sGOy2yN+nwxwuYXlcCN6tF aflr4m64uqgGOy3HSyfiVo+Yajs72mWW3RpfGWBld0PbL32/0c6znTcvAQCfk+bMb3dw F5PbYQJMeFrCuzEFMAJPegc4m9/DHulTH1pBIoBeluHZEtHYHEdVGcQSQSU7iGTGsSq1 5kGA== X-Forwarded-Encrypted: i=1; AL+hErH4YQBeVV5QD/hpagVTT5kVEnzw/ZF7T8b8sI64zvbXdKOuSHOSA0/O3wkoos9ogw22xOcgDGj88k+qzLpr@vger.kernel.org X-Gm-Message-State: APuU4Z8mZLyDBkV0eCTRKzyOgGTjrnVrAFobB7H9MMiG75TmjSuqdeiV 5NJ78LyvVn1+xoV2ff1omEZUm3UKT2X1Di7Rw4/p1xSg/aEaUDNmu04I X-Gm-Gg: AYBFou1gety2VIHdsQUcuX52RXv7+4+nDevhtrmlaeZaqHtrvJQL2OMtfHHb6clfEz9 QGYGofqzG7tKeO9cg3K8kTnjY1V0IntOJMqMMT431t9iBdM5S39szXYzlomYPQUYjEQRG3lP81+ iNltLZdvQNlQ/Ce7oe26wc1QCPsUac86Cs7dvOlHXB8NFJNEtgquSAzD6bh83tbDObsn4z8z1n3 tbglc6Wadm2MH/qZ4ZyDBw8aw2Cjqwte8UDsHjailaNHNKWPIcxyLLQs4ygTCDRjKPQSaakY0ll JmnsgKnDIuNdcMRK2ixxnMyCw1re88pj4aC7Veh8JeV8mf/WmZi/kBVlt7aHB9IoxQyoserMT55 cLk5mn0F4akI2SCDSaag6D4ddrjwD5G7AFVVjlIu5CWfS04shPpFZnd4qv0B/2iqwPtYl42xrFF JEYdlLZSGz7vzzaegbJcANkFwihGU9OPobFtYp71TaDp1nchV2mJurJNEANSr/RuezziDfFjMZ/ BnXY+IhiprCg4jdxrZuMO7NDnc7zwcGpLNvDkjYUDjx3pA5+zwsYejJdGrf1FHcX1FHhyoUxxi4 Sa5wGGgCqo3kGLlrYdLT7qgHDw== X-Received: by 2002:a05:600c:3b2a:b0:4a8:9a2f:d27 with SMTP id 5b1f17b1804b1-4bb55aabdf9mr263187925e9.25.1794862436065; Mon, 16 Nov 2026 12:53:56 -0800 (PST) Received: from localhost ([2001:b07:5d26:7a6a:365a:60ff:fe0d:cfc6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-49c5d22394esm24799165f8f.3.2026.11.16.12.53.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Nov 2026 12:53:55 -0800 (PST) X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Type: multipart/signed; boundary=37fc961d2ca56be80f03ddce209a59446815f2f70d142ce639c6d949d73f; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Mon, 16 Nov 2026 21:53:49 +0100 Message-Id: Cc: "David Sterba" , "Namjae Jeon" , "Sungjong Seo" , "Alexander Viro" , "Christian Brauner" , "Trond Myklebust" , "Anna Schumaker" , "Chuck Lever" , "Jeff Layton" , "Konstantin Komarov" , "Paulo Alcantara" , "Chris Mason" , "Yuezhang Mo" , "Jan Kara" , "NeilBrown" , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , "Ronnie Sahlberg" , "Shyam Prasad N" , "Bharath SM" , "Sergey Senozhatsky" , "ChenXiaoSong" , "Darrick J . Wong" , "Sean Smith" , "Andrey Albershteyn" , "Pedro Falcato" , =?utf-8?q?Pali_Roh=C3=A1r?= , , , , , , , , Subject: Re: [RFC PATCH v4 01/10] vfs: add provenance time (ptime) From: "koraynilay" To: "Amir Goldstein" , "koraynilay" X-Mailer: aerc 0.22.0-0-gc2f86b7abde3 References: <20261115180343.576773-1-koray.fra@gmail.com> <20261115180343.576773-2-koray.fra@gmail.com> In-Reply-To: --37fc961d2ca56be80f03ddce209a59446815f2f70d142ce639c6d949d73f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Mon Nov 16, 2026 at 9:10 PM CET, Amir Goldstein wrote: > On Sun, Nov 15, 2026 at 7:04=E2=80=AFPM koraynilay = wrote: >> >> Add provenance time (ptime), indicating the time when a file or >> directory was created. This is user-settable via file_setattr() and >> retrievable via statx(2) (using STATX_PTIME) or file_getattr(). >> >> The semantics of when to preserve this new timestamp are the same as >> mtime, the idea being that there is a correspondence like this: >> >> ctime <-> btime >> mtime <-> ptime >> >> so every operation (copying, moving, ...) that currently preserves mtime >> should also preserve ptime. >> >> Also add fa_xflags_mask to struct file_attr (and equivalent > > That is a very big "Also" part > This is a significant UAPI change that needs to be delivered and > explained with a patch on its own. Right, that definitely makes more sense, I didn't think of that lol. >> fsx_xflags_mask to struct file_kattr) to let the filesystems advertise >> their support for specific xflags and users advertise what they want to >> change, behaving like statx.stx_attributes_mask: >> - on GET (file_getattr): each filesystem fills the mask according to >> their supported xflags, e.g. FS_XFLAG_PTIME or FS_XFLAG_COWEXTSIZE, >> and provides the values in the corresponding struct fields; >> - on SET (file_setattr): userspace fills the mask according to which >> xflags it wants to change, VFS validates this and preserves xflags >> that were not specified in the mask; >> - if xflags_mask =3D=3D 0, use legacy full-struct replacement to keep >> compatibility with older programs. >> >> Furthermore, in order to avoid the legacy FS_IOC_FSSETXATTR accepting >> FS_XFLAG_PTIME, add an FS_FILE_ATTR_XFLAGS_MASK mask to support new >> xflags and use it in fileattr_to_file_attr()/file_attr_to_fileattr() to >> validate that the xflags passed in xflags and xflags_mask fields are >> valid. >> >> Finally, add the missing FS_XFLAG_PROJID flag, to allow userspace to set >> the projid using file_[sg]etattr(). > > This part also belongs with the xflags_mask patch Ok. >> >> [ This is a re-implementation of the initial patch[1] by Sean Smith >> , following the advice[2] from Darrick J. >> Wong of using file_setattr() instead of updating >> utimensat() ] >> >> [1]: https://lore.kernel.org/20260405195007.1306-2-DefendTheDisabled@gma= il.com >> [2]: https://lore.kernel.org/20260407014129.GC6192@frogsfrogsfrogs >> >> Assisted-by: Gemini:3.8-flash-high antigravity-cli-1.4.7 >> Signed-off-by: koraynilay >> --- >> fs/file_attr.c | 75 +++++++++++++++++++++++++++++++++++++-- >> fs/stat.c | 2 ++ >> include/linux/fileattr.h | 6 ++++ >> include/linux/stat.h | 1 + >> include/uapi/linux/fs.h | 9 ++++- >> include/uapi/linux/stat.h | 7 +++- >> 6 files changed, 95 insertions(+), 5 deletions(-) >> >> diff --git a/fs/file_attr.c b/fs/file_attr.c >> index 833e03810b24..12610fb6a751 100644 >> --- a/fs/file_attr.c >> +++ b/fs/file_attr.c >> @@ -102,14 +102,23 @@ EXPORT_SYMBOL(vfs_fileattr_get); >> static void fileattr_to_file_attr(const struct file_kattr *fa, >> struct file_attr *fattr) >> { >> - __u32 mask =3D FS_XFLAGS_MASK; >> + /* >> + * fsx_xflags_mask contains only flags added after the >> + * file_[gs]etattr() API, so we need to tell userspace the files= ystem >> + * actually supports all legacy and new advertised flags >> + */ >> + __u32 mask =3D (FS_XFLAGS_MASK | fa->fsx_xflags_mask) & >> + FS_FILE_ATTR_XFLAGS_MASK; >> >> memset(fattr, 0, sizeof(struct file_attr)); >> fattr->fa_xflags =3D fa->fsx_xflags & mask; >> + fattr->fa_xflags_mask =3D mask; >> fattr->fa_extsize =3D fa->fsx_extsize; >> fattr->fa_nextents =3D fa->fsx_nextents; >> fattr->fa_projid =3D fa->fsx_projid; >> fattr->fa_cowextsize =3D fa->fsx_cowextsize; >> + fattr->fa_ptime_sec =3D fa->fsx_ptime.tv_sec; >> + fattr->fa_ptime_nsec =3D fa->fsx_ptime.tv_nsec; >> } >> >> /** >> @@ -141,15 +150,23 @@ EXPORT_SYMBOL(copy_fsxattr_to_user); >> static int file_attr_to_fileattr(const struct file_attr *fattr, >> struct file_kattr *fa) >> { >> - __u64 mask =3D FS_XFLAGS_MASK; >> + __u64 mask =3D fattr->fa_xflags_mask ?: FS_XFLAGS_MASK; >> + >> + if (fattr->fa_xflags_mask & ~FS_FILE_ATTR_XFLAGS_MASK) >> + return -EINVAL; >> >> if (fattr->fa_xflags & ~mask) >> return -EINVAL; >> >> fileattr_fill_xflags(fa, fattr->fa_xflags & ~FS_XFLAG_RDONLY_MAS= K); >> + fa->fsx_xflags_mask =3D fattr->fa_xflags_mask; >> fa->fsx_extsize =3D fattr->fa_extsize; >> fa->fsx_projid =3D fattr->fa_projid; >> fa->fsx_cowextsize =3D fattr->fa_cowextsize; >> + if (fattr->fa_xflags_mask & FS_XFLAG_PTIME) { >> + fa->fsx_ptime.tv_sec =3D fattr->fa_ptime_sec; >> + fa->fsx_ptime.tv_nsec =3D fattr->fa_ptime_nsec; >> + } >> >> return 0; >> } >> @@ -232,6 +249,23 @@ static int fileattr_set_prepare(struct inode *inode= , >> !S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode)) >> return -EINVAL; >> >> + if (fa->fsx_xflags_mask & FS_XFLAG_PTIME) { >> + if (!(old_ma->fsx_xflags_mask & FS_XFLAG_PTIME)) >> + return -EOPNOTSUPP; >> + >> + if (!(fa->fsx_xflags & FS_XFLAG_PTIME)) >> + return -EINVAL; >> + >> + if ((unsigned long)fa->fsx_ptime.tv_nsec >=3D NSEC_PER_S= EC) >> + return -EINVAL; >> + >> + fa->fsx_ptime =3D timestamp_truncate(fa->fsx_ptime, inod= e); >> + >> + if (!timespec64_equal(&old_ma->fsx_ptime, &fa->fsx_ptime= ) && >> + (fa->flags & old_ma->flags) & (FS_APPEND_FL | FS_IMM= UTABLE_FL)) >> + return -EPERM; > > I don't know what this is but it looks strange. That's for preserv- ok nevermind it's probably not needed anymore since adding fsx_xflags_mask. I'll check that too for v5. > >> + } >> + >> /* >> * It is only valid to set the DAX flag on regular files and >> * directories on filesystems. >> @@ -288,13 +322,41 @@ int vfs_fileattr_set(const struct mnt_idmap *idmap= , struct dentry *dentry, >> if (!err) { >> /* initialize missing bits from old_ma */ >> if (fa->flags_valid) { >> - fa->fsx_xflags |=3D old_ma.fsx_xflags & ~FS_XFLA= G_COMMON; >> + /* FS_IOC_SETFLAGS */ >> + fa->fsx_xflags |=3D (old_ma.fsx_xflags & FS_XFLA= GS_MASK) & >> + ~FS_XFLAG_COMMON; >> fa->fsx_extsize =3D old_ma.fsx_extsize; >> fa->fsx_nextents =3D old_ma.fsx_nextents; >> fa->fsx_projid =3D old_ma.fsx_projid; >> fa->fsx_cowextsize =3D old_ma.fsx_cowextsize; >> + fa->fsx_ptime =3D old_ma.fsx_ptime; >> } else { >> + /* >> + * Preserve unmasked xflags when running file_se= tattr() >> + * with a mask, which doesn't need a read-modify= -write >> + * so these attributes would be set to 0. >> + * >> + * With FS_IOC_FSSETXATTR or mask =3D=3D 0 (lega= cy mode) >> + * this is not needed as userspace does >> + * read-modify-write already. >> + */ >> + if (fa->fsx_xflags_mask) { >> + fa->fsx_xflags |=3D old_ma.fsx_xflags & >> + ~fa->fsx_xflags_mask; >> + fileattr_fill_xflags(fa, fa->fsx_xflags = & >> + ~FS_XFLAG_RDONLY_MA= SK); >> + if (!(fa->fsx_xflags_mask & FS_XFLAG_EXT= SIZE)) >> + fa->fsx_extsize =3D old_ma.fsx_e= xtsize; >> + if (!(fa->fsx_xflags_mask & FS_XFLAG_PRO= JID)) >> + fa->fsx_projid =3D old_ma.fsx_pr= ojid; >> + if (!(fa->fsx_xflags_mask & FS_XFLAG_COW= EXTSIZE)) >> + fa->fsx_cowextsize =3D old_ma.fs= x_cowextsize; >> + } >> fa->flags |=3D old_ma.flags & ~FS_COMMON_FL; >> + >> + /* xflags not present in fsxattr */ >> + if (!(fa->fsx_xflags_mask & FS_XFLAG_PTIME)) >> + fa->fsx_ptime =3D old_ma.fsx_ptime; >> } >> > > This whole flags/xflags duality needs a closer look > This looks a bit too complicated right now. Yes, I agree. > I don't have time to do the full review so wanted to give you the > main feedback first. > > I'll try to get to it this week. Of course, no problem, I also still have a few kinda unrelated patches to work on and a fairly long list of bugs to fix (found by sashiko), so v5 will probably be ready this weekend/next week anyway. Thank you again very much. Best, koraynilay > Thanks, > Amir. --37fc961d2ca56be80f03ddce209a59446815f2f70d142ce639c6d949d73f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSgVimKafU5DQMcjcDmj22qf5IGXAUCavttXQAKCRDmj22qf5IG XLKyAQDUbIPDnr/fz9a76CKxleC/LzaQMjyuAgz3koP+G7YFrwD/QwnPpap95GR9 4QZordaDbvLNae5E2c5s96XsV/AKmAA= =1jPB -----END PGP SIGNATURE----- --37fc961d2ca56be80f03ddce209a59446815f2f70d142ce639c6d949d73f--