Linux filesystem development
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Gary Guo" <gary@garyguo.net>
Cc: <boqun@kernel.org>, <aliceryhl@google.com>, <lyude@redhat.com>,
	<daniel.almeida@collabora.com>, <work@onurozkan.dev>,
	<ojeda@kernel.org>, <bjorn3_gh@protonmail.com>,
	<lossin@kernel.org>, <a.hindborg@kernel.org>, <tmgross@umich.edu>,
	<tamird@kernel.org>, <acourbot@nvidia.com>,
	<viro@zeniv.linux.org.uk>, <brauner@kernel.org>, <jack@suse.cz>,
	<linux-kernel@vger.kernel.org>, <rust-for-linux@vger.kernel.org>,
	<linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] rust: sync: add WaitQueue infrastructure
Date: Wed, 18 Nov 2026 13:22:24 +0100	[thread overview]
Message-ID: <DMYC07XW5HN0.2N8G5STNNZ8GR@kernel.org> (raw)
In-Reply-To: <DMXGWCITETPM.1OCWS0ISXH5RP@garyguo.net>

On Tue Nov 17, 2026 at 12:59 PM CET, Gary Guo wrote:
> The first paragraph is rendered as rustdoc short item description so please
> have something more descriptive and leave the C equivalence to other pragraphs.

diff --git a/rust/kernel/sync/wait.rs b/rust/kernel/sync/wait.rs
--- a/rust/kernel/sync/wait.rs
+++ b/rust/kernel/sync/wait.rs
@@ -35,6 +35,8 @@
 pub use new_waitqueue;

+/// A wait queue for sleeping until a condition becomes true.
+///
 /// Exposes the kernel's [`struct wait_queue_head`] as a Rust wait queue.
 ///
 /// A `WaitQueue` allows a thread to sleep until a caller-supplied condition becomes true,

  reply	other threads:[~2026-11-18 12:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  0:14 [PATCH v3 0/5] rust: sync: add WaitQueue infrastructure Danilo Krummrich
2026-11-17  0:14 ` [PATCH v3 1/5] rust: task: add safe schedule_timeout() wrapper Danilo Krummrich
2026-11-17  0:45   ` FUJITA Tomonori
2026-11-17 11:40     ` Gary Guo
2026-11-17 11:56       ` Danilo Krummrich
2026-11-17 12:02         ` Gary Guo
2026-11-17 13:14           ` Danilo Krummrich
2026-11-17 14:16   ` Alice Ryhl
2026-11-17  0:14 ` [PATCH v3 2/5] rust: sync: add WaitQueue infrastructure Danilo Krummrich
2026-11-17 11:59   ` Gary Guo
2026-11-18 12:22     ` Danilo Krummrich [this message]
2026-11-17 14:16   ` Alice Ryhl
2026-11-17  0:14 ` [PATCH v3 3/5] rust: sync: convert CondVar and PollCondVar to use WaitQueue Danilo Krummrich
2026-11-17 14:16   ` Alice Ryhl
2026-11-18 10:49   ` Gary Guo
2026-11-17  0:14 ` [PATCH v3 4/5] rust: sync: condvar: use task::schedule_timeout() Danilo Krummrich
2026-11-17 14:16   ` Alice Ryhl
2026-11-17 22:06     ` FUJITA Tomonori
2026-11-17  0:14 ` [PATCH v3 5/5] rust: sync: condvar: add non-exclusive freezable waiting Danilo Krummrich
2026-11-17 14:16   ` Alice Ryhl
2026-11-18 10:49   ` Gary Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMYC07XW5HN0.2N8G5STNNZ8GR@kernel.org \
    --to=dakr@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=brauner@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=lyude@redhat.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox