Linux filesystem development
 help / color / mirror / Atom feed
From: Bernd Schubert <bernd@bsbernd.com>
To: Gang He <dchg2000@gmail.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: Fuse over io_uring mode cannot handle iodepth > 1 case properly like the default mode
Date: Fri, 15 Aug 2025 22:56:17 +0200	[thread overview]
Message-ID: <E1CDDCDF-0461-4522-985E-07EF212FE927@bsbernd.com> (raw)
In-Reply-To: <CAGmFzScM+UFXCuw5F3B3rZ8iFFyZxwSwBHJD6XwPnHVtqr5JMg@mail.gmail.com>

On August 15, 2025 9:45:34 AM GMT+02:00, Gang He <dchg2000@gmail.com> wrote:
>Hi Bernd,
>
>Sorry for interruption.
>I tested your fuse over io_uring patch set with libfuse null example,
>the fuse over io_uring mode has better performance than the default
>mode. e.g., the fio command is as below,
>fio -direct=1 --filename=/mnt/singfile --rw=read  -iodepth=1
>--ioengine=libaio --bs=4k --size=4G --runtime=60 --numjobs=1
>-name=test_fuse1
>
>But, if I increased fio iodepth option, the fuse over io_uring mode
>has worse performance than the default mode. e.g., the fio command is
>as below,
>fio -direct=1 --filename=/mnt/singfile --rw=read  -iodepth=4
>--ioengine=libaio --bs=4k --size=4G --runtime=60 --numjobs=1
>-name=test_fuse2
>
>The test result showed the fuse over io_uring mode cannot handle this
>case properly. could you take a look at this issue? or this is design
>issue?
>
>I went through the related source code, I do not understand each
>fuse_ring_queue thread has only one  available ring entry? this design
>will cause the above issue?
>the related code is as follows,
>dev_uring.c
>1099
>1100     queue = ring->queues[qid];
>1101     if (!queue) {
>1102         queue = fuse_uring_create_queue(ring, qid);
>1103         if (!queue)
>1104             return err;
>1105     }
>1106
>1107     /*
>1108      * The created queue above does not need to be destructed in
>1109      * case of entry errors below, will be done at ring destruction time.
>1110      */
>1111
>1112     ent = fuse_uring_create_ring_ent(cmd, queue);
>1113     if (IS_ERR(ent))
>1114         return PTR_ERR(ent);
>1115
>1116     fuse_uring_do_register(ent, cmd, issue_flags);
>1117
>1118     return 0;
>1119 }
>
>
>Thanks
>Gang


Hi Gang,

we are just slowly traveling back with my family from Germany to France - sorry for delayed responses.

Each queue can have up to N ring entries - I think I put in max 65535.

The code you are looking at will just add new entries to per queue lists.

I don't know why higher fio io-depth results in lower performance. A possible reason is that /dev/fuse request get distributed to multiple threads, while fuse-io-uring might all go the same thread/ring. I had posted patches recently that add request  balancing between queues. 

Cheers,
Bernd



Cheers,
Bernd

  reply	other threads:[~2025-08-15 20:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-15  7:45 Fuse over io_uring mode cannot handle iodepth > 1 case properly like the default mode Gang He
2025-08-15 20:56 ` Bernd Schubert [this message]
2025-08-18  1:39   ` Gang He
2025-08-18 17:31     ` Bernd Schubert
2025-08-19  2:16       ` Gang He
     [not found]         ` <CAGmFzSdD71SxAxCJp5BbJZ7-JVARtoDPPScGvxhTF=+HQ+D6jw@mail.gmail.com>
2025-09-18  8:38           ` Bernd Schubert
2025-09-24 21:09             ` Bernd Schubert
2025-09-25  6:52               ` Gang He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1CDDCDF-0461-4522-985E-07EF212FE927@bsbernd.com \
    --to=bernd@bsbernd.com \
    --cc=dchg2000@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox