linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, Christoph Hellwig <hch@lst.de>,
	Mel Gorman <mel@skynet.ie>,
	William Lee Irwin III <wli@holomorphy.com>,
	David Chinner <dgc@sgi.com>, Jens Axboe <jens.axboe@oracle.com>,
	Badari Pulavarty <pbadari@gmail.com>,
	Maxim Levitsky <maximlevitsky@gmail.com>,
	Fengguang Wu <fengguang.wu@gmail.com>,
	swin wang <wangswin@gmail.com>,
	totty.lu@gmail.com, hugh@veritas.com, joern@lazybastard.org
Subject: Re: [patch 19/19] Use page_cache_xxx in drivers/block/rd.c
Date: Thu, 29 Nov 2007 16:32:41 +0800	[thread overview]
Message-ID: <396325170.21410@ustc.edu.cn> (raw)
Message-ID: <E1Ixep7-0004SV-Pq@localhost> (raw)
In-Reply-To: <20071129011148.733429253@sgi.com>

On Wed, Nov 28, 2007 at 05:11:11PM -0800, Christoph Lameter wrote:
> Use page_cache_xxx in drivers/block/rd.c
> 
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
> ---
>  drivers/block/rd.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Index: mm/drivers/block/rd.c
> ===================================================================
> --- mm.orig/drivers/block/rd.c	2007-11-28 12:19:49.673905513 -0800
> +++ mm/drivers/block/rd.c	2007-11-28 14:13:01.076977633 -0800
> @@ -122,7 +122,7 @@ static void make_page_uptodate(struct pa
>  			}
>  		} while ((bh = bh->b_this_page) != head);
>  	} else {
> -		memset(page_address(page), 0, PAGE_CACHE_SIZE);
> +		memset(page_address(page), 0, page_cache_size(page_mapping(page)));
>  	}
>  	flush_dcache_page(page);
>  	SetPageUptodate(page);
> @@ -215,9 +215,9 @@ static const struct address_space_operat
>  static int rd_blkdev_pagecache_IO(int rw, struct bio_vec *vec, sector_t sector,
>  				struct address_space *mapping)
>  {
> -	pgoff_t index = sector >> (PAGE_CACHE_SHIFT - 9);
> +	pgoff_t index = sector >> (page_cache_size(mapping) - 9);
                                   page_cache_shift

Cheers,
Fengguang


  reply	other threads:[~2007-11-29  8:32 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29  1:10 [patch 00/19] Page cache: Replace PAGE_CACHE_xx with inline functions Christoph Lameter
2007-11-29  1:10 ` [patch 01/19] Define functions for page cache handling Christoph Lameter
2007-11-29  3:06   ` David Chinner
2007-11-29  3:21     ` Christoph Lameter
     [not found]   ` <E1Ixf0M-0004lI-0Z@localhost>
2007-11-29  8:44     ` Fengguang Wu
2007-11-29 19:23       ` Christoph Lameter
2007-11-29  1:10 ` [patch 02/19] Use page_cache_xxx functions in mm/filemap.c Christoph Lameter
2007-11-29  1:10 ` [patch 03/19] Use page_cache_xxx in mm/page-writeback.c Christoph Lameter
2007-11-29  1:10 ` [patch 04/19] Use page_cache_xxx in mm/truncate.c Christoph Lameter
2007-11-29  1:10 ` [patch 05/19] Use page_cache_xxx in mm/rmap.c Christoph Lameter
2007-11-29  3:19   ` David Chinner
2007-11-29  3:30     ` Christoph Lameter
2007-11-29  3:59       ` David Chinner
2007-11-29  4:09         ` Christoph Lameter
2007-11-29  4:11           ` David Chinner
2007-11-29  1:10 ` [patch 06/19] Use page_cache_xxx in mm/filemap_xip.c Christoph Lameter
     [not found]   ` <E1IxfXc-0005sC-9J@localhost>
2007-11-29  9:18     ` Fengguang Wu
2007-11-29  1:10 ` [patch 07/19] Use page_cache_xxx in mm/migrate.c Christoph Lameter
2007-11-29  1:11 ` [patch 08/19] Use page_cache_xxx in fs/libfs.c Christoph Lameter
2007-11-29  1:11 ` [patch 09/19] Use page_cache_xxx in fs/sync Christoph Lameter
2007-11-29  1:11 ` [patch 10/19] Use page_cache_xxx in fs/buffer.c Christoph Lameter
2007-11-29  3:34   ` David Chinner
2007-11-29  3:48     ` Christoph Lameter
2007-11-29  4:01       ` David Chinner
2007-11-29  1:11 ` [patch 11/19] Use page_cache_xxx in mm/mpage.c Christoph Lameter
2007-11-29  1:11 ` [patch 12/19] Use page_cache_xxx in mm/fadvise.c Christoph Lameter
2007-11-29  1:11 ` [patch 13/19] Use page_cache_xxx in fs/splice.c Christoph Lameter
2007-11-29  3:40   ` David Chinner
2007-11-29  3:50     ` Christoph Lameter
2007-11-29  4:02       ` David Chinner
2007-11-29  1:11 ` [patch 14/19] Use page_cache_xxx in ext2 Christoph Lameter
2007-11-29  3:45   ` David Chinner
2007-11-29  3:55     ` Christoph Lameter
2007-11-29  4:06       ` David Chinner
2007-11-29  4:15         ` Christoph Lameter
2007-11-29  4:19           ` David Chinner
2007-11-29  1:11 ` [patch 15/19] Use page_cache_xxx in fs/ext3 Christoph Lameter
2007-11-29  1:11 ` [patch 16/19] Use page_cache_xxx in fs/ext4 Christoph Lameter
2007-11-29  3:48   ` David Chinner
2007-11-29  3:58     ` Christoph Lameter
2007-11-29  4:07       ` David Chinner
2007-11-29  1:11 ` [patch 17/19] Use page_cache_xxx in fs/reiserfs Christoph Lameter
2007-11-29  3:54   ` David Chinner
2007-11-29  4:02     ` Christoph Lameter
2007-11-29  4:08       ` David Chinner
2007-11-29  1:11 ` [patch 18/19] Use page_cache_xxx for fs/xfs Christoph Lameter
2007-11-29  3:03   ` David Chinner
2007-11-29  3:28     ` Christoph Lameter
2007-11-29  3:58       ` David Chinner
2007-11-29  4:06         ` Christoph Lameter
2007-11-29  4:10           ` David Chinner
2007-11-29  8:24             ` Andrew Morton
2007-11-29  1:11 ` [patch 19/19] Use page_cache_xxx in drivers/block/rd.c Christoph Lameter
     [not found]   ` <E1Ixep7-0004SV-Pq@localhost>
2007-11-29  8:32     ` Fengguang Wu [this message]
2007-11-29  4:20 ` [patch 00/19] Page cache: Replace PAGE_CACHE_xx with inline functions David Chinner
2007-11-29  8:29   ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2007-11-30 17:34 [patch 00/19] Page cache: Replace PAGE_CACHE_xx with inline functions V2 Christoph Lameter
2007-11-30 17:35 ` [patch 19/19] Use page_cache_xxx in drivers/block/rd.c Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=396325170.21410@ustc.edu.cn \
    --to=wfg@mail.ustc.edu.cn \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=dgc@sgi.com \
    --cc=fengguang.wu@gmail.com \
    --cc=hch@lst.de \
    --cc=hugh@veritas.com \
    --cc=jens.axboe@oracle.com \
    --cc=joern@lazybastard.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maximlevitsky@gmail.com \
    --cc=mel@skynet.ie \
    --cc=pbadari@gmail.com \
    --cc=totty.lu@gmail.com \
    --cc=wangswin@gmail.com \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).