From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2045.outbound.protection.outlook.com [40.107.93.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 358EC1FBEA6; Fri, 20 Jun 2025 20:06:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.45 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750450015; cv=fail; b=Ms7eXR48KvC0DcjzL6sH5Zbg0esA6QWAwMeElKLckoxR2STs8NzT3YTW0eiecHgLX+cZd2SpFDYj4rAgWgobryIaynqA7wWVNrElbBXZik0kbWxAt3iu0zSaF2UvqGkxljspDTPOZECOHI5lTjT7GDcs3yAoGFv862w49844YEs= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750450015; c=relaxed/simple; bh=kUDL7uHRxq7i0BtV7qoAIpW7uhQWXFI+sLl2PT35oJ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=CncB/boa2Q3R6OE5Rb/8J2c+XLMZgGU+veTLQGA/xvtNnva7Xu8foDj/Y25pNKWt/iMZsCU+qblJteCJVGCFlVAiCTdaCR1lp51pmcFaZI9vXSZZF8xQcjdVt7ZGC4NbWqO/AU01vGvazZXyTyhEU81xsn2TO3YLDQRYuBYADcw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Dm4IfULu; arc=fail smtp.client-ip=40.107.93.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Dm4IfULu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F42g4YSSWDIfQtrl5RB/DDtHU+j0oDNxRDNkpoRQSP9Tw6KfRt0dYv1C1ZxQHvJJGEMqsiZUxQwvZ61XbOSSbn3THzGYkxX501tqQg6C5emGdoeuXMeLCCZ7v3CsYpabrgFYfug9mofO7Nr57CXs5iuJ2mvCxJaGgfsNKaUBGQMVJ4k1kvzT9qObrmy7UJEp0+nzoBY0bmrEE3FIxzN+t1fBMNc9aFJx6R/07Z7P8+EjphguX6nbMmsOuyzFzdESecXexOaFtuPmFKkai5VY0Gtl1s23cX0nPJpW9bxApIUbDDJifFf0tkBZ8sYMmmpdYPKOqXcULxWR5uY6WPni/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JRJaq032iquXnTMM6Wkdoa5RDmHyA/miLDygjjtrhDs=; b=eItk1JoLtbxsSgHg+DPhJVotqoSKnirwILN+eAdkpoyf4K1yc8nVC6T/i/A7nieTbLNhgKRczIQjH3lV2oezaMa0gZ07VaAaWlb9xP9K9sYp8klZpyN4vG1wV54z53h7nlCAidJzAEO3HdW3rb0RNnQOqmryIQ4zhAAkHAq6spG+YfT1K+z/aS9UVAVtIN5c1a+ToZ5t68SH6QwTGEDabwLSPq+ASXhLYD1licRu0++/xx20Jw/8ZKe8Ez8lxh51lEhdt2KGwTVWSoCQcD4IYCfJNd5OKR0Rtq2NLdoKw0Cm/YZ1xKZGIJ2rIuRFks5zpfchtIM9fZLox6WLXLLUcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JRJaq032iquXnTMM6Wkdoa5RDmHyA/miLDygjjtrhDs=; b=Dm4IfULuWKzL7aCIpginek1PubzYPoT/ZQCW3NiUrxQ6OUW9HiqQV3d4NxO+jYKfLGT88m69R7+C875lwM5Gv/d8hu5NPJ792TxUXQq1RHv3xyN+SqZVMbEWRyVNZ8fRAA71+weyxVRjszOjw/o+d4PTVt5gHZeIDFipEbu8STpn3rjb+J/DIyRIIbCEMZIFMhjRoODz2B8E36jf4Xuy7Gx/eG/GWptJSJablrOY/kTsJMGHu4Nql3px24+LFq0eThYXod4TyBY/xqJewLRdlXRFYIJf9irR9F9NtuEPvgG+/qFzQLwiAJaS9UwL8vDvxmVb0eJnun06oh2SfUnrSA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by LV8PR12MB9205.namprd12.prod.outlook.com (2603:10b6:408:191::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.28; Fri, 20 Jun 2025 20:06:50 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8835.037; Fri, 20 Jun 2025 20:06:50 +0000 From: Zi Yan To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?utf-8?q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: Re: [PATCH RFC 11/29] mm/migrate: move movable_ops page handling out of move_to_new_folio() Date: Fri, 20 Jun 2025 16:06:44 -0400 X-Mailer: MailMate (2.0r6263) Message-ID: In-Reply-To: <20250618174014.1168640-12-david@redhat.com> References: <20250618174014.1168640-1-david@redhat.com> <20250618174014.1168640-12-david@redhat.com> Content-Type: text/plain X-ClientProxiedBy: MN0P221CA0027.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:52a::21) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|LV8PR12MB9205:EE_ X-MS-Office365-Filtering-Correlation-Id: f91ec0e3-0b37-4668-2280-08ddb035fe75 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?hp9Sqn6rAn5RHT7MTEUIGzMMx1gehCQo/IgxOFg3m20fZqkoYUnaQORs13ay?= =?us-ascii?Q?RTYzYE4Z0S8nVbZKbjrAeWZH+VsBEwMJ5hflcGa1VY/QSJEpwbAcYF6KZGqC?= =?us-ascii?Q?aWzPqY9SodUq+c/wEKbyytSeEb7/OVU/8s/JoGkripOUa1I693o20mKFBfmJ?= =?us-ascii?Q?wK2BBssXnfhCh1IrAuZML9jC4A4K+YSSGzeVQcNiQjtw2fGH9xcasmXidXeK?= =?us-ascii?Q?KwR1pm1AnwCm32SuWEikw7pl+aZwpB+PkqqcksE2dPyOV3o51gQBCfcUOVP4?= =?us-ascii?Q?s+p2sc+azN9ATIQT8zGkDFavzMrkbDSPWP4stdeeQE4kq9lfUCbxexizmvuu?= =?us-ascii?Q?9eV/D+hBba0ApNQRdPkUQ1Mv5vGo7KO/twxXABKaqWogWlburPG2Dw6kweO7?= =?us-ascii?Q?dd58lH/9qkLY4LPER7FsM41ovWoEdznrDPX0gAAj0EOCa3pPmy7k0eH2XL76?= =?us-ascii?Q?ZmGRvVLtls2/bAPZPbrXmbd3MB7lEqB3nFEcSBbJWFe7nX9F10gmBJi95YNC?= =?us-ascii?Q?oPuh8sgnOMlKBENWyKwEd57nZ8nkAkLenvr8lDiTfzCSH73cLfoFEYL7mYya?= =?us-ascii?Q?ire+08RmZ7w9Bvp4H8Gg5KaXPk5V3INQOxBqR31IwjPiJUrMMGcdTl4Bbu9L?= =?us-ascii?Q?RoXjVRTIsu48lqN4lXUu+5kAf4GjL+w7/P7eXSK8QlOsc6Rk1LmmrNpXRAgj?= =?us-ascii?Q?+ABq/oMLEikFcP63xq/0f4Lf2jcSqv7Br446Ysi6o+bQ/XX/uBtczn+NnDpq?= =?us-ascii?Q?9OIkjhk5aunYv8zW4pWmkuw058xLKOzd5D/fObhmos4Gu975iGWXmHQFDztj?= =?us-ascii?Q?5ZqGBt9lA6SXo7QadTPDkXBTCNH3MwWEYvVTtczTW7+aa0GRud+Jq1CQjYkA?= =?us-ascii?Q?9itt9kVxOVq224kkk4WWxEbDdJFZ62BkQhQKCbVSQCiKQqru4Fv1+CDQoBln?= =?us-ascii?Q?ku6aTxmVK1kWmgDYhDMFGDQ0b4lIGdhayWASEJwBkiq9D8O8OQ14v0fu/OEz?= =?us-ascii?Q?HWOSOO233aTIWhAVGPCDK5Kqg4DE4+xRsLXhmRTGVFjaJDedTpNx97NLUgLi?= =?us-ascii?Q?WO9uzaHKoAjFzOE7g9qbx2gx9bElvRM/z50bPekyqyV0SH6xbsz94Yr4Cz1y?= =?us-ascii?Q?wsfZn9Wi6UPAvFn4DTBF+RpPtzeQR8YqOnNOBQaIi7U8UmHSQNbB0wXucZHr?= =?us-ascii?Q?T8gI5UV6+6c18QX27+b4LOxxVGzp1ZdXHrFuQLcBicoQzhymkl8qlTetZA1Y?= =?us-ascii?Q?++sVJFrJWp0on9JN+E0SzrviQEaWJj9m1U7d6x48I5BaG4fbVzcgT32zgHdP?= =?us-ascii?Q?Ta73rRObAx6ivx4UoV4OQISXhgQ3qB9TE0sEZmhqWob7Z6yVnUAiB3WLfqPy?= =?us-ascii?Q?JiMGiGCojbJaL4EZgK62zc9p9EtY4zJG+7Hew8UCJPS9w+WteAG09ltgqoAS?= =?us-ascii?Q?hSFe8KsmCS8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kYVLuixCyaGPErnqEgzP5HsDEMkJtwsmHCwOPxDcKUXcpFz/zdLXnzCZSyn5?= =?us-ascii?Q?MQQkuEAWjol0tzrnlU9Qu6pii/XjAK7AtPd+MJNP53C4picCJpKWz1J9G1bo?= =?us-ascii?Q?UTf+P6CaODpjNM29naPH0avf3YdCDrzoWm8SiAbdFfVShoupUEVBFb4Rc31S?= =?us-ascii?Q?Gv6MIj8FNiW94cvvByJXbd2ycUupDECySv0riuH6J897CfV1Y+VE1HXsmN8B?= =?us-ascii?Q?w9Tp8NnbD7CjfNbuP7KgfYBJFVfBjXIp3Yl/9ANWT7KLwDHxbYMHNoHKmFtY?= =?us-ascii?Q?X5VgQl04aiHPb4HrDwqgGZFJobcuzlgC16pNRVYLRYULC6M3tlHCBU3VG8i/?= =?us-ascii?Q?jWML7xGRRn8aNKoMQ9i5oc1pxEyxXjCmGT7UDo0+BYj7SVY8fju/cOcJBp11?= =?us-ascii?Q?bMotkCB7mdwURMHs+bcuLqD1RA8qbO4yMKt65g7TA9Ibisd6Y8uTB3IrQ99U?= =?us-ascii?Q?SBCwNeS2tpNS4PN/D6kwQMz8YIg7X7B2GdZtvTMsj6ZFmgPwyGXCp9d5zfhz?= =?us-ascii?Q?/VjOOQMQQ1x9N6Gw6A2dN8ZyujvwA3rXROrEk6SKKPPrJT8745OFsMURo16n?= =?us-ascii?Q?i8fl6NQZfhPuswK/ENzre9SwpCFIr1gVijbndPngvhDANDKxKAAWmOopnx6W?= =?us-ascii?Q?08lUZXLr81glmM5JOhdYVJN4Lk+FlkPShPGSd+lZnW8JnjAv9++hpNxPMcrk?= =?us-ascii?Q?CyoIDDhCQOeoWv7Lb9SC7kVvoI9Qy2gkkvmZyQ1pKzJVJBcbm8+tFDywSv83?= =?us-ascii?Q?WlvY7JAZ8eKqiViOsoEWnzzmIUd5i1g4doycGcX7oBxFAnsygWs1+lNxDzIZ?= =?us-ascii?Q?CAjpRQKvLmqiTivOHbsBBZpuXRcZy7wJGYocuo0snQXB8xqeXgs6Wj7HJkN9?= =?us-ascii?Q?6sz0bcyxVA5LNS1v8hfB4jYS7ml9mWdAX6R7rL6NOW84383w+wUCzPkQ9fLr?= =?us-ascii?Q?pfftkcXoEFz7hBlrzQ7JnuCqFRY1SfIdOn2AuRT3TM0T3P1kNLyz/7JxEPE9?= =?us-ascii?Q?KEzN7D0FampZ2KrbCbZj+Pz6oGKsoxfzqwdFUIFQ0oYQ990H9PYygcD0Ocib?= =?us-ascii?Q?c0Wbz6XsM4RRxH3dz6JzwVkcT3IhEm9muGLXBP0Ff7z6xvxVK37DNXnwKu9p?= =?us-ascii?Q?E+gP8xAQkkPM7p6zS7QtUiCyHtFaaxRqUs8MtCqbgFmTchwcOVx0N6Dzjk8t?= =?us-ascii?Q?NgqbKgHdvkgljQ1X8vlyNNRBfj3Rs/4a7pQeJcLueMPYo0SRKfD7LAmTxqZh?= =?us-ascii?Q?Aw1oFntesEY3J165ZePbFLKAFB+XvDwiwpInSeiTJHxus2mC6ZHur1Z1Y7Ds?= =?us-ascii?Q?9hKGCRj0Xs9QJ6nsmcZ3r6oGlskGo3M1AtlO5hYyaofZEKZLngR8HPjt8kbn?= =?us-ascii?Q?4S56oc4SSygjcMEvDxfql7uqTZ3pLJ5Ellg/Ir1enJ0eps3SCkMDC+/7y/+s?= =?us-ascii?Q?qdhd0sJKLmETF3yRV3ywqZbTTJiHjTcmZgBIvVDKee82L5FNwbKLVHY5ueU7?= =?us-ascii?Q?+eIG69rFF5r5rEIfpzTr1Sx8cZJ9IZB+kjgdBI0BALimPUMjRvaEcwF8yG3x?= =?us-ascii?Q?m/xI67lRACRxfDmKMARGyMW9+KxlWz9kIeyP7Zo+?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f91ec0e3-0b37-4668-2280-08ddb035fe75 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2025 20:06:50.7737 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CYmwVt8LDFQcC8zyVRqocWIo9Q2sRCOBGehikOTPLaBkTQuhbx8rFJhEPBl9Y5P9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9205 On 18 Jun 2025, at 13:39, David Hildenbrand wrote: > Let's move that handling directly into migrate_folio_move(), so we can > simplify move_to_new_folio(). While at it, fixup the documentation a > bit. > > Note that unmap_and_move_huge_page() does not care, because it only > deals with actual folios. (we only support migration of > individual movable_ops pages) > > Signed-off-by: David Hildenbrand > --- > mm/migrate.c | 61 ++++++++++++++++++++++++---------------------------- > 1 file changed, 28 insertions(+), 33 deletions(-) > Reviewed-by: Zi Yan -- Best Regards, Yan, Zi