From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka J Enberg Subject: Re: [RFC/PATCH] revoke/frevoke system calls V2 Date: Thu, 27 Jul 2006 20:05:57 +0300 (EEST) Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@osdl.org, viro@zeniv.linux.org.uk, alan@lxorguk.ukuu.org.uk, tytso@mit.edu, tigran@veritas.com Return-path: To: Ulrich Drepper In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 7/27/06, Pekka J Enberg wrote: > > +asmlinkage int sys_revoke(const char __user *filename) On Thu, 27 Jul 2006, Ulrich Drepper wrote: > Could we just plainly avoid adding any new syscalls which take a > filename without extending the interface like the *at functions? > I.e., add a file descriptor parameter, handle AT_FDCWD, etc. The > additional effort is really minimal. Even if, as in this case, the > function is propably not used in situations where the filename use is > racy there are still those people to consider who want to implement a > virtual per-thread current working directory. Sure. Though I wonder if sys_frevoke is enough for us and we can drop sys_revoke completely. Pekka