From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka J Enberg Subject: Re: Re: [RFC/PATCH] revoke/frevoke system calls V2 Date: Thu, 27 Jul 2006 20:07:47 +0300 (EEST) Message-ID: References: <1154012822.13509.52.camel@localhost.localdomain> <84144f020607270833v4c981d00w8e3e643406aea7a@mail.gmail.com> <1154016589.13509.56.camel@localhost.localdomain> <1154017809.13509.64.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@osdl.org, viro@zeniv.linux.org.uk, tytso@mit.edu, tigran@veritas.com Return-path: Received: from courier.cs.helsinki.fi ([128.214.9.1]:46221 "EHLO mail.cs.helsinki.fi") by vger.kernel.org with ESMTP id S1751776AbWG0RHs (ORCPT ); Thu, 27 Jul 2006 13:07:48 -0400 To: Alan Cox In-Reply-To: <1154017809.13509.64.camel@localhost.localdomain> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Ar Iau, 2006-07-27 am 19:01 +0300, ysgrifennodd Pekka J Enberg: > > Yes revoke calls it too, but is that sufficient, or do we need ->revoke? > > Ouch. You are right. I need to stick that invalidate_inode_pages2 > > back in there. The do_fsync call takes care of writes only, obviously. On Thu, 27 Jul 2006, Alan Cox wrote: > Actually that isn't true either - it takes care of *regular file* > writes. Devices will need a revoke hook and thats really probably only > right. If they don't have one just -EOPNOTSUPP, you can check it before > you begin any other processing so its easy to check. Ah, you're right. So I'll make a generic_file_revoke and f_ops->revoke that can be used by filesystems to do sync and inode page invalidation. That hook should be sufficient for device drivers too? Pekka