From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Altaparmakov Subject: Re: [PATCH] block new writers on frozen filesystems Date: Sun, 13 Feb 2005 15:05:22 +0000 (GMT) Message-ID: References: <20050210161331.GA9001@lst.de> <20050210151427.3fc65d56.akpm@osdl.org> <20050213142027.GA1733@lst.de> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Andrew Morton , linux-fsdevel@vger.kernel.org Received: from ppsw-3.csi.cam.ac.uk ([131.111.8.133]:58064 "EHLO ppsw-3.csi.cam.ac.uk") by vger.kernel.org with ESMTP id S261276AbVBMPF0 (ORCPT ); Sun, 13 Feb 2005 10:05:26 -0500 To: Christoph Hellwig In-Reply-To: <20050213142027.GA1733@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sun, 13 Feb 2005, Christoph Hellwig wrote: > > > + vfs_check_frozen(inode->i_sb, SB_FREEZE_WRITE); > > > > hm, I didn't pay much attention to this stuff. Shouldn't the direct-io > > code be waiting as well? Are all paths which can write to the bdev supposed > > to be blocked? kjournald? > > This should block new data writers. New metadata writes need to be > blocked in the individual filesystem, and only when the state is set > to SB_FREEZE_TRANS (a few steps later in freeze_bdev). Why this distinction? At least on NTFS metadata is stored in normal files (everything is a file in NTFS) and the same readpage/writepage address space operations are used to access both... Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/