linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] NTFS: Set ictx->ir in ntfs_index_lookup
@ 2005-07-22 22:38 Yura Pakhuchiy
  2005-07-23  6:49 ` Anton Altaparmakov
  0 siblings, 1 reply; 2+ messages in thread
From: Yura Pakhuchiy @ 2005-07-22 22:38 UTC (permalink / raw)
  To: Anton Altaparmakov; +Cc: linux-fsdevel, NTFS dev list

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

Hi Anton,

I found bug in libntfs and after look at kernel driver it's seems that
it's present in it too. ictx->ir is not set in ntfs_index_lookup if
entry is placed in INDEX_ROOT, but it should point to INDEX_ROOT in
which this entry placed.

Signed-off-by: Yura Pakhuchiy <pakhuchiy@gmail.com>

-- 
Best regards,
        Yura

[-- Attachment #2: set_index_root.diff --]
[-- Type: text/x-patch, Size: 407 bytes --]

diff -ruNp -X kernel.ignore ntfs-2.6-devel/fs/ntfs/index.c ntfs-2.6-yura/fs/ntfs/index.c
--- ntfs-2.6-devel/fs/ntfs/index.c	2005-07-01 00:38:49.000000000 +0300
+++ ntfs-2.6-yura/fs/ntfs/index.c	2005-07-22 23:47:18.000000000 +0300
@@ -209,6 +209,7 @@ ir_done:
 			ictx->base_ni = base_ni;
 			ictx->ia = NULL;
 			ictx->page = NULL;
+			ictx->ir = ir;
 done:
 			ictx->entry = ie;
 			ictx->data = (u8*)ie +

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] NTFS: Set ictx->ir in ntfs_index_lookup
  2005-07-22 22:38 [PATCH] NTFS: Set ictx->ir in ntfs_index_lookup Yura Pakhuchiy
@ 2005-07-23  6:49 ` Anton Altaparmakov
  0 siblings, 0 replies; 2+ messages in thread
From: Anton Altaparmakov @ 2005-07-23  6:49 UTC (permalink / raw)
  To: Yura Pakhuchiy; +Cc: linux-fsdevel, NTFS dev list

Hi Yura,

On Sat, 23 Jul 2005, Yura Pakhuchiy wrote:
> I found bug in libntfs and after look at kernel driver it's seems that
> it's present in it too. ictx->ir is not set in ntfs_index_lookup if
> entry is placed in INDEX_ROOT, but it should point to INDEX_ROOT in
> which this entry placed.

Well spotted, thanks.  Fix will be in next ntfs release.

Best regards,

	Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-07-23  6:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-22 22:38 [PATCH] NTFS: Set ictx->ir in ntfs_index_lookup Yura Pakhuchiy
2005-07-23  6:49 ` Anton Altaparmakov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).