From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Zippel Subject: Re: [PATCH][RFC] fix reservation discarding in affs Date: Thu, 10 Feb 2005 13:57:04 +0100 (CET) Message-ID: References: <20041212134545.GA6612@lst.de> <20050210103947.GA2622@lst.de> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: linux-fsdevel@vger.kernel.org Received: from scrub.xs4all.nl ([194.109.195.176]:40328 "EHLO scrub.xs4all.nl") by vger.kernel.org with ESMTP id S262112AbVBJM5F (ORCPT ); Thu, 10 Feb 2005 07:57:05 -0500 To: Christoph Hellwig In-Reply-To: <20050210103947.GA2622@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hi, On Thu, 10 Feb 2005, Christoph Hellwig wrote: > > affs already does it in a) and a few other places, so adding it to > > affs_clear_inode should make it behave fine. Also move the truncate > > from affs_put_inode with the racy i_count check to affs_clear_inode. > > This also avoids the need to take the inode semaphore as the inode can't > > be accessed from other threads anymore. > > ping? Looks fine. There is still somewhat the problem that I don't want to hold on to the preallocation for ages for directories and very useful would be a callback to flush preallocation when the disk becomes full. Previously I tried it via sync, but maybe someone has an idea how to do this properly. bye, Roman