linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org, zippel@linux-m68k.org
Subject: Re: ctime/mtime update in affs and hpfs write path
Date: Thu, 3 Nov 2005 01:29:48 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.62.0511030126540.2023@artax.karlin.mff.cuni.cz> (raw)
In-Reply-To: <20051031235306.GA21218@lst.de>



On Tue, 1 Nov 2005, Christoph Hellwig wrote:

> Both AFFS and HPFS update the ctime and mtime in the write path, after
> generic_file_write returned and mark the inode dirty.  Anyone's got an
> idea why these two filesystems aren't happy with the ctime/mtime updates
> vi generic_file_write before we copied the data into the pagecache?

In HPFS, there's no reason for mtime update --- just that it was left when 
porting code from older kernels. If generic_file_write updates it, you can 
remove update in HPFS.

As for inode dirty --- HPFS has its own dirty mechanism different from the 
kernel to avoid deadlocks (writing inode on HPFS needs to lock parent 
directory and you can't do it from ->write_inode method) --- let it be, it 
may be slower, but it's stable.

Mikulas

      parent reply	other threads:[~2005-11-03  0:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-31 23:53 ctime/mtime update in affs and hpfs write path Christoph Hellwig
2005-11-01  1:03 ` Roman Zippel
2005-11-01  1:07   ` [PATCH] remove superflous ctime/mtime updates in affs Christoph Hellwig
2005-11-01  1:20     ` Roman Zippel
2005-11-03  0:29 ` Mikulas Patocka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.62.0511030126540.2023@artax.karlin.mff.cuni.cz \
    --to=mikulas@artax.karlin.mff.cuni.cz \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).