From mboxrd@z Thu Jan  1 00:00:00 1970
From: James Morris <jmorris@namei.org>
Subject: Re: [PATCH 7/12: eCryptfs] File operations
Date: Thu, 3 Nov 2005 18:49:25 -0500 (EST)
Message-ID: <Pine.LNX.4.63.0511031848280.22256@excalibur.intercode>
References: <20051103033220.GD2772@sshock.rn.byu.edu> <20051103035210.GG3005@sshock.rn.byu.edu>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com,
	yoder1@us.ibm.com
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail26.sea5.speakeasy.net ([69.17.117.28]:30599 "EHLO
	mail26.sea5.speakeasy.net") by vger.kernel.org with ESMTP
	id S1030543AbVKCXt1 (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 3 Nov 2005 18:49:27 -0500
To: Phillip Hellewell <phillip@hellewell.homeip.net>
In-Reply-To: <20051103035210.GG3005@sshock.rn.byu.edu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wed, 2 Nov 2005, Phillip Hellewell wrote:

> +	rc = wait_event_interruptible(fl->fl_wait, !fl->fl_next);
> +	if (!rc) {
> +		goto lock_file;
> +	}

> +	} else {
> +		tempfl = posix_test_lock(file, fl);
> +	}
> +	if (!tempfl) {
> +		fl->fl_type = F_UNLCK;
> +	} else {
> +		memcpy(fl, tempfl, sizeof(struct file_lock));
> +	}

Pointless braces (all over the place).


- James
-- 
James Morris
<jmorris@namei.org>